superreview granted: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better caps
Mark Mentovai <mark@moxienet.com> has granted Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net>'s request for superreview: Bug 383545: "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" https://bugzilla.mozilla.org/show_bug.cgi?id=383545 Attachment 294627: Don't Quit, now with better caps https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit ...

superreview granted: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> d'oh! I should have caught that. Leave the debug code in. ...

superreview granted: [Bug 344887] "ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity : [Attachment 229630] address review comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 344887: "ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity https://bugzilla.mozilla.org/show_bug.cgi?id=344887 Attachment 229630: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=229630&action=edit ...

superreview requested: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better caps
Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 383545: "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" https://bugzilla.mozilla.org/show_bug.cgi?id=383545 Attachment 294627: Don't Quit, now with better caps https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit ------- Additional Comments from Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> r=me. Thanks for fixing the code as well. ...

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 267672] Request: groups (when "group by sort") should have the number of read and unread emails : [Attachment 192746] don't show the unread count if there aren't any unread
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 267672: Request: groups (when "group by sort") should have the number of read and unread emails https://bugzilla.mozilla.org/show_bug.cgi?id=267672 Attachment 192746: don't show the unread count if there aren't any unread messages https://bugzilla.mozilla.org/attachment.cgi?id=192746&action=edit ...

superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@mindspring.com>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialog
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 147374: fix error dialog http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit ...

superreview granted: [Bug 436214] Deleting an imap message offline can cause an assertion nsMsgHdr::SetThreadParent "can't be your own parent : [Attachment 323133] remove stuff that didn't belong in p
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 436214: Deleting an imap message offline can cause an assertion nsMsgHdr::SetThreadParent "can't be your own parent https://bugzilla.mozilla.org/show_bug.cgi?id=3D436214 Attachment 323133: remove stuff that didn't belong in previous patch https://bugzilla.mozilla.org/attachment.cgi?id=3D323133&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >- attribute long ImapUidValidity;=0D >- a...

superreview granted: [Bug 343221] "ASSERTION: didn't find frame to delete" putting overflow:hidden on <svg:circle> : [Attachment 227678] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 343221: "ASSERTION: didn't find frame to delete" putting overflow:hidden on <svg:circle> https://bugzilla.mozilla.org/show_bug.cgi?id=343221 Attachment 227678: patch https://bugzilla.mozilla.org/attachment.cgi?id=227678&action=edit ...

superreview requested: [Bug 344887] "ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity : [Attachment 229630] address review comments
Robert Longson <longsonr@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 344887: "ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity https://bugzilla.mozilla.org/show_bug.cgi?id=344887 Attachment 229630: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=229630&action=edit ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai (limited availability May 19-25) <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ...