superreview granted: [Bug 418206] Some SVG files that appear to hang Mozilla : [Attachment 304500] patch addressing review comments

Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Jonathan Watt
<jwatt@jwatt.org>'s request for superreview:
Bug 418206: Some SVG files that appear to hang Mozilla
https://bugzilla.mozilla.org/show_bug.cgi?id=418206

Attachment 304500: patch addressing review comments
https://bugzilla.mozilla.org/attachment.cgi?id=304500&action=edit

------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org>
Can we have a mochitest for this?
0
bugzilla
2/20/2008 11:50:36 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
831 Views

Similar Articles

[PageSpeed] 6
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 339543] microsummaries trigger bookmarked files to be downloaded : [Attachment 225855] patch v3: addresses review comments
Mike Connor <mconnor@mozilla.com> has granted superreview: Bug 339543: microsummaries trigger bookmarked files to be downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=339543 Attachment 225855: patch v3: addresses review comments https://bugzilla.mozilla.org/attachment.cgi?id=225855&action=edit ...

superreview granted: [Bug 230320] New features for download manager: trash button, clean only disappeared files : [Attachment 193345] Patch addressing review comments
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@ipl.com>'s request for superreview: Bug 230320: New features for download manager: trash button, clean only disappeared files https://bugzilla.mozilla.org/show_bug.cgi?id=230320 Attachment 193345: Patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=193345&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview granted: [Bug 361901] Save Page menuitem label missing from File menu when DM is open : [Attachment 247269] Updated patch that addresses review comments (and not using strres.js)
Stefan <stefanh@bluebottle.com> has granted superreview: Bug 361901: Save Page menuitem label missing from File menu when DM is open https://bugzilla.mozilla.org/show_bug.cgi?id=361901 Attachment 247269: Updated patch that addresses review comments (and not using strres.js) https://bugzilla.mozilla.org/attachment.cgi?id=247269&action=edit ------- Additional Comments from Stefan <stefanh@bluebottle.com> This fixes the review comments and is without strres.js. I think we should do this for trunk as well - I'll try to fix the rest of the issues in the 1.9. Anyw...

superreview granted: [Bug 348455] [FIX]Review comments in bug 285727 never got addressed : [Attachment 233863] Patch
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 348455: [FIX]Review comments in bug 285727 never got addressed https://bugzilla.mozilla.org/show_bug.cgi?id=348455 Attachment 233863: Patch https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit ...

superreview granted: [Bug 317027] Classinfo is incorrect for some SVG nodes : [Attachment 203913] address review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 317027: Classinfo is incorrect for some SVG nodes https://bugzilla.mozilla.org/show_bug.cgi?id=317027 Attachment 203913: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=203913&action=edit ...

superreview granted: [Bug 184811] addressingwidget appears as sunken, not as button : [Attachment 200984] Addressed review comment
jag (Peter Annema) <jag@tty.nl> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 184811: addressingwidget appears as sunken, not as button https://bugzilla.mozilla.org/show_bug.cgi?id=184811 Attachment 200984: Addressed review comment https://bugzilla.mozilla.org/attachment.cgi?id=200984&action=edit ...

superreview granted: [Bug 176637] Custom link colors not rendered correctly : [Attachment 139312] patch with review comments addressed
Boris Zbarsky <bz-vacation@mit.edu> has granted Andreas Kunz <durbacher@gmx.de>'s request for superreview: Bug 176637: Custom link colors not rendered correctly http://bugzilla.mozilla.org/show_bug.cgi?id=176637 Attachment 139312: patch with review comments addressed http://bugzilla.mozilla.org/attachment.cgi?id=139312&action=edit ------- Additional Comments from Boris Zbarsky <bz-vacation@mit.edu> sr=me. I assume you need this checked in too? ...

superreview granted: [Bug 258081] Tons of build warnings in svg frame code : [Attachment 181000] address review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 258081: Tons of build warnings in svg frame code https://bugzilla.mozilla.org/show_bug.cgi?id=258081 Attachment 181000: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=181000&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsISVGChildFrame.h >+ // Check if this frame or children contain the given point, >+ // specified in pixels relative to the origin of the outer svg >+ /...

superreview granted: [Bug 419746] SVG crash in gfxASurface::SetDeviceOffset() via nsSVGMaskFrame::ComputeMaskAlpha() : [Attachment 309599] address review comment
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 419746: SVG crash in gfxASurface::SetDeviceOffset() via nsSVGMaskFrame::ComputeMaskAlpha() https://bugzilla.mozilla.org/show_bug.cgi?id=419746 Attachment 309599: address review comment https://bugzilla.mozilla.org/attachment.cgi?id=309599&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> Looks good ...

superreview requested: [Bug 339543] microsummaries trigger bookmarked files to be downloaded : [Attachment 225855] patch v3: addresses review comments
Myk Melez <myk@mozilla.org> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 339543: microsummaries trigger bookmarked files to be downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=339543 Attachment 225855: patch v3: addresses review comments https://bugzilla.mozilla.org/attachment.cgi?id=225855&action=edit ------- Additional Comments from Myk Melez <myk@mozilla.org> Thanks Christian; requesting super-review from mconnor in case your review doesn't suffice. ...

superreview granted: [Bug 363710] Removing text node from SVG <text> has no visible effect : [Attachment 248982] address review comment
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 363710: Removing text node from SVG <text> has no visible effect https://bugzilla.mozilla.org/show_bug.cgi?id=363710 Attachment 248982: address review comment https://bugzilla.mozilla.org/attachment.cgi?id=248982&action=edit ...

superreview cancelled: [Bug 293485] Changing an IDL file does not rebuild IDLs that include it (IDL dependencies) : [Attachment 206658] improved patch and addressed review comments
Mike Shaver <shaver@mozilla.org> has cancelled neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com>'s request for superreview: Bug 293485: Changing an IDL file does not rebuild IDLs that include it (IDL dependencies) https://bugzilla.mozilla.org/show_bug.cgi?id=293485 Attachment 206658: improved patch and addressed review comments https://bugzilla.mozilla.org/attachment.cgi?id=206658&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> cancelling outdated (I think, though the patch isn't obsoleted) sr request ...

superreview granted: [Bug 123315] Search plugins [engines] should be installed in the user's profile directory : [Attachment 187603] patch addressing review comments
Mike Shaver <shaver@mozilla.org> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 123315: Search plugins [engines] should be installed in the user's profile directory https://bugzilla.mozilla.org/show_bug.cgi?id=123315 Attachment 187603: patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=187603&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> >+ else if (nsCRT::strcmp(prop, NS_APP_USER_SEARCH_DIR) == 0) >+ { >+ rv = NS_GetSpecialDirectory(NS_AP...

superreview requested: [Bug 230320] New features for download manager: trash button, clean only disappeared files : [Attachment 193345] Patch addressing review comments
Bruce Davidson <Bruce.Davidson@ipl.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 230320: New features for download manager: trash button, clean only disappeared files https://bugzilla.mozilla.org/show_bug.cgi?id=230320 Attachment 193345: Patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=193345&action=edit ...

superreview requested: [Bug 293485] Changing an IDL file does not rebuild IDLs that include it (IDL dependencies) : [Attachment 206658] improved patch and addressed review comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 293485: Changing an IDL file does not rebuild IDLs that include it (IDL dependencies) https://bugzilla.mozilla.org/show_bug.cgi?id=293485 Attachment 206658: improved patch and addressed review comments https://bugzilla.mozilla.org/attachment.cgi?id=206658&action=edit ...

Web resources about - superreview granted: [Bug 418206] Some SVG files that appear to hang Mozilla : [Attachment 304500] patch addressing review comments - mozilla.dev.super-review

Resources last updated: 12/4/2015 1:44:57 PM