superreview granted: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 309397] remove gfx/src/windows, its references, and imgScaler (v3)

Stuart Parmenter <pavlov@pavlov.net> has granted Peter Weilbacher
<mozilla@Weilbacher.org>'s request for superreview:
Bug 418104: Remove non-cairo Windows gfx code from the tree
https://bugzilla.mozilla.org/show_bug.cgi?id=418104

Attachment 309397: remove gfx/src/windows, its references, and imgScaler (v3)
https://bugzilla.mozilla.org/attachment.cgi?id=309397&action=edit
0
bugzilla
3/21/2008 9:34:27 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
603 Views

Similar Articles

[PageSpeed] 33
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 309397] remove gfx/src/windows, its references, and imgScaler (v3)
Peter Weilbacher <mozilla@Weilbacher.org> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 309397: remove gfx/src/windows, its references, and imgScaler (v3) https://bugzilla.mozilla.org/attachment.cgi?id=309397&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Thanks for the review and the hint about imgScaler. By now I verified that it is unused outside the Windows code, and so I update...

superreview requested: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 306729] remove gfx/src/windows and its references (v2)
Peter Weilbacher <mozilla@Weilbacher.org> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 306729: remove gfx/src/windows and its references (v2) https://bugzilla.mozilla.org/attachment.cgi?id=306729&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> OK, I convinced myself that the minimo and preloader files are outdated anyway (they still don't contain gkgfxthebes), so I don't thi...

superreview canceled: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 306729] remove gfx/src/windows and its references (v2)
Peter Weilbacher <mozilla@Weilbacher.org> has canceled Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 306729: remove gfx/src/windows and its references (v2) https://bugzilla.mozilla.org/attachment.cgi?id=306729&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Thanks for the review and the hint about imgScaler. By now I verified that it is unused outside the Windows code, and s...

superreview canceled: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 303917] remove it and its reference
Peter Weilbacher <mozilla@Weilbacher.org> has canceled Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 303917: remove it and its reference https://bugzilla.mozilla.org/attachment.cgi?id=303917&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> OK, I convinced myself that the minimo and preloader files are outdated anyway (they still don't contain gkgfxthebes), so I don't ...

superreview granted: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 309481] only changed files
Stuart Parmenter <pavlov@pavlov.net> has granted Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 309481: only changed files https://bugzilla.mozilla.org/attachment.cgi?id=309481&action=edit ...

superreview requested: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 309481] only changed files
Peter Weilbacher <mozilla@Weilbacher.org> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 418104: Remove non-cairo Windows gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418104 Attachment 309481: only changed files https://bugzilla.mozilla.org/attachment.cgi?id=309481&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Sure, that is easily done. Three trivially changed files, patch in this attachment. The files to be removed are: gfx/src/windows/.cvsignore gfx/src/windows/Makefi...

superreview canceled: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 304855] remove it and the remaining references
Josh Aas <joshmoz@gmail.com> has canceled Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=3D418105 Attachment 304855: remove it and the remaining references https://bugzilla.mozilla.org/attachment.cgi?id=3D304855&action=3Dedit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> Why not also remove nsMacGFX.rsrc? And everything in the printerplugin directory?=0D =0D The current patch doesn't compile because of the followi...

superreview requested: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 304855] remove it and the remaining references
Peter Weilbacher <mozilla@Weilbacher.org> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 304855: remove it and the remaining references https://bugzilla.mozilla.org/attachment.cgi?id=304855&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> I don't have a mac and so can't really test this but as I am in the mood for more cleanup/removal stuff, here is the patch. Only the f...

superreview granted: [Bug 279510] Remove TARGET_CARBON from widget/src/mac and gfx/src/mac : [Attachment 172478] remove TARGET_CARBON in gfx/src/mac
Simon Fraser <sfraser_bugs@smfr.org> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 279510: Remove TARGET_CARBON from widget/src/mac and gfx/src/mac https://bugzilla.mozilla.org/show_bug.cgi?id=279510 Attachment 172478: remove TARGET_CARBON in gfx/src/mac https://bugzilla.mozilla.org/attachment.cgi?id=172478&action=edit ------- Additional Comments from Simon Fraser <sfraser_bugs@smfr.org> Looks good although CurrentPortIsWMPort() could probably just go away. ...

superreview granted: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 306925] v4
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 306925: v4 https://bugzilla.mozilla.org/attachment.cgi?id=306925&action=edit ...

superreview requested: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 306744] patch v3
Peter Weilbacher <mozilla@Weilbacher.org> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 306744: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=306744&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> OK, I remembered the try server and uploaded this patch (together with the one for bug418104). It took a few trials to get it right but this one now really builds and uses...

superreview canceled: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 306744] patch v3
Peter Weilbacher <mozilla@Weilbacher.org> has canceled Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 306744: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=306744&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Comments addressed. ...

superreview requested: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 306925] v4
Josh Aas <joshmoz@gmail.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 306925: v4 https://bugzilla.mozilla.org/attachment.cgi?id=306925&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> Thanks, it is nice to have this cleaned up. Makes things less confusing for potential contributors and cleans up mxr results. ...

superreview canceled: [Bug 418105] Remove non-cairo Mac gfx code from the tree : [Attachment 306616] patch v2
Peter Weilbacher <mozilla@Weilbacher.org> has canceled Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 418105: Remove non-cairo Mac gfx code from the tree https://bugzilla.mozilla.org/show_bug.cgi?id=418105 Attachment 306616: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=306616&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> OK, I remembered the try server and uploaded this patch (together with the one for bug418104). It took a few trials to get it right but this one now really buil...

Web resources about - superreview granted: [Bug 418104] Remove non-cairo Windows gfx code from the tree : [Attachment 309397] remove gfx/src/windows, its references, and imgScaler (v3) - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/11/2015 5:03:40 PM