superreview granted: [Bug 407600] Compile SpiderMonkey with -Os on mac : [ Attachment 292465] Always use the production settings when building Firefox . (changes Mac to -Os, like linux)

Brendan Eich <brendan@mozilla.org> has granted Robert Sayre
<sayrer@gmail.com>'s request for superreview:
Bug 407600: Compile SpiderMonkey with -Os on mac
https://bugzilla.mozilla.org/show_bug.cgi?id=407600

Attachment 292465: Always use the production settings when building Firefox.
(changes Mac to -Os, like linux)
https://bugzilla.mozilla.org/attachment.cgi?id=292465&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Would be best to get bsmedberg or luser or another build module owner or peer
to r+ -- I can sr (I always build my optimized test js shells with -Os on Mac
OS X; IIRC there's a bug about using -Os globally, not sure where that stands).


Optimistically pre-approving.

/be
0
bugzilla
12/10/2007 8:37:26 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
693 Views

Similar Articles

[PageSpeed] 17

Reply:

Similar Artilces:

superreview granted: [Bug 239132] nsIWidget::SetTitle should use nsAString, not nsString : [Attachment 145569] fix nits (with mac/ changes). Actuallly change mac impl of SetTitle as darin requested.
Benjamin Smedberg <bsmedberg@covad.net> has granted Benjamin Smedberg <bsmedberg@covad.net>'s request for superreview: Bug 239132: nsIWidget::SetTitle should use nsAString, not nsString http://bugzilla.mozilla.org/show_bug.cgi?id=239132 Attachment 145569: fix nits (with mac/ changes). Actuallly change mac impl of SetTitle as darin requested. http://bugzilla.mozilla.org/attachment.cgi?id=145569&action=edit ------- Additional Comments from Benjamin Smedberg <bsmedberg@covad.net> r=me carrying over darin's sr asking for approval... I'll apply this ...

superreview requested: [Bug 222654] global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) : [Attachment 184366] Like attachment 184242 addressing
Chris Neale <bugzilla@cdn.cx> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 222654: global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) https://bugzilla.mozilla.org/show_bug.cgi?id=222654 Attachment 184366: Like attachment 184242 addressing many of neil's concerns from comment 31 https://bugzilla.mozilla.org/attachment.cgi?id=184366&action=edit ------- Additional Comments from Chris Neale <bugzilla@cdn.cx> - NS_ASSERTION(gStyleCache->mScrollbarsSheet, &...

superreview cancelled: [Bug 222654] global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) : [Attachment 184366] Like attachment 184242 addressing
Steffen Wilberg <steffen.wilberg@web.de> has cancelled Chris Neale <bugzilla@cdn.cx>'s request for superreview: Bug 222654: global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) https://bugzilla.mozilla.org/show_bug.cgi?id=222654 Attachment 184366: Like attachment 184242 addressing many of neil's concerns from comment 31 https://bugzilla.mozilla.org/attachment.cgi?id=184366&action=edit ...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview granted: [Bug 298937] TARGET_XPCOM_ABI not set in Mac OSX builds : [Attachment 187428] More portable? (untested)
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 298937: TARGET_XPCOM_ABI not set in Mac OSX builds https://bugzilla.mozilla.org/show_bug.cgi?id=298937 Attachment 187428: More portable? (untested) https://bugzilla.mozilla.org/attachment.cgi?id=187428&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> r=me, though I would really like cls to comment if possible. ...

superreview granted: [Bug 311565] Use cairo image surface on mac/win32 for performance : [Attachment 198841] switch mac and win32 to image backend
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 311565: Use cairo image surface on mac/win32 for performance https://bugzilla.mozilla.org/show_bug.cgi?id=311565 Attachment 198841: switch mac and win32 to image backend https://bugzilla.mozilla.org/attachment.cgi?id=198841&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> I assume you've discussed this with the other SVG people? I'm surprised that text, for ...

superreview granted: [Bug 222654] global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) : [Attachment 184444] complete patch v1.1
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 222654: global/scrollbars.css for native scrollbars different on Mac (many Firefox themes break scrollbars on Mac) https://bugzilla.mozilla.org/show_bug.cgi?id=222654 Attachment 184444: complete patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=184444&action=edit ------- Additional Comments from Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> >Index: mozilla/themes/classic/jar....

superreview granted: [Bug 280236] coercing an array containing an nsXPCConstructor to a string results in an uncatchable error : [Attachment 231710] patch v1.6
Johnny Stenback <jst@mozilla.org> has granted ben turner (use ben at songbirdnest dot com for email) <bent.mozilla@gmail.com>'s request for superreview: Bug 280236: coercing an array containing an nsXPCConstructor to a string results in an uncatchable error https://bugzilla.mozilla.org/show_bug.cgi?id=280236 Attachment 231710: patch v1.6 - Builds on Win32, Mac PPC, Mac Intel, Linux, Linux x86-64 https://bugzilla.mozilla.org/attachment.cgi?id=231710&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst. For the record,...

superreview granted: [Bug 294244] nsDeviceContextMac.cpp compiling fails with gcc-4.0.0 : [Attachment 183689] Build with gcc 4.0 on Mac
Darin Fisher <darin@meer.net> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 294244: nsDeviceContextMac.cpp compiling fails with gcc-4.0.0 https://bugzilla.mozilla.org/show_bug.cgi?id=294244 Attachment 183689: Build with gcc 4.0 on Mac https://bugzilla.mozilla.org/attachment.cgi?id=183689&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: mozilla/gfx/src/mac/nsUnicodeFallbackCache.h >+ return (((ScriptCode) NS_PTR_TO_INT32(v1)) == >+ ((ScriptCode) NS_PTR_TO_INT32(v2))); why...

superreview granted: [Bug 329144] [Mac] Classic: Selected items should use darker system highlight color : [Attachment 228597] Patch
neil@parkwaycc.co.uk <neil@httl.net> has granted Stefan <stefanh@bluebottle.com>'s request for superreview: Bug 329144: [Mac] Classic: Selected items should use darker system highlight color https://bugzilla.mozilla.org/show_bug.cgi?id=329144 Attachment 228597: Patch - change highlight colors etc https://bugzilla.mozilla.org/attachment.cgi?id=228597&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Should you move Modern's styles for consistency? ...

superreview granted: [Bug 256994] Error in "intl/src/mac" when trying to build Firefox with Apple GCC-3.5-tree-ssa : [Attachment 157100] Patch 1
Simon Fraser <sfraser@aol.net> has granted Jungshik Shin <jshin@mailaps.org>'s request for superreview: Bug 256994: Error in "intl/src/mac" when trying to build Firefox with Apple GCC-3.5-tree-ssa http://bugzilla.mozilla.org/show_bug.cgi?id=256994 Attachment 157100: Patch 1 http://bugzilla.mozilla.org/attachment.cgi?id=157100&action=edit ...

superreview granted: [Bug 321601] [Mac] Support Command+Option+Arrows for tab switching (like Camino) : [Attachment 207352] New version using a constant instead of <field/>
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Stefan <stefan_h@hem.utfors.se>'s request for superreview: Bug 321601: [Mac] Support Command+Option+Arrows for tab switching (like Camino) https://bugzilla.mozilla.org/show_bug.cgi?id=321601 Attachment 207352: New version using a constant instead of <field/> https://bugzilla.mozilla.org/attachment.cgi?id=207352&action=edit ...

superreview cancelled: [Bug 299404] Can't build dmg of Firefox debug build on Mac : [Attachment 187976] Put DeerPark debug builds in DeerParkDebug.app
Mark Mentovai <mark@moxienet.com> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 299404: Can't build dmg of Firefox debug build on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=299404 Attachment 187976: Put DeerPark debug builds in DeerParkDebug.app https://bugzilla.mozilla.org/attachment.cgi?id=187976&action=edit ...

superreview requested: [Bug 299404] Can't build dmg of Firefox debug build on Mac : [Attachment 187976] Put DeerPark debug builds in DeerParkDebug.app
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 299404: Can't build dmg of Firefox debug build on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=299404 Attachment 187976: Put DeerPark debug builds in DeerParkDebug.app https://bugzilla.mozilla.org/attachment.cgi?id=187976&action=edit ...

superreview granted: [Bug 279510] Remove TARGET_CARBON from widget/src/mac and gfx/src/mac : [Attachment 172494] remove TARGET_CARBON from widget/src/mac
Simon Fraser <sfraser_bugs@smfr.org> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 279510: Remove TARGET_CARBON from widget/src/mac and gfx/src/mac https://bugzilla.mozilla.org/show_bug.cgi?id=279510 Attachment 172494: remove TARGET_CARBON from widget/src/mac https://bugzilla.mozilla.org/attachment.cgi?id=172494&action=edit ...

Web resources about - superreview granted: [Bug 407600] Compile SpiderMonkey with -Os on mac : [ Attachment 292465] Always use the production settings when building Firefox . (changes Mac to -Os, like linux) - mozilla.dev.super-review

Resources last updated: 11/22/2015 3:26:38 AM