superreview granted: [Bug 399587] deleting a property from an object doesn' t notify that object's XOWs : [Attachment 294864] Updated to comments

Johnny Stenback (:jst) <jst@mozilla.org> has granted Blake Kaplan
<mrbkap@gmail.com>'s request for superreview:
Bug 399587: deleting a property from an object doesn't notify that object's
XOWs
https://bugzilla.mozilla.org/show_bug.cgi?id=399587

Attachment 294864: Updated to comments
https://bugzilla.mozilla.org/attachment.cgi?id=294864&action=edit

------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org>
- In nsWindowSH::DelProperty():

+  // Notify any XOWs on our outer window.

Would we want to do this for all XOWs? If so, we might be able to put this in
XPConnect's wrapped natives delProperty jsops hooks...

- In WrappedNative2WrapperMap::AddLink():

+    oldLink->next->prev = newLink;
+    newLink->next = oldLink->next;
+    oldLink->prev->next = newLink;
+    newLink->prev = oldLink->prev;
+    PR_INIT_CLIST(oldLink);

This won't do the right thing if oldLink is an empty list. Maybe you could use
PR_INSERT_LINK() to insert newLink after oldLink, and then
PR_REMOVE_AND_INIT_LINK() to remove oldLink. That ought to do the right thing
in all cases.

Leaving the optimization for a new bug is fine with me.

r+sr=jst with that.
0
bugzilla
12/30/2007 2:12:25 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
656 Views

Similar Articles

[PageSpeed] 4

Reply:

Similar Artilces:

superreview requested: [Bug 399587] deleting a property from an object doesn't notify that object's XOWs : [ Attachment 294864] Updated to comments
Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 399587: deleting a property from an object doesn't notify that object's XOWs https://bugzilla.mozilla.org/show_bug.cgi?id=399587 Attachment 294864: Updated to comments https://bugzilla.mozilla.org/attachment.cgi?id=294864&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ...

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 162166: fix review comments https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over r/sr, seeking branch approval. jst wants this for the plugin finder ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview granted: [Bug 208121] Some String properties of a Java object are read as 'null' by Javascript : [Attachment 137276] new patch addressed review comments, also add some null pointer check
Brendan Eich <brendan@mozilla.org> has granted Kyle Yuan <kyle.yuan@sun.com>'s request for superreview: Bug 208121: Some String properties of a Java object are read as 'null' by Javascript http://bugzilla.mozilla.org/show_bug.cgi?id=208121 Attachment 137276: new patch addressed review comments, also add some null pointer checking http://bugzilla.mozilla.org/attachment.cgi?id=137276&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> How about a followup bug to add an Init method and move fallible code from the ctor to...

superreview granted: [Bug 135994] anonymous table object doesn't force line break when parent 'display: inline' : [Attachment 186418] fix
David Baron <dbaron@mozillafoundation.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 135994: anonymous table object doesn't force line break when parent 'display: inline' https://bugzilla.mozilla.org/show_bug.cgi?id=135994 Attachment 186418: fix https://bugzilla.mozilla.org/attachment.cgi?id=186418&action=edit ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview granted: [Bug 346119] Code added in bug 338122 doesn't actually enforce document equality : [Attachment 231004] update prescontext's mDocument when new shell is set.
Boris Zbarsky <bzbarsky@mit.edu> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 346119: Code added in bug 338122 doesn't actually enforce document equality https://bugzilla.mozilla.org/show_bug.cgi?id=346119 Attachment 231004: update prescontext's mDocument when new shell is set. https://bugzilla.mozilla.org/attachment.cgi?id=231004&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks good. ...

superreview requested: [Bug 40680] OBJECT attribute 'codebase' doesn't affect relative 'data' URI : [Attachment 177518] 40680-1.diff
Daniel Brooks <db48x@yahoo.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40680: OBJECT attribute 'codebase' doesn't affect relative 'data' URI https://bugzilla.mozilla.org/show_bug.cgi?id=40680 Attachment 177518: 40680-1.diff https://bugzilla.mozilla.org/attachment.cgi?id=177518&action=edit ------- Additional Comments from Daniel Brooks <db48x@yahoo.com> that should fix it ...

superreview cancelled: [Bug 40680] OBJECT attribute 'codebase' doesn't affect relative 'data' URI : [Attachment 177518] 40680-1.diff
Daniel Brooks <db48x@yahoo.com> has cancelled Daniel Brooks <db48x@yahoo.com>'s request for superreview: Bug 40680: OBJECT attribute 'codebase' doesn't affect relative 'data' URI https://bugzilla.mozilla.org/show_bug.cgi?id=40680 Attachment 177518: 40680-1.diff https://bugzilla.mozilla.org/attachment.cgi?id=177518&action=edit ...

superreview granted: [Bug 279533] Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work : [Attachment 174475] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 279533: Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=279533 Attachment 174475: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=174475&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview granted: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171298] fix with smaug's comments
Darin Fisher (IBM) <darin@meer.net> has granted aaronr@us.ibm.com's request for superreview: Bug 278433: setvalue element doesn't use @value as context https://bugzilla.mozilla.org/show_bug.cgi?id=278433 Attachment 171298: fix with smaug's comments https://bugzilla.mozilla.org/attachment.cgi?id=171298&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> "valueAttr" over "valueattr" is generally preferred in mozilla code. ...

superreview requested: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> moving forward the r, requesting sr. ...

superreview granted: [Bug 239275] select object's onchange event fires without change : [Attachment 164657] patch that isn't malformed
Brian Ryner (IBM) <bryner@brianryner.com> has granted Brian Ryner (IBM) <bryner@brianryner.com>'s request for superreview: Bug 239275: select object's onchange event fires without change https://bugzilla.mozilla.org/show_bug.cgi?id=239275 Attachment 164657: patch that isn't malformed https://bugzilla.mozilla.org/attachment.cgi?id=164657&action=edit ...

superreview granted: [Bug 426555] ###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that : [Attachment 327098] Patch v3
Blake Kaplan <mrbkap@gmail.com> has granted superreview: Bug 426555: ###!!! ASSERTION: Oops! You're asking for a weak reference to = an object that doesn't support that https://bugzilla.mozilla.org/show_bug.cgi?id=3D426555 Attachment 327098: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D327098&action=3Dedit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> >+++ b/security/manager/ssl/src/nsClientAuthRemember.cpp=0D >+NS_IMPL_THREADSAFE_ISUPPORTS2(nsClientAuthRememberService, =0D >+ nsIObserver,=0D >+ nsSuppor...

superreview granted: [Bug 426555] ###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that : [Attachment 327110] Patch v4
Kai Engert (:kaie, kengert@redhat.com) <kaie@kuix.de> has granted superreview: Bug 426555: ###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that https://bugzilla.mozilla.org/show_bug.cgi?id=426555 Attachment 327110: Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=327110&action=edit ------- Additional Comments from Kai Engert (:kaie, kengert@redhat.com) <kaie@kuix.de> This is v3 with Blake's request from comment 13 addressed. Carrying forward his r+sr ...

superreview granted: [Bug 420585] Defining setters for properties of the global object doesn't work : [Attachment 306951] Fix
Johnny Stenback (:jst) <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 420585: Defining setters for properties of the global object doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=420585 Attachment 306951: Fix https://bugzilla.mozilla.org/attachment.cgi?id=306951&action=edit ...

superreview granted: [Bug 66410] Deleting addressbook should also delete corresponding mab file : [Attachment 171183] Don't always create a database file if one doesn't exist
Scott MacGregor <mscott@mozilla.org> has granted Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 66410: Deleting addressbook should also delete corresponding mab file https://bugzilla.mozilla.org/show_bug.cgi?id=66410 Attachment 171183: Don't always create a database file if one doesn't exist https://bugzilla.mozilla.org/attachment.cgi?id=171183&action=edit ...

superreview granted: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
Johnny Stenback <jst@mozilla.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst either way... ...

superreview granted: [Bug 263182] Page Info (Security tab) doesn't explain mixed secure/insecure : [Attachment 193950] Patch with Neil's comments addressed
Gavin Sharp <gavin.sharp@gmail.com> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 263182: Page Info (Security tab) doesn't explain mixed secure/insecure https://bugzilla.mozilla.org/show_bug.cgi?id=263182 Attachment 193950: Patch with Neil's comments addressed https://bugzilla.mozilla.org/attachment.cgi?id=193950&action=edit ...

Web resources about - superreview granted: [Bug 399587] deleting a property from an object doesn' t notify that object's XOWs : [Attachment 294864] Updated to comments - mozilla.dev.super-review

Resources last updated: 3/4/2016 10:18:42 AM