superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build

Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail -=
 do
not email) <alqahira@ardisson.org>'s request for superreview:
Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i=
conv
them to UTF-16 during build
https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918

Attachment 285687: trunk patch, v2
https://bugzilla.mozilla.org/attachment.cgi?id=3D285687&action=3Dedit

------- Additional Comments from Mark Mentovai <mark@moxienet.com>
Smokey, this looks really good.  There are some minor notes that you can ta=
ke
care of before chicken:=0D
=0D
>+STRINGS_FILES =3D resources/localized/English.lproj/CertificateDialogs.st=
rings
resources/localized/English.lproj/Localizable.strings
PreferencePanes/Appearance/English.lproj/Localizable.strings
PreferencePanes/Appearance/English.lproj/RegionNames.strings
PreferencePanes/Downloads/English.lproj/Localizable.strings
PreferencePanes/History/English.lproj/Localizable.strings
PreferencePanes/Navigation/English.lproj/Localizable.strings
PreferencePanes/Privacy/English.lproj/Localizable.strings
PreferencePanes/Security/English.lproj/Localizable.strings
PreferencePanes/Tabs/English.lproj/Localizable.strings
PreferencePanes/WebFeatures/English.lproj/Localizable.strings=0D
=0D
This should be broken up so that it lists one file per line, in the style of
DIRS and GARBAGE_DIRS.=0D
=0D
Put STRINGS_FILES and GENERATED_STRINGS_FILES after PLATFORM_INI_FILE, so t=
hat
all of the version-related stuff can stay together.  This becomes more
important when STRINGS_FILES experiences the vertical growth I've suggested=
..=0D
=0D
>+# Generate UTF-16BE strings files from UTF-8 strings.in files=0D
=0D
Someone reading this comment (well, me) will note that the comment says
UTF-16BE but the iconv invocation asks for UTF-16 without any mention of
endianness.  It's more correct for the comment to say that you're generating
UTF-16 with a BOM.  It's incidental that the output is UTF-16BE - specifying
"-t UTF-16" means you'll definitely get a BOM, but endianness is unspecifie=
d.=20
If you want to mention endianness because AppleGlot seems to require
big-endian, you can mention that it's incidental, but that iconv on Mac OS X
seems to always output big-endian when asked for UTF-16 with a BOM.=0D
=0D
>+	iconv -f UTF-8 -t UTF-16 $< > $@	  =0D
=0D
Looks like there's some trailing whitespace on this line.=
0
bugzilla
10/23/2007 1:04:06 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
532 Views

Similar Articles

[PageSpeed] 37
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> All of the same comments apply to this patch as to the trunk pat...

superreview denied: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has denied Smokey Ardisson (no bugmail - = do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> In the Makefile:=0D =0D When you find yourself writing the same thing over and over ...

superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Who said Sunday afternoons had to be boring? Our .strings files w...

superreview canceled: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has canceled Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ...

superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I've ...

superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #4
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I'...

superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #3
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285687: trunk patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=285687&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> OK, here's the trunk patch that (I think) implements all of mento'...

superreview granted: [Bug 383465] Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable : [Attachment 267581] Makes four files utf-8 encoded
neil@parkwaycc.co.uk <neil@httl.net> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 383465: Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable https://bugzilla.mozilla.org/show_bug.cgi?id=383465 Attachment 267581: Makes four files utf-8 encoded https://bugzilla.mozilla.org/attachment.cgi?id=267581&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Although I would have thought sr was unnecessary for comment "typo" fixes ;-) ...

superreview granted: [Bug 390909] =?UTF-8?Q?=20Tabspos=C3=A9=20allows=20cli?= =?UTF-8?Q?cking=20in=20bookmark=20bar?= =?UTF-8?Q?=20without=20reflecting=20a?==?UTF-8?Q?ction?=
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Jeff Dlouhy <Jeff.Dlouhy@gmail.com>'s request for superreview: Bug 390909: Tabspos=C3=A9 allows clicking in bookmark bar without reflectin= g action https://bugzilla.mozilla.org/show_bug.cgi?id=3D390909 Attachment 282503: Disable Actions Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D282503&action=3Dedit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.e= du> >+ [[NSApp delegate] delayedAdjustBookmarksMenuItemsEnabling];=0D =0D BVC doesn't (and shouldn&...

superreview granted: [Bug 261249] activex should treat utf-8 strings as utf-8 : [Attachment 159875] patch
Darin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 261249: activex should treat utf-8 strings as utf-8 https://bugzilla.mozilla.org/show_bug.cgi?id=261249 Attachment 159875: patch https://bugzilla.mozilla.org/attachment.cgi?id=159875&action=edit ...

superreview granted: [Bug 395033]=?UTF-8?Q?=20Use=20Gecko=2Dbased=20thum?= =?UTF-8?Q?bnailing=20for=20Tabspos?==?UTF-8?Q?=C3=A9?=
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 395033: Use Gecko-based thumbnailing for Tabspos=C3=A9 https://bugzilla.mozilla.org/show_bug.cgi?id=3D395033 Attachment 279747: trunk fix https://bugzilla.mozilla.org/attachment.cgi?id=3D279747&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=3Dpink= ...

superreview granted: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274702: Initial Patch (revised v9) https://bugzilla.mozilla.org/attachment.cgi?id=3D274702&action=3Dedit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.e= du> (Adding pink's sr+ flag)= ...

superreview granted: [Bug 382685]=?UTF-8?Q?=20Allow=20selection=20of=20f?= =?UTF-8?Q?iles=20with=20type=20TEXT=20i?= =?UTF-8?Q?n=20Open=20File=E2=80=A6=20dialog?=
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (= no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 382685: Allow selection of files with type TEXT in Open File=E2=80=A6 d= ialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D382685 Attachment 266806: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D266806&action=3Dedit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.e= du> sr=3Dsmorgan= ...

superreview granted: [Bug 388356] nsXULPopupManager.h:124: warning: =?UTF-8?Q?=20=E2=80=98DirectionFromKeyC?= =?UTF-8?Q?ode=5Flr=5Ftb=E2=80=99=20defined=20?==?UTF-8?Q?but=20not=20used?=
Johnny Stenback <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.co= m>'s request for superreview: Bug 388356: nsXULPopupManager.h:124: warning: =E2=80=98DirectionFromKeyCode= _lr_tb=E2=80=99 defined but not used https://bugzilla.mozilla.org/show_bug.cgi?id=3D388356 Attachment 272552: Fix warnings https://bugzilla.mozilla.org/attachment.cgi?id=3D272552&action=3Dedit= ...

Web resources about - superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build - mozilla.dev.super-review

Resources last updated: 12/10/2015 8:21:02 AM