superreview granted: [Bug 390178] Can't focus elements within panel popup with the mouse if noautohide attribute is set to true : [Attachment 313421] This seems to work. Don't activate anything when c
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted Neil Deakin <enndeakin@gmail.com>'s request for superreview: Bug 390178: Can't focus elements within panel popup with the mouse if noautohide attribute is set to true https://bugzilla.mozilla.org/show_bug.cgi?id=390178 Attachment 313421: This seems to work. Don't activate anything when clicking with the mouse https://bugzilla.mozilla.org/attachment.cgi?id=313421&action=edit
|
0 |
|
bugzilla
4/6/2008 5:11:15 AM
mozilla.dev.super-review
29307 articles. 
3 followers.
0 Replies
784 Views
Similar Artilces:
superreview requested: [Bug 390178] Can't focus elements within panel popup with the mouse if noautohide attribute is set to true : [Attachment 313421] This seems to work. Don't activate anything when
Neil Deakin <enndeakin@gmail.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 390178: Can't focus elements within panel popup with the mouse if noautohide attribute is set to true https://bugzilla.mozilla.org/show_bug.cgi?id=390178 Attachment 313421: This seems to work. Don't activate anything when clicking with the mouse https://bugzilla.mozilla.org/attachment.cgi?id=313421&action=edit ...
superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...
superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...
superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sel
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ------- Addition...
superreview granted: [Bug 199959] Attribute.specified isn't true when attribute set through Attribute.value='string' : [Attachment 320744] possible patch
Boris Zbarsky (very little time until July 7) <bzbarsky@mit.edu> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 199959: Attribute.specified isn't true when attribute set through Attribute.value='string' https://bugzilla.mozilla.org/show_bug.cgi?id=199959 Attachment 320744: possible patch https://bugzilla.mozilla.org/attachment.cgi?id=320744&action=edit ------- Additional Comments from Boris Zbarsky (very little time until July 7) <bzbarsky@mit.edu> Meh. ...
superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...
superreview granted: [Bug 300642] Fastback regression: screen readers can't load pages : [Attachment 189358] 1) Use active window for root accessible that we return, 2) don't cache accessible root si
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 300642: Fastback regression: screen readers can't load pages https://bugzilla.mozilla.org/show_bug.cgi?id=300642 Attachment 189358: 1) Use active window for root accessible that we return, 2) don't cache accessible root since we already cache it elsewhere https://bugzilla.mozilla.org/attachment.cgi?id=189358&action=edit ...
superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the s
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ...
superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...
superreview requested: [Bug 199959] Attribute.specified isn't true when attribute set through Attribute.value='string' : [Attachment 320744] possible patch
Smaug <Olli.Pettay@gmail.com> has asked for superreview: Bug 199959: Attribute.specified isn't true when attribute set through Attribute.value='string' https://bugzilla.mozilla.org/show_bug.cgi?id=199959 Attachment 320744: possible patch https://bugzilla.mozilla.org/attachment.cgi?id=320744&action=edit ------- Additional Comments from Smaug <Olli.Pettay@gmail.com> You could have sr'd too ;) Thanks. ...
superreview granted: [Bug 252984] Cannot type in any of the fields
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 252984: Cannot type in any of the fields - forms don't get focus on left-click http://bugzilla.mozilla.org/show_bug.cgi?id=252984 Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor() or nsGenericHTMLElement::HandleDOMEvent() anymore http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> If things still work right and someone who...
superreview granted: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set.
Jonas Sicking <bugmail@sicking.cc> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 351601: Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. https://bugzilla.mozilla.org/show_bug.cgi?id=351601 Attachment 237006: Don't throw if NS_BUILD_ID is not set. https://bugzilla.mozilla.org/attachment.cgi?id=237006&action=edit ...
superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + if (aState =3D=3D mIMEData->mEnabled) {=0D mIMEData->mEnabled =3D aState;=0D =0D...
Neil Deakin <enndeakin@gmail.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 390178: Can't focus elements within panel popup with the mouse if noautohide attribute is set to true https://bugzilla.mozilla.org/show_bug.cgi?id=390178 Attachment 313421: This seems to work. Don't activate anything when clicking with the mouse https://bugzilla.mozilla.org/attachment.cgi?id=313421&action=edit ...
superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...
superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...
superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sel
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ------- Addition...
superreview granted: [Bug 199959] Attribute.specified isn't true when attribute set through Attribute.value='string' : [Attachment 320744] possible patch
Boris Zbarsky (very little time until July 7) <bzbarsky@mit.edu> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 199959: Attribute.specified isn't true when attribute set through Attribute.value='string' https://bugzilla.mozilla.org/show_bug.cgi?id=199959 Attachment 320744: possible patch https://bugzilla.mozilla.org/attachment.cgi?id=320744&action=edit ------- Additional Comments from Boris Zbarsky (very little time until July 7) <bzbarsky@mit.edu> Meh. ...
superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...
superreview granted: [Bug 300642] Fastback regression: screen readers can't load pages : [Attachment 189358] 1) Use active window for root accessible that we return, 2) don't cache accessible root si
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 300642: Fastback regression: screen readers can't load pages https://bugzilla.mozilla.org/show_bug.cgi?id=300642 Attachment 189358: 1) Use active window for root accessible that we return, 2) don't cache accessible root since we already cache it elsewhere https://bugzilla.mozilla.org/attachment.cgi?id=189358&action=edit ...
superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the s
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ...
superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...
superreview requested: [Bug 199959] Attribute.specified isn't true when attribute set through Attribute.value='string' : [Attachment 320744] possible patch
Smaug <Olli.Pettay@gmail.com> has asked for superreview: Bug 199959: Attribute.specified isn't true when attribute set through Attribute.value='string' https://bugzilla.mozilla.org/show_bug.cgi?id=199959 Attachment 320744: possible patch https://bugzilla.mozilla.org/attachment.cgi?id=320744&action=edit ------- Additional Comments from Smaug <Olli.Pettay@gmail.com> You could have sr'd too ;) Thanks. ...
superreview granted: [Bug 252984] Cannot type in any of the fields
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 252984: Cannot type in any of the fields - forms don't get focus on left-click http://bugzilla.mozilla.org/show_bug.cgi?id=252984 Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor() or nsGenericHTMLElement::HandleDOMEvent() anymore http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> If things still work right and someone who...
superreview granted: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set.
Jonas Sicking <bugmail@sicking.cc> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 351601: Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. https://bugzilla.mozilla.org/show_bug.cgi?id=351601 Attachment 237006: Don't throw if NS_BUILD_ID is not set. https://bugzilla.mozilla.org/attachment.cgi?id=237006&action=edit ...
superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + if (aState =3D=3D mIMEData->mEnabled) {=0D mIMEData->mEnabled =3D aState;=0D =0D...
Web resources about - superreview granted: [Bug 390178] Can't focus elements within panel popup with the mouse if noautohide attribute is set to true : [Attachment 313421] This seems to work. Don't activate anything when c - mozilla.dev.super-reviewResources last updated: 12/29/2015 1:27:49 PM