superreview granted: [Bug 382199] "ASSERTION: Disagreement about whether it 's a block or not" with table-as-root, float, absolute

David Baron [:dbaron] <dbaron@mozilla.com> has granted	superreview:
Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with
table-as-root, float, absolute
https://bugzilla.mozilla.org/show_bug.cgi?id=3D382199

Attachment 270366: Just the assert
https://bugzilla.mozilla.org/attachment.cgi?id=3D270366&action=3Dedit

------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com>
r+sr=3Ddbaron.  Sorry for the delay.=
0
bugzilla
7/23/2007 6:31:06 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
501 Views

Similar Articles

[PageSpeed] 1

Reply:

Similar Artilces:

superreview requested: [Bug 382199] "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute
Boris Zbarsky (reviews very slow until at least mid-July) <bzbarsky@mit.edu> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute https://bugzilla.mozilla.org/show_bug.cgi?id=382199 Attachment 267931: Sounds good https://bugzilla.mozilla.org/attachment.cgi?id=267931&action=edit ...

superreview canceled: [Bug 382199] "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute
Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu> has canceled Boris Zbarsky (not available till July 4) <bzbarsky@mit.edu>'s request for superreview: Bug 382199: "ASSERTION: Disagreement about whether it's a block or not" with table-as-root, float, absolute https://bugzilla.mozilla.org/show_bug.cgi?id=382199 Attachment 267931: Sounds good https://bugzilla.mozilla.org/attachment.cgi?id=267931&action=edit ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock wh...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Fixes the assertion independen...

superreview granted: [Bug 380096] [FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 380096: [FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float https://bugzilla.mozilla.org/show_bug.cgi?id=380096 Attachment 264216: Nothing like touching up the paint on a sinking ship https://bugzilla.mozilla.org/attachment.cgi?id=264216&action=edit ...

superreview granted: [Bug 385118] "ASSERTION: LoadObject was reentered?" after trying to "call" a flash object while it's out of the document
Johnny Stenback <jst@mozilla.org> has granted Christian Biesinger (:bi) (CA) (Mozilla Corp.) <cbiesinger@gmx.at>'s request for superreview: Bug 385118: "ASSERTION: LoadObject was reentered?" after trying to "call" a flash object while it's out of the document https://bugzilla.mozilla.org/show_bug.cgi?id=385118 Attachment 272886: oops https://bugzilla.mozilla.org/attachment.cgi?id=272886&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst (bz, feel free to still look at this if you want to). I gues...

superreview granted: [Bug 388374] [FIX]"ASSERTION: How did our kid' s height change if nothing was dirty?" with tables, padding, <select>
David Baron [:dbaron] <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 388374: [FIX]"ASSERTION: How did our kid's height change if nothing was dirty?" with tables, padding, <select> https://bugzilla.mozilla.org/show_bug.cgi?id=388374 Attachment 273034: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=273034&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=dbaron. (Seems like checking ShouldReflowAllKids() rather than just mHResize mi...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> only xul/js change was typo fix right? ...

superreview granted: [Bug 366791] "ASSERTION: non-root frame's desired size changed during an incremental reflow" when manipulating the contents of a scrollbar : [Attachment 332032] patch
Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 366791: "ASSERTION: non-root frame's desired size changed during an incremental reflow" when manipulating the contents of a scrollbar https://bugzilla.mozilla.org/show_bug.cgi?id=366791 Attachment 332032: patch https://bugzilla.mozilla.org/attachment.cgi?id=332032&action=edit ------- Additional Comments from Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> Please keep an eye out for performance issues! ...

superreview granted: [Bug 307616] <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" : [Attachment 207080] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 307616: <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" https://bugzilla.mozilla.org/show_bug.cgi?id=307616 Attachment 207080: patch https://bugzilla.mozilla.org/attachment.cgi?id=207080&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Yep...

superreview granted: [Bug 217034] Restore capability: "Label"/"Tag" as filter criterion : [Attachment 324731] Fixed David and Neil's nits, disabled some online mail table entries
David Bienvenu <bienvenu@nventure.com> has granted Kent James (:rkent) <kent@caspia.com>'s request for superreview: Bug 217034: Restore capability: "Label"/"Tag" as filter criterion https://bugzilla.mozilla.org/show_bug.cgi?id=217034 Attachment 324731: Fixed David and Neil's nits, disabled some online mail table entries https://bugzilla.mozilla.org/attachment.cgi?id=324731&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx, Kent. ...

Web resources about - superreview granted: [Bug 382199] "ASSERTION: Disagreement about whether it 's a block or not" with table-as-root, float, absolute - mozilla.dev.super-review

Resources last updated: 1/11/2016 11:38:00 AM