superreview requested: [Bug 348712] RTL Caret for GTK2 on 1.8 Branch : [Attachment 233766] Patch for 1.8 branch, addressed smontagu's review comment
Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 348712: RTL Caret for GTK2 on 1.8 Branch https://bugzilla.mozilla.org/show_bug.cgi?id=348712 Attachment 233766: Patch for 1.8 branch, addressed smontagu's review comment https://bugzilla.mozilla.org/attachment.cgi?id=233766&action=edit ------- Additional Comments from Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org> transferring smontagu's r+ ...

superreview requested: [Bug 348712] RTL Caret for GTK2 on 1.8 Branch : [Attachment 233761] Patch for 1.8 branch
Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 348712: RTL Caret for GTK2 on 1.8 Branch https://bugzilla.mozilla.org/show_bug.cgi?id=348712 Attachment 233761: Patch for 1.8 branch https://bugzilla.mozilla.org/attachment.cgi?id=233761&action=edit ...

superreview cancelled: [Bug 348712] RTL Caret for GTK2 on 1.8 Branch : [Attachment 233761] Patch for 1.8 branch
Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org> has cancelled Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org>'s request for superreview: Bug 348712: RTL Caret for GTK2 on 1.8 Branch https://bugzilla.mozilla.org/show_bug.cgi?id=348712 Attachment 233761: Patch for 1.8 branch https://bugzilla.mozilla.org/attachment.cgi?id=233761&action=edit ------- Additional Comments from Behnam "ZWNJ" Esfahbod (FarsiWeb) <behnam@zwnj.org> transferring smontagu's r+ ...

superreview granted: [Bug 362139] bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch : [Attachment 246922] 1.8 patch: SeaMonkey version -> 1.1, localeVers
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 362139: bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=362139 Attachment 246922: 1.8 patch: SeaMonkey version -> 1.1, localeVersion -> 1.8.1 https://bugzilla.mozilla.org/attachment.cgi?id=246922&action=edit ...

superreview granted: [Bug 362139] bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch : [Attachment 246921] 1.8.0 patch: SeaMonkey version -> 1.0.7
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 362139: bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=362139 Attachment 246921: 1.8.0 patch: SeaMonkey version -> 1.0.7 https://bugzilla.mozilla.org/attachment.cgi?id=246921&action=edit ...

superreview requested: [Bug 362139] bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch : [Attachment 246922] 1.8 patch: SeaMonkey version -> 1.1, localeVe
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 362139: bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=362139 Attachment 246922: 1.8 patch: SeaMonkey version -> 1.1, localeVersion -> 1.8.1 https://bugzilla.mozilla.org/attachment.cgi?id=246922&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> ...and here's the 1.8 branch patch, setting SeaMonkey version to 1.1 for final, and locale...

superreview requested: [Bug 362139] bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch : [Attachment 246921] 1.8.0 patch: SeaMonkey version -> 1.0.7
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 362139: bump SeaMonkey versions to 1.0.7/1.1 on 1.8.0/1.8 branches, localeVersion to 1.8.1 on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=362139 Attachment 246921: 1.8.0 patch: SeaMonkey version -> 1.0.7 https://bugzilla.mozilla.org/attachment.cgi?id=246921&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the 1.8.0 branch patch for bumping SeaMonkey version to 1.0.7 ...

superreview granted: [Bug 350787] 1.8 branch startup crashes [@ js_Interpret], line 5506 : [Attachment 236883] 1.8 branch patch to commit
Brendan Eich <brendan@mozilla.org> has granted superreview: Bug 350787: 1.8 branch startup crashes [@ js_Interpret], line 5506 https://bugzilla.mozilla.org/show_bug.cgi?id=350787 Attachment 236883: 1.8 branch patch to commit https://bugzilla.mozilla.org/attachment.cgi?id=236883&action=edit ...

superreview granted: [Bug 240261] [1.8 branch] peer-trusted certs can use alt names to spoof : [Attachment 317786] Patch v1 [for 1.8 branch]
Robert Relyea <rrelyea@redhat.com> has granted Kai Engert (:kaie) <kengert@redhat.com>'s request for superreview: Bug 240261: [1.8 branch] peer-trusted certs can use alt names to spoof https://bugzilla.mozilla.org/show_bug.cgi?id=240261 Attachment 317786: Patch v1 [for 1.8 branch] https://bugzilla.mozilla.org/attachment.cgi?id=317786&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> did not review the details of the 'GetSubjectAltNames' function except to verify semantic assumptions fo the code that called it. ...

superreview granted: [Bug 336225] support unicode file name on drag and drop(D&D) on 1.8 branch : [Attachment 220521] 1.8 branch patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Masatoshi Kimura (:emk) <VYV03354@nifty.ne.jp>'s request for superreview: Bug 336225: support unicode file name on drag and drop(D&D) on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=336225 Attachment 220521: 1.8 branch patch https://bugzilla.mozilla.org/attachment.cgi?id=220521&action=edit ...

superreview granted: [Bug 350787] 1.8 branch startup crashes [@ js_Interpret], line 5506 : [Attachment 236879] 1.8 branch version of fix
Brendan Eich <brendan@mozilla.org> has granted superreview: Bug 350787: 1.8 branch startup crashes [@ js_Interpret], line 5506 https://bugzilla.mozilla.org/show_bug.cgi?id=350787 Attachment 236879: 1.8 branch version of fix https://bugzilla.mozilla.org/attachment.cgi?id=236879&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> This is a hazard for anyone upgrading from betas or nightlies, never mind switching between Minefield and Bone-cho. /be ...

superreview requested: [Bug 336225] support unicode file name on drag and drop(D&D) on 1.8 branch : [Attachment 220521] 1.8 branch patch
Masatoshi Kimura (:emk) <VYV03354@nifty.ne.jp> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 336225: support unicode file name on drag and drop(D&D) on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=336225 Attachment 220521: 1.8 branch patch https://bugzilla.mozilla.org/attachment.cgi?id=220521&action=edit ------- Additional Comments from Masatoshi Kimura (:emk) <VYV03354@nifty.ne.jp> I confirmed this could handle non-system codepage chars on WinXP and this could handle system codepage chars on Win98 (On Win95, ...

superreview requested: [Bug 240261] [1.8 branch] peer-trusted certs can use alt names to spoof : [Attachment 317786] Patch v1 [for 1.8 branch]
Kai Engert (:kaie) <kengert@redhat.com> has asked for superreview: Bug 240261: [1.8 branch] peer-trusted certs can use alt names to spoof https://bugzilla.mozilla.org/show_bug.cgi?id=240261 Attachment 317786: Patch v1 [for 1.8 branch] https://bugzilla.mozilla.org/attachment.cgi?id=317786&action=edit ------- Additional Comments from Kai Engert (:kaie) <kengert@redhat.com> I think it would be good if Bob could r+ this bug. I have already talked to him shortly, he agrees with the plan. Since function GetSubjectAltNames in this patch is being copied from the trun...

superreview granted: [Bug 350255] bump SeaMonkey version to 1.1b on 1.8 branch : [Attachment 235503] usual patch for 1.1a->1.1b
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 350255: bump SeaMonkey version to 1.1b on 1.8 branch https://bugzilla.mozilla.org/show_bug.cgi?id=350255 Attachment 235503: usual patch for 1.1a->1.1b https://bugzilla.mozilla.org/attachment.cgi?id=235503&action=edit ...