superreview granted: [Bug 348455] [FIX]Review comments in bug 285727 never got addressed : [Attachment 233863] Patch

David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 348455: [FIX]Review comments in bug 285727 never got addressed
https://bugzilla.mozilla.org/show_bug.cgi?id=348455

Attachment 233863: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit
0
bugzilla
8/15/2006 11:30:55 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
658 Views

Similar Articles

[PageSpeed] 42
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 348455] Review comments in bug 285727 never got addressed : [Attachment 233863] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 348455: Review comments in bug 285727 never got addressed https://bugzilla.mozilla.org/show_bug.cgi?id=348455 Attachment 233863: Patch https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> bernd is out of town ...

superreview granted: [Bug 259084] review comments on bug 173010 (protocol whitelist) : [Attachment 160789] patch
Darin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 259084: review comments on bug 173010 (protocol whitelist) https://bugzilla.mozilla.org/show_bug.cgi?id=259084 Attachment 160789: patch https://bugzilla.mozilla.org/attachment.cgi?id=160789&action=edit ...

superreview canceled: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313859] address review comments
Robert Longson <longsonr@gmail.com> has canceled Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 423998: Fix repainting regression(s) and multiple invalidation bugs https://bugzilla.mozilla.org/show_bug.cgi?id=423998 Attachment 313859: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=313859&action=edit ...

superreview requested: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313859] address review comments
Robert Longson <longsonr@gmail.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 423998: Fix repainting regression(s) and multiple invalidation bugs https://bugzilla.mozilla.org/show_bug.cgi?id=423998 Attachment 313859: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=313859&action=edit ------- Additional Comments from Robert Longson <longsonr@gmail.com> (In reply to comment #17) > nsSVGUtils.cpp: The DoUpdate changes are not necessary. Please revert them for ...

superreview granted: [Bug 176637] Custom link colors not rendered correctly : [Attachment 139312] patch with review comments addressed
Boris Zbarsky <bz-vacation@mit.edu> has granted Andreas Kunz <durbacher@gmx.de>'s request for superreview: Bug 176637: Custom link colors not rendered correctly http://bugzilla.mozilla.org/show_bug.cgi?id=176637 Attachment 139312: patch with review comments addressed http://bugzilla.mozilla.org/attachment.cgi?id=139312&action=edit ------- Additional Comments from Boris Zbarsky <bz-vacation@mit.edu> sr=me. I assume you need this checked in too? ...

superreview granted: [Bug 357630] [FIX]Have a way to insert identical elements into an nsTArray : [Attachment 244382] Address review comments
Darin Fisher (Google) <darin.moz@gmail.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 357630: [FIX]Have a way to insert identical elements into an nsTArray https://bugzilla.mozilla.org/show_bug.cgi?id=357630 Attachment 244382: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=244382&action=edit ...

superreview granted: [Bug 339543] microsummaries trigger bookmarked files to be downloaded : [Attachment 225855] patch v3: addresses review comments
Mike Connor <mconnor@mozilla.com> has granted superreview: Bug 339543: microsummaries trigger bookmarked files to be downloaded https://bugzilla.mozilla.org/show_bug.cgi?id=339543 Attachment 225855: patch v3: addresses review comments https://bugzilla.mozilla.org/attachment.cgi?id=225855&action=edit ...

superreview granted: [Bug 436880] IMAP itemDeleted and itemMoveCopyCompleted notifications quite broken : [Attachment 325404] test review comments addressed, IMAP fixed
David Bienvenu <bienvenu@nventure.com> has granted Siddharth Agarwal [:sid0] <sid1337@gmail.com>'s request for superreview: Bug 436880: IMAP itemDeleted and itemMoveCopyCompleted notifications quite broken https://bugzilla.mozilla.org/show_bug.cgi?id=436880 Attachment 325404: test review comments addressed, IMAP fixed https://bugzilla.mozilla.org/attachment.cgi?id=325404&action=edit ...

superreview granted: [Bug 406730] Correctly style unfocused window on OS X : [Attachment 318985] Fix v8.1: address review comments
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Markus Stange <mstange@themasta.com>'s request for superreview: Bug 406730: Correctly style unfocused window on OS X https://bugzilla.mozilla.org/show_bug.cgi?id=406730 Attachment 318985: Fix v8.1: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=318985&action=edit ...

superreview granted: [Bug 230320] New features for download manager: trash button, clean only disappeared files : [Attachment 193345] Patch addressing review comments
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@ipl.com>'s request for superreview: Bug 230320: New features for download manager: trash button, clean only disappeared files https://bugzilla.mozilla.org/show_bug.cgi?id=230320 Attachment 193345: Patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=193345&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview granted: [Bug 123315] Search plugins [engines] should be installed in the user's profile directory : [Attachment 187603] patch addressing review comments
Mike Shaver <shaver@mozilla.org> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 123315: Search plugins [engines] should be installed in the user's profile directory https://bugzilla.mozilla.org/show_bug.cgi?id=123315 Attachment 187603: patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=187603&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> >+ else if (nsCRT::strcmp(prop, NS_APP_USER_SEARCH_DIR) == 0) >+ { >+ rv = NS_GetSpecialDirectory(NS_AP...

superreview granted: [Bug 304147] progressmeter in undetermined mode does not work in Mac OS X : [Attachment 312480] Fix v3.2: address review comments
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted Markus Stange <mstange@themasta.com>'s request for superreview: Bug 304147: progressmeter in undetermined mode does not work in Mac OS X https://bugzilla.mozilla.org/show_bug.cgi?id=304147 Attachment 312480: Fix v3.2: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=312480&action=edit ...

superreview granted: [Bug 167262] style element background-image: composer makes relative links absolute : [Attachment 134185] patch addressing review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 167262: style element background-image: composer makes relative links absolute http://bugzilla.mozilla.org/show_bug.cgi?id=167262 Attachment 134185: patch addressing review comments http://bugzilla.mozilla.org/attachment.cgi?id=134185&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, that looks great. ...

superreview granted: [Bug 54488] [Mac] Non-draggable widgets in background windows should look disabled : [Attachment 319024] fix v1.3: address review comments
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Markus Stange <mstange@themasta.com>'s request for superreview: Bug 54488: [Mac] Non-draggable widgets in background windows should look disabled https://bugzilla.mozilla.org/show_bug.cgi?id=54488 Attachment 319024: fix v1.3: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=319024&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> +static BOOL frameIsInActiveWindow(nsIFrame* aFrame) I think this function is OK but should start wi...

Web resources about - superreview granted: [Bug 348455] [FIX]Review comments in bug 285727 never got addressed : [Attachment 233863] Patch - mozilla.dev.super-review

Resources last updated: 1/17/2016 4:57:22 AM