superreview granted: [Bug 346119] Code added in bug 338122 doesn't actually enforce document equality : [Attachment 231004] update prescontext's mDocument when new shell is set.

Boris Zbarsky <bzbarsky@mit.edu> has granted Smaug <Olli.Pettay@gmail.com>'s
request for superreview:
Bug 346119: Code added in bug 338122 doesn't actually enforce document equality
https://bugzilla.mozilla.org/show_bug.cgi?id=346119

Attachment 231004: update prescontext's mDocument when new shell is set.
https://bugzilla.mozilla.org/attachment.cgi?id=231004&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Looks good.
0
bugzilla
7/27/2006 10:48:21 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
567 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview requested: [Bug 346119] Code added in bug 338122 doesn't actually enforce document equality : [Attachment 231004] update prescontext's mDocument when new shell is set.
Smaug <Olli.Pettay@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 346119: Code added in bug 338122 doesn't actually enforce document equality https://bugzilla.mozilla.org/show_bug.cgi?id=346119 Attachment 231004: update prescontext's mDocument when new shell is set. https://bugzilla.mozilla.org/attachment.cgi?id=231004&action=edit ------- Additional Comments from Smaug <Olli.Pettay@gmail.com> This still ensures that nsPresContext::Document() never returns nsnull. ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 279533] Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work : [Attachment 174475] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 279533: Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=279533 Attachment 174475: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=174475&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 279533] Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work : [Attachment 174475] patc
Asaf Romano <bugs.mano@mail-central.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 279533: Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=279533 Attachment 174475: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=174475&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ...

superreview granted: [Bug 316851] Need workaround for bug 56488 in Help : [Attachment 205079] New version
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Stefan <stefan_h@hem.utfors.se>'s request for superreview: Bug 316851: Need workaround for bug 56488 in Help https://bugzilla.mozilla.org/show_bug.cgi?id=316851 Attachment 205079: New version - don't touch classic's global.css https://bugzilla.mozilla.org/attachment.cgi?id=205079&action=edit ...

superreview granted: [Bug 399587] deleting a property from an object doesn' t notify that object's XOWs : [Attachment 294864] Updated to comments
Johnny Stenback (:jst) <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 399587: deleting a property from an object doesn't notify that object's XOWs https://bugzilla.mozilla.org/show_bug.cgi?id=399587 Attachment 294864: Updated to comments https://bugzilla.mozilla.org/attachment.cgi?id=294864&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> - In nsWindowSH::DelProperty(): + // Notify any XOWs on our outer window. Would we want to do this for all XOWs? If so, we ...

superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ...

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 162166: fix review comments https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over r/sr, seeking branch approval. jst wants this for the plugin finder ...

superreview granted: [Bug 351601] Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. : [Attachment 237006] Don't throw if NS_BUILD_ID is not set.
Jonas Sicking <bugmail@sicking.cc> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 351601: Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception. https://bugzilla.mozilla.org/show_bug.cgi?id=351601 Attachment 237006: Don't throw if NS_BUILD_ID is not set. https://bugzilla.mozilla.org/attachment.cgi?id=237006&action=edit ...

Web resources about - superreview granted: [Bug 346119] Code added in bug 338122 doesn't actually enforce document equality : [Attachment 231004] update prescontext's mDocument when new shell is set. - mozilla.dev.super-review

Resources last updated: 12/14/2015 8:58:52 AM