superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242221] addi

neil@parkwaycc.co.uk <neil@httl.net> has granted Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242221: additional cleanup patch, v3
https://bugzilla.mozilla.org/attachment.cgi?id=242221&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>+   /* Treat null bytes as spaces when format_out is
>+    nsMimeOutput::nsMimeMessageBodyDisplay (see bug 243199 comment 7) */
>+   PRBool treatNullAsSpace = data->objectToDecode &&
>+                             data->objectToDecode->options->format_out ==
nsMimeOutput::nsMimeMessageBodyDisplay;
>+
>   while (length > 0 || i != 0)
Nit: incorrect indentations.
>+                   *out++ = c ? c : ((treatNullAsSpace) ? ' ' : (char) c);
Nit: suggest ? (char) c : for consistency.
0
bugzilla
10/13/2006 8:21:57 PM
📁 mozilla.dev.super-review
📃 29307 articles.
⭐ 2 followers.

💬 0 Replies
👁️‍🗨️ 490 Views


Reply:

Similar Artilces: