superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242221] adGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242221: additional cleanup patch, v3
https://bugzilla.mozilla.org/attachment.cgi?id=242221&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
As Neil pointed out, I prefer JavaScript's || operator :)
...
superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 239997] propScott MacGregor <mscott@mozilla.org> has granted Mike Cowperthwaite
<mcow@well.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 239997: proposed patch - file mailnews/mime/src/mimeenc.cpp
https://bugzilla.mozilla.org/attachment.cgi?id=239997&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
cool. Thanks for the patch, and a libmim...
superreview cancelled: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242204] adGavin Sharp <gavin.sharp@gmail.com> has cancelled Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242204: additional cleanup patch, v2
https://bugzilla.mozilla.org/attachment.cgi?id=242204&action=edit
...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 239997] prMike Cowperthwaite <mcow@well.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 239997: proposed patch - file mailnews/mime/src/mimeenc.cpp
https://bugzilla.mozilla.org/attachment.cgi?id=239997&action=edit
...
superreview cancelled: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242197] adGavin Sharp <gavin.sharp@gmail.com> has cancelled Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242197: additional cleanup patch
https://bugzilla.mozilla.org/attachment.cgi?id=242197&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
Further suggestion from Neil (this is still untested).
...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242197] paGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242197: patch
https://bugzilla.mozilla.org/attachment.cgi?id=242197&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
This is an untested patch to fix Neil's style nit, and to make the code a bit
easier to read.
...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242204] adGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242204: additional cleanup patch, v2
https://bugzilla.mozilla.org/attachment.cgi?id=242204&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
Further suggestion from Neil (this is still untested).
...
superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inline)Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 204350: (message/rfc822) Attached email message window glitches (forward,
reply, view source disabled)
https://bugzilla.mozilla.org/show_bug.cgi?id=204350
Attachment 200351: support reply/forward (as attachment and inline) for
message/rfc822 attachments
https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
+ rv = NS_NewURI(getter_AddRefs(uri), messageURI...
superreview granted: [Bug 250291] html messages: forward as inline not quoting headers or inserting "original message" header : [Attachment 152960] Proposed patchDavid Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 250291: html messages: forward as inline not quoting headers or inserting
"original message" header
http://bugzilla.mozilla.org/show_bug.cgi?id=250291
Attachment 152960: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152960&action=edit
...
superreview requested: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inlinDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 204350: (message/rfc822) Attached email message window glitches (forward,
reply, view source disabled)
https://bugzilla.mozilla.org/show_bug.cgi?id=204350
Attachment 200351: support reply/forward (as attachment and inline) for
message/rfc822 attachments
https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
with this patch, thunderbird supports reply + forward as attachme...
superreview granted: [Bug 37712] "Receiving: message headers" should be "Downloading message headers 123 of 1323" : [Attachment 176781] patch for thunderbirdScott MacGregor <mscott@mozilla.org> has granted Tim Meader
<tmeader@gmail.com>'s request for superreview:
Bug 37712: "Receiving: message headers" should be "Downloading message headers
123 of 1323"
https://bugzilla.mozilla.org/show_bug.cgi?id=37712
Attachment 176781: patch for thunderbird
https://bugzilla.mozilla.org/attachment.cgi?id=176781&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
I changed my mind. I'm ok with this now.
...
superreview requested: [Bug 250291] html messages: forward as inline not quoting headers or inserting "original message" header : [Attachment 152960] Proposed patchneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David
Bienvenu <bienvenu@nventure.com> for superreview:
Bug 250291: html messages: forward as inline not quoting headers or inserting
"original message" header
http://bugzilla.mozilla.org/show_bug.cgi?id=250291
Attachment 152960: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152960&action=edit
...
superreview granted: [Bug 409962] Cannot view attached mail with Content-type "Message/Rfc822" correctly : [ Attachment 294839] proposed fixDavid Bienvenu <bienvenu@nventure.com> has granted Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 409962: Cannot view attached mail with Content-type "Message/Rfc822"
correctly
https://bugzilla.mozilla.org/show_bug.cgi?id=409962
Attachment 294839: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=294839&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
thx Magnus.
+ // to avoid some hazzle later down the road.
I think you mean hassle
I'm not sure I understand the pa...
superreview granted: [Bug 83396] Alert "message contains bare newlines" displays and lost messages when copying msgs from Local(or other IMAP account)folder to an IMAP account folder : [Attachment 20Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 83396: Alert "message contains bare newlines" displays and lost messages
when copying msgs from Local(or other IMAP account)folder to an IMAP account
folder
https://bugzilla.mozilla.org/show_bug.cgi?id=83396
Attachment 209013: fix for eudora and outlook import causing these messages
https://bugzilla.mozilla.org/attachment.cgi?id=209013&action=edit
...