superreview granted: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way

Mike Connor <mconnor@mozilla.com> has granted Seth Spitzer [:ss]
<sspitzer@mozilla.com>'s request for superreview:
Bug 342105: Close button not shown if there is only one tab
https://bugzilla.mozilla.org/show_bug.cgi?id=342105

Attachment 229158: don't treat a single tab in a special way
https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit

------- Additional Comments from Mike Connor <mconnor@mozilla.com>
So, I don't know what error either, and this might be a legacy piece from where
I relocated a bunch of that code, but without knowing for sure, let's leave it
in on branch (Simon, can you file a followup on this, with the goal of removing
the try/catch)
0
bugzilla
7/22/2006 2:03:45 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
551 Views

Similar Articles

[PageSpeed] 45
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> r=sspitzer, seeking sr= from mconnor. ...

superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...

superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rec
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the re...

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview granted: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't.
Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview granted: [Bug 430552] Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element : [Attachment 318254] More com
Blake Kaplan <mrbkap@gmail.com> has granted ben turner [:bent] <bent.mozilla@gmail.com>'s request for superreview: Bug 430552: Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element https://bugzilla.mozilla.org/show_bug.cgi?id=430552 Attachment 318254: More complete fix https://bugzilla.mozilla.org/attachment.cgi?id=318254&action=edit ...

superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't.
Aaron Leventhal <aaronleventhal@moonset.net> has asked for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't. #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview granted: [Bug 120148] Tabs don't remember which element [frame, textfield, etc] was focused when switching tabs : [Attachment 132485] Remember where focus is when switching tabs (updated
Brian Ryner <bryner@brianryner.com> has granted hn <tryandguessit@yahoo.com>'s request for superreview: Bug 120148: Tabs don't remember which element [frame, textfield, etc] was focused when switching tabs http://bugzilla.mozilla.org/show_bug.cgi?id=120148 Attachment 132485: Remember where focus is when switching tabs (updated) http://bugzilla.mozilla.org/attachment.cgi?id=132485&action=edit ...

Web resources about - superreview granted: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way - mozilla.dev.super-review


Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/6/2015 6:01:27 PM