superreview granted: [Bug 338741] "Select Element by Click" doesn't work for elements in content documents of inspected chrome : [Attachment 222807] Proposed patch

Boris Zbarsky <bzbarsky@mit.edu> has granted neil@parkwaycc.co.uk
<neil@httl.net>'s request for superreview:
Bug 338741: "Select Element by Click" doesn't work for elements in content
documents of inspected chrome
https://bugzilla.mozilla.org/show_bug.cgi?id=338741

Attachment 222807: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=222807&action=edit
0
bugzilla
5/31/2006 4:03:37 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
522 Views

Similar Articles

[PageSpeed] 31
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 338741] "Select Element by Click" doesn't work for elements in content documents of inspected chrome : [Attachment 222807] Proposed patch
neil@parkwaycc.co.uk <neil@httl.net> has asked Boris Zbarsky (gone May 17 -- May 29) <bzbarsky@mit.edu> for superreview: Bug 338741: "Select Element by Click" doesn't work for elements in content documents of inspected chrome https://bugzilla.mozilla.org/show_bug.cgi?id=338741 Attachment 222807: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=222807&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> It turns out this file already includes nsPIDOMWindow.h so I could have patched it years ago, or if you...

superreview granted: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 236541: "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used https://bugzilla.mozilla.org/show_bug.cgi?id=236541 Attachment 208411: Patch for the core code per comment 38. https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit ...

superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this needs a toolkit module owner review so I'll ask Benjamin for that. David's on vacation, i'll do the sr. ...

superreview granted: [Bug 320623] overflow="visible" doesn't work on <marker> : [Attachment 207505] merge overflow into style system for elements which support it
Johnny Stenback <jst@mozilla.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 320623: overflow="visible" doesn't work on <marker> https://bugzilla.mozilla.org/show_bug.cgi?id=320623 Attachment 207505: merge overflow into style system for elements which support it https://bugzilla.mozilla.org/attachment.cgi?id=207505&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview granted: [Bug 240892] [FIX]select element by click doesn't work for content in an iframe nested in a frame : [Attachment 146440] Fix
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 240892: [FIX]select element by click doesn't work for content in an iframe nested in a frame http://bugzilla.mozilla.org/show_bug.cgi?id=240892 Attachment 146440: Fix http://bugzilla.mozilla.org/attachment.cgi?id=146440&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> What timeless said. ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@mindspring.com>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ...

superreview granted: [Bug 297801] [FIX]Replacing the document element via replaceChild() doesn't show new content : [Attachment 208100] Proposed patch
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 297801: [FIX]Replacing the document element via replaceChild() doesn't show new content https://bugzilla.mozilla.org/show_bug.cgi?id=297801 Attachment 208100: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=208100&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> + mNotifiedRootInsertion = PR_TRUE; + PRInt32 index = mDocument->IndexOf(mRoot); + NS_ASSERTION(index != -1, "mRoot not ch...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 236541: "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used https://bugzilla.mozilla.org/show_bug.cgi?id=236541 Attachment 208411: Patch for the core code per comment 38. https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit ...

superreview granted: [Bug 239535] [Mac] nsDateTimeFormatMac is broken in Japanese locale (Page Info fails to load / Media Tab doesn't work / Cookie Manager doesn't show "Expires") : [Attachment 15469
Robert O'Callahan <roc@ocallahan.org> has granted Constantine A. Murenin <cnst+bmo@bugmail.mojo.ru>'s request for superreview: Bug 239535: [Mac] nsDateTimeFormatMac is broken in Japanese locale (Page Info fails to load / Media Tab doesn't work / Cookie Manager doesn't show "Expires") http://bugzilla.mozilla.org/show_bug.cgi?id=239535 Attachment 154694: patch http://bugzilla.mozilla.org/attachment.cgi?id=154694&action=edit ...

superreview granted: [Bug 430878] Print-selection doesn't print lower "overflow:scroll" divs unless their upper mirror-image is selected. : [Attachment 318251] patch v1: call PositionChildViews after
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Daniel Holbert [:dholbert] <dholbert@mozilla.com>'s request for superreview: Bug 430878: Print-selection doesn't print lower "overflow:scroll" divs unless their upper mirror-image is selected. https://bugzilla.mozilla.org/show_bug.cgi?id=430878 Attachment 318251: patch v1: call PositionChildViews after shifting page content frame https://bugzilla.mozilla.org/attachment.cgi?id=318251&action=edit ...

superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sel
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ------- Addition...

superreview granted: [Bug 194147] Selecting "Mark As" causes Quick Search not to work on "m" and "r" : [Attachment 201172] Don't display single commandkeys in mac menuitems
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 194147: Selecting "Mark As" causes Quick Search not to work on "m" and "r" https://bugzilla.mozilla.org/show_bug.cgi?id=194147 Attachment 201172: Don't display single commandkeys in mac menuitems https://bugzilla.mozilla.org/attachment.cgi?id=201172&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh, I was...

superreview granted: [Bug 250198] "find as you type" doesn't work : [Attachment 152618] patch
T Rowley (IBM) <tor@acm.org> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 250198: "find as you type" doesn't work http://bugzilla.mozilla.org/show_bug.cgi?id=250198 Attachment 152618: patch http://bugzilla.mozilla.org/attachment.cgi?id=152618&action=edit ...

Web resources about - superreview granted: [Bug 338741] "Select Element by Click" doesn't work for elements in content documents of inspected chrome : [Attachment 222807] Proposed patch - mozilla.dev.super-review

Resources last updated: 1/3/2016 9:10:22 PM