superreview requested: [Bug 334189] nsSHistory::PrintHistory should use a string class : [Attachment 218648] reindent file and use string class
timeless <timeless@bemail.org> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 334189: nsSHistory::PrintHistory should use a string class https://bugzilla.mozilla.org/show_bug.cgi?id=334189 Attachment 218648: reindent file and use string class https://bugzilla.mozilla.org/attachment.cgi?id=218648&action=edit ...

superreview granted: [Bug 131867] Our use of setlocale() is not threadsafe : [Attachment 141891] Use a Private string class for floating point numbers
tor@acm.org has granted Kenneth Herron (kherron) <kjh-5727@comcast.net>'s request for superreview: Bug 131867: Our use of setlocale() is not threadsafe http://bugzilla.mozilla.org/show_bug.cgi?id=131867 Attachment 141891: Use a Private string class for floating point numbers http://bugzilla.mozilla.org/attachment.cgi?id=141891&action=edit ...

superreview granted: [Bug 232503] Start using Empty[C]String() : [Attachment 140140] Use Empty[C]String()
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 232503: Start using Empty[C]String() http://bugzilla.mozilla.org/show_bug.cgi?id=232503 Attachment 140140: Use Empty[C]String() http://bugzilla.mozilla.org/attachment.cgi?id=140140&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> > Index: editor/libeditor/html/Makefile.in > =================================================================== > @@ -58,19 +58,18 @@ CPPSRCS =...

superreview requested: [Bug 131867] Our use of setlocale() is not threadsafe : [Attachment 141891] Use a Private string class for floating point numbers
Kenneth Herron (kherron) <kjh-5727@comcast.net> has asked Darin Fisher <darin@meer.net> for superreview: Bug 131867: Our use of setlocale() is not threadsafe http://bugzilla.mozilla.org/show_bug.cgi?id=131867 Attachment 141891: Use a Private string class for floating point numbers http://bugzilla.mozilla.org/attachment.cgi?id=141891&action=edit ------- Additional Comments from Kenneth Herron (kherron) <kjh-5727@comcast.net> Darin, could you sr this? This patch involves a private subclass of nsAutoCString. Regarding the %3.2f question, AppendFloat() always ...

superreview requested: [Bug 131867] Our use of setlocale() is not threadsafe : [Attachment 141891] Use a Private string class for floating point numbers #2
Kenneth Herron (kherron) <kjh-5727@comcast.net> has asked tor@acm.org for superreview: Bug 131867: Our use of setlocale() is not threadsafe http://bugzilla.mozilla.org/show_bug.cgi?id=131867 Attachment 141891: Use a Private string class for floating point numbers http://bugzilla.mozilla.org/attachment.cgi?id=141891&action=edit ------- Additional Comments from Kenneth Herron (kherron) <kjh-5727@comcast.net> Okay, tor, could you sr this? ...

superreview requested: [Bug 232503] Start using Empty[C]String() : [Attachment 140140] Use Empty[C]String()
Johnny Stenback <jst@mozilla.jstenback.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 232503: Start using Empty[C]String() http://bugzilla.mozilla.org/show_bug.cgi?id=232503 Attachment 140140: Use Empty[C]String() http://bugzilla.mozilla.org/attachment.cgi?id=140140&action=edit ...

superreview granted: [Bug 343941] Audit Localizable.strings (and other .strings files) for typos/style guide and clarity : [Attachment 244148] New Strings files
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted superreview: Bug 343941: Audit Localizable.strings (and other .strings files) for typos/style guide and clarity https://bugzilla.mozilla.org/show_bug.cgi?id=343941 Attachment 244148: New Strings files https://bugzilla.mozilla.org/attachment.cgi?id=244148&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> sr=me ...

superreview granted: [Bug 220093] inCSSValueSearch incorrectly uses strings : [Attachment 132002] use nsString instead
Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 220093: inCSSValueSearch incorrectly uses strings http://bugzilla.mozilla.org/show_bug.cgi?id=220093 Attachment 132002: use nsString instead http://bugzilla.mozilla.org/attachment.cgi?id=132002&action=edit ------- Additional Comments from Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 298807] nsIBookmarksService::ResolveKeyword can make a better use of strings : [Attachment 188012] patch (use AString)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 298807: nsIBookmarksService::ResolveKeyword can make a better use of strings https://bugzilla.mozilla.org/show_bug.cgi?id=298807 Attachment 188012: patch (use AString) https://bugzilla.mozilla.org/attachment.cgi?id=188012&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >- nsDependentString postDataStr(postDataVal); >- *aPostData = ToNewUnicode(post...

superreview granted: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 250828: When i use global inbox, thunderbird does not use localized string "Inbox". https://bugzilla.mozilla.org/show_bug.cgi?id=250828 Attachment 160458: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=160458&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I like this - I'd fix the comment // "none" doesn't have an inbox - maybe just remove it... ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview granted: [Bug 241993] Use window class name corresponding to UI/content/general : [Attachment 147264] Implements the new window classes without changing any behavior
Robert O'Callahan <roc@ocallahan.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 241993: Use window class name corresponding to UI/content/general http://bugzilla.mozilla.org/show_bug.cgi?id=241993 Attachment 147264: Implements the new window classes without changing any behavior http://bugzilla.mozilla.org/attachment.cgi?id=147264&action=edit ...

superreview granted: [Bug 242990] Crash when LDAP query results content none UTF8 characters : [Attachment 147958] If the result strings IsUTF8 use UTF8ToNewUnicode, otherwise use general ToNewUnicod
Dan Mosedale <dmose@mozilla.org> has granted wind li <wind.li@sun.com>'s request for superreview: Bug 242990: Crash when LDAP query results content none UTF8 characters http://bugzilla.mozilla.org/show_bug.cgi?id=242990 Attachment 147958: If the result strings IsUTF8 use UTF8ToNewUnicode, otherwise use general ToNewUnicode http://bugzilla.mozilla.org/attachment.cgi?id=147958&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> r+sr=dmose ...