superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6 - First stab at sorting out inclusion of modules in xpfe

neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner
<bugzilla@standard8.demon.co.uk>'s request for superreview:
Bug 330053: Make SeaMonkey capable of generating a reasonable build with
MOZ_XUL_APP set.
https://bugzilla.mozilla.org/show_bug.cgi?id=330053

Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules
in xpfe and toolkit
https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>+ifndef MOZ_SUITE
>+# XXX Suite doesn't want these just yet
> ifdef MOZ_XUL
> DIRS += \
>	autocomplete \
Please ensure suiterunner filepicker autocomplete works before checking in.
0
bugzilla
4/13/2006 3:29:27 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
459 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the pathc to get suiterunner to build on Mac. Some of this is just correcting the Makefile to things we already do in xpfe/bootstrap (the Info.pli...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNativeAppSupport...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has cancelled Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNa...

superreview granted: [Bug 78672] [console] xpfe must not print to console in opt builds : [Attachment 149449] (Av2-SM) <xpfe/*/*.cpp> (SeaMonkey part)
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 78672: [console] xpfe must not print to console in opt builds http://bugzilla.mozilla.org/show_bug.cgi?id=78672 Attachment 149449: (Av2-SM) <xpfe/*/*.cpp> (SeaMonkey part) http://bugzilla.mozilla.org/attachment.cgi?id=149449&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> I can't believe I'm going to do this, but sr=alecf This must be compiled before it gets checked in though. (frankly, I wish we would get ...

superreview granted: [Bug 255834] port Thunderbird RSS/Atom reader to SeaMonkey : [Attachment 234266] Part 1 for trunk
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has granted Ian Neal <iann_bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 255834: port Thunderbird RSS/Atom reader to SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=255834 Attachment 234266: Part 1 for trunk - Start building of feed service as mini module v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=234266&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> Because seamonkey is built non-static, you will need to ...

superreview requested: [Bug 78672] [console] xpfe must not print to console in opt builds : [Attachment 149449] (Av2-SM) <xpfe/*/*.cpp> (SeaMonkey part)
Serge GAUTHERIE <gautheri@noos.fr> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 78672: [console] xpfe must not print to console in opt builds http://bugzilla.mozilla.org/show_bug.cgi?id=78672 Attachment 149449: (Av2-SM) <xpfe/*/*.cpp> (SeaMonkey part) http://bugzilla.mozilla.org/attachment.cgi?id=149449&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> I have no compiler: Could you compile/test/(super-)review/check in this patch ? Thanks. ...

superreview granted: [Bug 136773] Investigate enabling ldap:5 logging on optimized builds. : [Attachment 207740] Allow logging ldap:5 on optimized builds
Dan Mosedale <dmose@mozilla.org> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 136773: Investigate enabling ldap:5 logging on optimized builds. https://bugzilla.mozilla.org/show_bug.cgi?id=136773 Attachment 207740: Allow logging ldap:5 on optimized builds https://bugzilla.mozilla.org/attachment.cgi?id=207740&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> r+sr=dmose; thanks Mark! ...

superreview granted: [Bug 229467] make xpfe/bootstrap/macbuild/Contents/Info.plist be generated by autoconf : [Attachment 174780] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted David Baron <dbaron@mozilla.org>'s request for superreview: Bug 229467: make xpfe/bootstrap/macbuild/Contents/Info.plist be generated by autoconf https://bugzilla.mozilla.org/show_bug.cgi?id=229467 Attachment 174780: patch https://bugzilla.mozilla.org/attachment.cgi?id=174780&action=edit ...

superreview granted: [Bug 345238] Make XPFE alerts service use alert origin reported by look and feel : [Attachment 247676] Port jens' patch (attachment 229835) to xpfe
neil@parkwaycc.co.uk <neil@httl.net> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 345238: Make XPFE alerts service use alert origin reported by look and feel https://bugzilla.mozilla.org/show_bug.cgi?id=345238 Attachment 247676: Port jens' patch (attachment 229835) to xpfe https://bugzilla.mozilla.org/attachment.cgi?id=247676&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> If biesi prefers you can call this an r+ and he can give sr+ ...

superreview granted: [Bug 321554] Firefox 1.5.0.1
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has granted Chase Phillips <chase@mozilla.org>'s request for superreview: Bug 321554: Firefox 1.5.0.1 - Update build and branch values https://bugzilla.mozilla.org/show_bug.cgi?id=321554 Attachment 207208: Stab, v2 https://bugzilla.mozilla.org/attachment.cgi?id=207208&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> Yes, we definitely need to bump the gecko version (UA string, xulrunner version, etc). ...

superreview granted: [Bug 343395] Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) : [Attachment 228615] Patch v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 343395: Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) https://bugzilla.mozilla.org/show_bug.cgi?id=343395 Attachment 228615: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=228615&action=edit ...

superreview granted: [Bug 329021] Get non-static builds of mailnews working when MOZ_XUL_APP set : [ Attachment 294736] Add nsAbLDAPDirectoryQuery to AB components
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 329021: Get non-static builds of mailnews working when MOZ_XUL_APP set https://bugzilla.mozilla.org/show_bug.cgi?id=329021 Attachment 294736: Add nsAbLDAPDirectoryQuery to AB components https://bugzilla.mozilla.org/attachment.cgi?id=294736&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So the rest of attachment 275769 is OK then? ...

Web resources about - superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6 - First stab at sorting out inclusion of modules in xpfe - mozilla.dev.super-review

Resources last updated: 1/23/2016 8:41:21 PM