superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249378] adjust unread counts for message headers we don'tDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 249378: adjust unread counts for message headers we don't have, but
just once for any given header
https://bugzilla.mozilla.org/attachment.cgi?id=249378&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
this keeps track of the range of headers we'v...
superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249328] fix counts issueScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 249328: fix counts issue
https://bugzilla.mozilla.org/attachment.cgi?id=249328&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
I'm assuming we want both this patch and the other one I just reviewed for
this bug...
...
superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249328] fix counts issueDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 249328: fix counts issue
https://bugzilla.mozilla.org/attachment.cgi?id=249328&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
If there are missing headers on the server (e.g., a message is cancelled), we
were always showing that message as unread. So in...
superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 248023] work in progressScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 248023: work in progress
https://bugzilla.mozilla.org/attachment.cgi?id=248023&action=edit
...
superreview requested: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 248023] work in progressDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 248023: work in progress
https://bugzilla.mozilla.org/attachment.cgi?id=248023&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
the patch definitely seems like an improvement
...
superreview granted: [Bug 267672] Request: groups (when "group by sort") should have the number of read and unread emails : [Attachment 192746] don't show the unread count if there aren't any unread David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 267672: Request: groups (when "group by sort") should have the number of
read and unread emails
https://bugzilla.mozilla.org/show_bug.cgi?id=267672
Attachment 192746: don't show the unread count if there aren't any unread
messages
https://bugzilla.mozilla.org/attachment.cgi?id=192746&action=edit
...
superreview granted: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fixScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 259649: header only downloaded pop3 messages don't download correctly if
filters sent header to different folder
http://bugzilla.mozilla.org/show_bug.cgi?id=259649
Attachment 159016: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit
...
superreview requested: [Bug 267672] Request: groups (when "group by sort") should have the number of read and unread emails : [Attachment 192746] don't show the unread count if there aren't any unreaScott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 267672: Request: groups (when "group by sort") should have the number of
read and unread emails
https://bugzilla.mozilla.org/show_bug.cgi?id=267672
Attachment 192746: don't show the unread count if there aren't any unread
messages
https://bugzilla.mozilla.org/attachment.cgi?id=192746&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
Here's a variation of the contributed fix which skips the unread and ...
superreview requested: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fixDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 259649: header only downloaded pop3 messages don't download correctly if
filters sent header to different folder
http://bugzilla.mozilla.org/show_bug.cgi?id=259649
Attachment 159016: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
It's gonna take Howard a while to try this, so I think I should get it checked
in...
...
superreview granted: [Bug 233944] Avoid dynamic resizing of the message headers in the message pane : [Attachment 141188] the fix (should not impact folks that don't set this pref)David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 233944: Avoid dynamic resizing of the message headers in the message pane
http://bugzilla.mozilla.org/show_bug.cgi?id=233944
Attachment 141188: the fix (should not impact folks that don't set this pref)
http://bugzilla.mozilla.org/attachment.cgi?id=141188&action=edit
...
'Unread messages' count in newsgroups doesn't clearA few weeks ago I asked about why unread message count in newsgroups
doesn't clear when all messages have been read, and received a somewhat
lengthy and unspecific procedure for hunting and finding and correcting
something that gets set wrong. I think we need a simpler procedure for
finding the location to reset (I didn't find it), or I think it should
be regarded as a bug. Of course, the malfunction is something we can all
live with, but I think Mozilla deserves something better.
William B. Lurie keyboarded, On 4/15/2008 9:47 AM :
> A few weeks ago I asked about why unread...
superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if tBrendan Eich <brendan@mozilla.org> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 245619: Don't bother converting result of scripts into a string when the
caller doesn't care about the value.
http://bugzilla.mozilla.org/show_bug.cgi?id=245619
Attachment 150056: Don't convert the result to a string if the caller doesn't
care about the return value.
http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit
------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Duh, thanks. r+sr=me....
superreview granted: [Bug 214959] Xdefs.h not found while building with xft support on solaris : [Attachment 129134] Don't use Xdefs.h, and don't #undef Bool <rbs@maths.uq.edu.au> has granted Matt Selsky <selsky@columbia.edu>'s request
for superreview:
Bug 214959: Xdefs.h not found while building with xft support on solaris
http://bugzilla.mozilla.org/show_bug.cgi?id=214959
Attachment 129134: Don't use Xdefs.h, and don't #undef Bool
http://bugzilla.mozilla.org/attachment.cgi?id=129134&action=edit
...
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nondRobert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083
Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
...