superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246316] fix addressing comments, and change the file name parsing...

David Bienvenu <bienvenu@nventure.com> has granted  superreview:
Bug 290057: Thunderbird should integrate with the Spotlight Search
https://bugzilla.mozilla.org/show_bug.cgi?id=290057

Attachment 246316: fix addressing comments, and change the file name parsing...
https://bugzilla.mozilla.org/attachment.cgi?id=246316&action=edit

------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
This is basically the same patch, except that I changed the mac command line
processor code to pass in actual file names instead of file urls, which means
the code that parses the command line file needed to change a bit. The big
advantage of that is that now we can open .eml files from the command line, i I
can get the mac command line processing change reviewed...carrying forward
Scott's review.
0
bugzilla
11/22/2006 7:44:05 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
504 Views

Similar Articles

[PageSpeed] 53
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 430614] [GSoC] Thunderbird integration into Windows Vista/Windows Search indexer : [Attachment 329912] [to check in] Addressed review comments, merged folder iteration change
Siddharth Agarwal [:sid0] <sid1337@gmail.com> has granted superreview: Bug 430614: [GSoC] Thunderbird integration into Windows Vista/Windows Search indexer https://bugzilla.mozilla.org/show_bug.cgi?id=430614 Attachment 329912: [to check in] Addressed review comments, merged folder iteration changes https://bugzilla.mozilla.org/attachment.cgi?id=329912&action=edit ------- Additional Comments from Siddharth Agarwal [:sid0] <sid1337@gmail.com> Thanks for the fixes David. Carrying forward r/sr. ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246871] reserve string for spotlight integration pref ui
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246871: reserve string for spotlight integration pref ui https://bugzilla.mozilla.org/attachment.cgi?id=246871&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> access keys are case insensitive so that will conflict with "O". You'll probably need to use a key that'...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 247685] change notification to MsgMsgDisplayed
David Bienvenu <bienvenu@nventure.com> has granted superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 247685: change notification to MsgMsgDisplayed https://bugzilla.mozilla.org/attachment.cgi?id=247685&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> carrying forward Scott's sr. ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246185] teach Mac TB how to open .mozeml files from the command line
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246185: teach Mac TB how to open .mozeml files from the command line https://bugzilla.mozilla.org/attachment.cgi?id=246185&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Should we check the rv value here? + nsCOMPtr<nsIMsgAccountManager> accountManager = + do_GetServ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 247745] open messages from spotlight results in stand-alone message window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 247745: open messages from spotlight results in stand-alone message window https://bugzilla.mozilla.org/attachment.cgi?id=247745&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> - rv = OpenMessengerWindowWithUri("mail:3pane", folderUri.get(), msgKey); + rv = OpenMesse...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 245653] expose ability to get text of a message, in order for potential clients like spotlight su
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 245653: expose ability to get text of a message, in order for potential clients like spotlight support.. https://bugzilla.mozilla.org/attachment.cgi?id=245653&action=edit ...

superreview requested: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246871] reserve string for spotlight integration pref ui
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246871: reserve string for spotlight integration pref ui https://bugzilla.mozilla.org/attachment.cgi?id=246871&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> 'O' is used, but 'o' seems available - is that OK? ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246626] ignore .mozmsgs subdirectories
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246626: ignore .mozmsgs subdirectories https://bugzilla.mozilla.org/attachment.cgi?id=246626&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I agree we might want to remove the ifdef all together. Maybe we leverage the same directory structure on other platforms for other desktop s...

superreview cancelled: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 247685] change notification to MsgMsgDisplayed
David Bienvenu <bienvenu@nventure.com> has cancelled superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 247685: change notification to MsgMsgDisplayed https://bugzilla.mozilla.org/attachment.cgi?id=247685&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> oops, we wanted to pass in a reference to the msg hdr pane somehow where extensions can hang extra info off of, instead of the folder...obsoleting ...

superreview granted: [Bug 242959] Thunderbird should open .eml files from command line : [Attachment 184686] fix addressing comments
David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 242959: Thunderbird should open .eml files from command line https://bugzilla.mozilla.org/show_bug.cgi?id=242959 Attachment 184686: fix addressing comments https://bugzilla.mozilla.org/attachment.cgi?id=184686&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> carrying forward review ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246624] pass mac filenames to command line processor
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246624: pass mac filenames to command line processor https://bugzilla.mozilla.org/attachment.cgi?id=246624&action=edit ...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 247746] send MsgMsgDisplayed notification with header sink instead of folder
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 247746: send MsgMsgDisplayed notification with header sink instead of folder https://bugzilla.mozilla.org/attachment.cgi?id=247746&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Yeah, I think that's more helpful than the one had before. For those reading along, by moving it he...

superreview requested: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246185] teach Mac TB how to open .mozeml files from the command line
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor (On vacation until Nov. 19th) <mscott@mozilla.org> for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 246185: teach Mac TB how to open .mozeml files from the command line https://bugzilla.mozilla.org/attachment.cgi?id=246185&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> This teaches Mac TB how to open .mozeml files from the command line. W/O other changes, this cod...

superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 247471] unescape message id filenames, send global notification when msg is loaded
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 290057: Thunderbird should integrate with the Spotlight Search https://bugzilla.mozilla.org/show_bug.cgi?id=290057 Attachment 247471: unescape message id filenames, send global notification when msg is loaded https://bugzilla.mozilla.org/attachment.cgi?id=247471&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I'm wondering if we should document a list of all the known observer notification we want to...

Web resources about - superreview granted: [Bug 290057] Thunderbird should integrate with the Spotlight Search : [Attachment 246316] fix addressing comments, and change the file name parsing... - mozilla.dev.super-review

Resources last updated: 1/17/2016 12:48:25 AM