superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 216631] resolved points of comment #42
Darin Fisher (Google) <darin@meer.net> has granted Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp>'s request for superreview: Bug 261929: Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) https://bugzilla.mozilla.org/show_bug.cgi?id=261929 Attachment 216631: resolved points of comment #42 https://bugzilla.mozilla.org/attachment.cgi?id=216631&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: netwerk/base/src/nsStandardURL.cpp > #define GET_SEGMENT_ENCODER(name) \ ...

superreview requested: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 216631] resolved points of comment #42
Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 261929: Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) https://bugzilla.mozilla.org/show_bug.cgi?id=261929 Attachment 216631: resolved points of comment #42 https://bugzilla.mozilla.org/attachment.cgi?id=216631&action=edit ------- Additional Comments from Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp> > what about mozilla code that unescapes URIs? like nsTextToSubURI.cpp? doesn't > that ...

superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 169230] v2 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 261929: Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) https://bugzilla.mozilla.org/show_bug.cgi?id=261929 Attachment 169230: v2 patch https://bugzilla.mozilla.org/attachment.cgi?id=169230&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview requested: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 169230] v2 patch
Darin Fisher (IBM) <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 261929: Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) https://bugzilla.mozilla.org/show_bug.cgi?id=261929 Attachment 169230: v2 patch https://bugzilla.mozilla.org/attachment.cgi?id=169230&action=edit ...

superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch f
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206517: Patch for check-in https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit ...

superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch r
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> > v...

superreview granted: [Bug 260034] Cannot send mail if temporary directory contains non-ascii characters : [Attachment 184579] patch addressing darin's comment
Darin Fisher <darin@meer.net> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 260034: Cannot send mail if temporary directory contains non-ascii characters https://bugzilla.mozilla.org/show_bug.cgi?id=260034 Attachment 184579: patch addressing darin's comment https://bugzilla.mozilla.org/attachment.cgi?id=184579&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> I'm still a bit paranoid when using strcpy. The cost of checking that length of aPath == length of newCPath seems tolerable. You can...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fix this bug. aDocum...

superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Christian Biesinger (:bi) (reviews slower than usual) &l...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview granted: [Bug 241739] nsXULDocument seems unable to deal with non-ascii scripts : [Attachment 185903] implements comment 8's suggestion
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has granted Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu>'s request for superreview: Bug 241739: nsXULDocument seems unable to deal with non-ascii scripts https://bugzilla.mozilla.org/show_bug.cgi?id=241739 Attachment 185903: implements comment 8's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=185903&action=edit ------- Additional Comments from Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> >Index: base/src/nsScriptLoader.cpp >+nsScriptLoader::ConvertToU...

superreview requested: [Bug 260034] Cannot send mail if temporary directory contains non-ascii characters : [Attachment 184579] patch addressing darin's comment
Jungshik Shin <jshin1987@gmail.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 260034: Cannot send mail if temporary directory contains non-ascii characters https://bugzilla.mozilla.org/show_bug.cgi?id=260034 Attachment 184579: patch addressing darin's comment https://bugzilla.mozilla.org/attachment.cgi?id=184579&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> I addressed darin's concerns. As I wrote in the previous comment, the length will never change so that I just got rid of the check and used str...

superreview granted: [Bug 57802] Mailto: links with 'body' [Send Link from Firefox] fail to attach/insert signature in composition : [Attachment 232855] always add signature when mailto URL
neil@parkwaycc.co.uk <neil@httl.net> has granted Henrik Skupin <hskupin@gmail.com>'s request for superreview: Bug 57802: Mailto: links with 'body' [Send Link from Firefox] fail to attach/insert signature in composition https://bugzilla.mozilla.org/show_bug.cgi?id=57802 Attachment 232855: always add signature when mailto URL https://bugzilla.mozilla.org/attachment.cgi?id=232855&action=edit ...