superreview granted: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 231894] Fix for Mac, adjusted for review comments

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted  superreview:
Bug 237085: Text disappears with a large string of unbroken characters, e.g.,
in text input/field
https://bugzilla.mozilla.org/show_bug.cgi?id=237085

Attachment 231894: Fix for Mac, adjusted for review comments
https://bugzilla.mozilla.org/attachment.cgi?id=231894&action=edit
0
bugzilla
8/3/2006 10:18:37 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
640 Views

Similar Articles

[PageSpeed] 0
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 231754] Fix for Mac
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 231754: Fix for Mac https://bugzilla.mozilla.org/attachment.cgi?id=231754&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> I feel qualified to give this an r+ since I did the other platforms. + float MaxCharWidth = float(::CharWidth('M')); Make this maxCharWidth. ...

superreview granted: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225842] plan C v2
rbs@maths.uq.edu.au has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225842: plan C v2 https://bugzilla.mozilla.org/attachment.cgi?id=225842&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs +PRInt32 nsFontMetricsGTK::GetMaxStringLength(nscoord &aAveCharWidth) +{ + return mMaxStringLength; +} Typo. (Unintended argument from the copy-p...

superreview cancelled: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225672] Plan B
Robert O'Callahan (Novell) <roc@ocallahan.org> has cancelled Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225672: Plan B https://bugzilla.mozilla.org/attachment.cgi?id=225672&action=edit ...

superreview cancelled: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225837] plan C
Robert O'Callahan (Novell) <roc@ocallahan.org> has cancelled Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225837: plan C https://bugzilla.mozilla.org/attachment.cgi?id=225837&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> oops, I busted Thebes/cairo by deleting two lines I shouldn't have. ...

superreview requested: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225837] plan C
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked rbs@maths.uq.edu.au for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225837: plan C https://bugzilla.mozilla.org/attachment.cgi?id=225837&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Okay, this version has no interface changes. As I suggested in comment #61, we move the safety logic to nsRenderingContextImpl, which overrides the...

superreview requested: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225672] Plan B
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked rbs@maths.uq.edu.au for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225672: Plan B https://bugzilla.mozilla.org/attachment.cgi?id=225672&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Take 2: add support for varying the maximum string length based on the current font's max-advance. This fixes this bug for me; the testcase in ...

superreview requested: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 225842] plan C v2
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked rbs@maths.uq.edu.au for superreview: Bug 237085: Text disappears with a large string of unbroken characters, e.g., in text input/field https://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 225842: plan C v2 https://bugzilla.mozilla.org/attachment.cgi?id=225842&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> oops, I busted Thebes/cairo by deleting two lines I shouldn't have. ...

superreview granted: [Bug 237085] Text disappears in single-line input field or location bar on entering a large set of characters : [Attachment 144699] fix for nsFontMetricsXft
Christopher Blizzard <blizzard@mozilla.org> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 237085: Text disappears in single-line input field or location bar on entering a large set of characters http://bugzilla.mozilla.org/show_bug.cgi?id=237085 Attachment 144699: fix for nsFontMetricsXft http://bugzilla.mozilla.org/attachment.cgi?id=144699&action=edit ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview granted: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 233094: [FIX]input text doesn't appear in text box if text box is in floated cell http://bugzilla.mozilla.org/show_bug.cgi?id=233094 Attachment 140654: This fixes all three testcases and the website http://bugzilla.mozilla.org/attachment.cgi?id=140654&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> I'm not crazy about any of the table pseudo frame construction code, and I don't remember my previous objection ...

superreview granted: [Bug 363710] Removing text node from SVG <text> has no visible effect : [Attachment 248982] address review comment
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 363710: Removing text node from SVG <text> has no visible effect https://bugzilla.mozilla.org/show_bug.cgi?id=363710 Attachment 248982: address review comment https://bugzilla.mozilla.org/attachment.cgi?id=248982&action=edit ...

superreview granted: [Bug 58305] Find in page ignores text fields - does not search form textarea : [Attachment 145985] patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted rbs@maths.uq.edu.au's request for superreview: Bug 58305: Find in page ignores text fields - does not search form textarea http://bugzilla.mozilla.org/show_bug.cgi?id=58305 Attachment 145985: patch - updated per review comments http://bugzilla.mozilla.org/attachment.cgi?id=145985&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview granted: [Bug 155957] [FIX]input:before { content: ...; } causes caret placement problems for text inputs : [Attachment 137174] This fixes this bug (well, if I could reprocuce it it shou
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu>'s request for superreview: Bug 155957: [FIX]input:before { content: ...; } causes caret placement problems for text inputs http://bugzilla.mozilla.org/show_bug.cgi?id=155957 Attachment 137174: This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency... http://bugzilla.mozilla.org/attachment.cgi?id=137174&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> r+sr=dbaron, although this function should real...

superreview granted: [Bug 288839] ltr caret in input field unexpected (directional caret appears when only ltr input methods are installed) : [Attachment 229071] addressed review comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 288839: ltr caret in input field unexpected (directional caret appears when only ltr input methods are installed) https://bugzilla.mozilla.org/show_bug.cgi?id=288839 Attachment 229071: addressed review comments https://bugzilla.mozilla.org/attachment.cgi?id=229071&action=edit ...

Web resources about - superreview granted: [Bug 237085] Text disappears with a large string of unbroken characters, e.g., in text input/field : [Attachment 231894] Fix for Mac, adjusted for review comments - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/20/2016 4:36:26 PM