superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las

neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview:
Bug 156082: Don't hide the tab bar when clicking the close box (pref for
showing single tab ["Hide tab bar when only one tab is open"] is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=156082

Attachment 233414: blank last tab
https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
This will cause me dataloss, because I'm used to X hiding the tab bar...

>	      var l = this.mTabs.length;
>-	      if (l == 1) {
>-		// hide the tab bar
>-		this.mPrefs.setBoolPref("browser.tabs.forceHide", true);
>-		this.mStrip.collapsed = true;
>-		return;
>-	      }
Move the var l to where you use it. sr=me with this fixed.
0
bugzilla
8/16/2006 2:42:04 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
981 Views

Similar Articles

[PageSpeed] 3
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rec
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...

superreview requested: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 149199] Path
met - martin hassman <hassman@czilla.cz> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows http://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 149199: Path - don't hide tabbrowser with toolbar=no http://bugzilla.mozilla.org/attachment.cgi?id=149199&action=edit ------- Additional Comments from met - martin hassman <hassman@czilla.cz> Some tip for the sr ? ...

superreview cancelled: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 149199] Path
Ian Neal <bugzilla@arlen.demon.co.uk> has cancelled Met - Martin Hassman <hassman@czilla.cz>'s request for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows https://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 149199: Path - don't hide tabbrowser with toolbar=no https://bugzilla.mozilla.org/attachment.cgi?id=149199&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> Cancelling old sr request ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.com> re-requesting review from mconnor ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ...

"Close Tab" cannot close FireFox if "Always show tab bar" is enabled, when only 1 tab remains
Name: Rick Brewster Email: rbrewsteratwsudotedu Product: Firefox Release Candidate Summary: "Close Tab" cannot close FireFox if "Always show tab bar" is enabled, when only 1 tab remains Comments: Firefox 3 RC3 Like the title says, try the following: 1) In Tools->Options, on the Tabs section, make sure "Always show tab bar" is enabled (the checkbox is checked) 2) Close the dialog by pressing the OK button 3) Close all but 1 tab 4) Press Ctrl+W (or use File->Close Tab, of course) At this point the contents of the tab are closed ...

superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the re...

Web resources about - superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las - mozilla.dev.super-review

Resources last updated: 12/14/2015 6:43:45 AM