superreview granted: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the file
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ...

superreview granted: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 294485] Proposed fix (v4)
David Bienvenu <bienvenu@nventure.com> has granted rsx11m.pub@gmail.com's request for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=380354 Attachment 294485: Proposed fix (v4) https://bugzilla.mozilla.org/attachment.cgi?id=294485&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx for the patch. ...

superreview granted: [Bug 74959] implement mail "back" and "forward" : [Attachment 233310] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 233310: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=233310&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> woot! you should be able to use the new icons which are now on the branch and trunk for forward / back. The last two icons in: http://lxr.mozilla.org/seamo...

superreview granted: [Bug 208277] Not allowed to add "art-lojban" in "Add languages" preferences : [Attachment 124914] proposed patch to bug 208277
Darin Fisher <darin@netscape.com> has granted d95mback@dtek.chalmers.se's request for superreview: Bug 208277: Not allowed to add "art-lojban" in "Add languages" preferences http://bugzilla.mozilla.org/show_bug.cgi?id=208277 Attachment 124914: proposed patch to bug 208277 http://bugzilla.mozilla.org/attachment.cgi?id=124914&action=edit ------- Additional Comments from Darin Fisher <darin@netscape.com> sr=darin ...

superreview granted: [Bug 216479] when opening drafts and templates for editing, we don't use the saved " return receipts" and "attach vcard" info : [Attachment 295016] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 216479: when opening drafts and templates for editing, we don't use the saved "return receipts" and "attach vcard" info https://bugzilla.mozilla.org/show_bug.cgi?id=216479 Attachment 295016: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx, Magnus, makes sense. ...

superreview canceled: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 293600] Proposed fix (v3)
Karsten D=C3=BCsterloh <mnyromyr@tprac.de> has canceled rsx11m.pub@gmail.co= m's request for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=3D380354 Attachment 293600: Proposed fix (v3) https://bugzilla.mozilla.org/attachment.cgi?id=3D293600&action=3Dedit ------- Additional Comments from Karsten D=C3=BCsterloh <mnyromyr@tprac.de> Basically fine, just some second thought nits:=0D =0D >Index: mailnews/compose/src/nsMsgCompose.cpp=0D...

superreview requested: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 293600] Proposed fix (v3)
rsx11m.pub@gmail.com has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=380354 Attachment 293600: Proposed fix (v3) https://bugzilla.mozilla.org/attachment.cgi?id=293600&action=edit ------- Additional Comments from rsx11m.pub@gmail.com Updated patch: * checkbox only in TB composition preferences, no longer for SM * boolean preference to add or omit ".eml" extension (see note below) * s...

superreview requested: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 294485] Proposed fix (v4)
rsx11m.pub@gmail.com has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=380354 Attachment 294485: Proposed fix (v4) https://bugzilla.mozilla.org/attachment.cgi?id=294485&action=edit ...

superreview canceled: [Bug 380354] TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1. 5 was OK : [Attachment 290896] Proposed fix (v2)
rsx11m.pub@gmail.com has canceled rsx11m.pub@gmail.com's request for superreview: Bug 380354: TB2 adds ".eml" extension to attached messages, causes virus scanner to complain; TB1.5 was OK https://bugzilla.mozilla.org/show_bug.cgi?id=380354 Attachment 290896: Proposed fix (v2) https://bugzilla.mozilla.org/attachment.cgi?id=290896&action=edit ...

superreview requested: [Bug 421763] bookmarks restore only allows you to consider files named .html : [Attachment 315453] Adds "All Files" filter option when choosing "Bookmark Restore" file
Jason Harvey <jason@alioth.us> has asked Dietrich Ayala <dietrich@mozilla.com> for superreview: Bug 421763: bookmarks restore only allows you to consider files named .html https://bugzilla.mozilla.org/show_bug.cgi?id=421763 Attachment 315453: Adds "All Files" filter option when choosing "Bookmark Restore" file https://bugzilla.mozilla.org/attachment.cgi?id=315453&action=edit ------- Additional Comments from Jason Harvey <jason@alioth.us> Added an "All Files" filter option to the file chooser interface. The "JSON" option...

superreview canceled: [Bug 421763] bookmarks import and restore only allow files named .html and .json : [Attachment 315453] Adds "All Files" filter option when choosing "Bookmark Restore" file
Dietrich Ayala <dietrich@mozilla.com> has canceled Jason Harvey <jason@alioth.us>'s request for superreview: Bug 421763: bookmarks import and restore only allow files named .html and .json https://bugzilla.mozilla.org/show_bug.cgi?id=421763 Attachment 315453: Adds "All Files" filter option when choosing "Bookmark Restore" file https://bugzilla.mozilla.org/attachment.cgi?id=315453&action=edit ------- Additional Comments from Dietrich Ayala <dietrich@mozilla.com> r=me, thanks ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 233310] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 233310: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=233310&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this is getting to where I'd like to get it reviewed and landed... ...

superreview denied: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 148287] Set the real name to an eudora imported attached file.
Scott MacGregor <mscott@mozilla.org> has denied Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 148287: Set the real name to an eudora imported attached file. http://bugzilla.mozilla.org/attachment.cgi?id=148287&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Yann, is the fileName argument that gets passed into AddAttachment already...

superreview cancelled: [Bug 323109] deleted attachment: "Deleted: " vs "Deleted:", not localizable : [Attachment 210044] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 323109: deleted attachment: "Deleted: " vs "Deleted:", not localizable https://bugzilla.mozilla.org/show_bug.cgi?id=323109 Attachment 210044: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=210044&action=edit ...