superreview denied: [Bug 380984] NPAPI symbols hidden in libnullplugin. so and libunixprintplugin.so

Johnny Stenback <jst@mozilla.org> has denied Karl Tomlinson
<mozbugz@karlt.net>'s request for superreview:
Bug 380984: NPAPI symbols hidden in libnullplugin.so and libunixprintplugin.so
https://bugzilla.mozilla.org/show_bug.cgi?id=380984

Attachment 265249: patch using PR_EXTERN
https://bugzilla.mozilla.org/attachment.cgi?id=265249&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.org>
Hmm, odd. I never realized that npapi.h depends on nspr. It really shouldn't.
Plugins should be buildable using our headers w/o needing to include nspr
stuff, ideally.

Therefore, I'd rather see us duplicating the definition of PR_EXTERN (and
calling it NP_EXTERN or something) and making it do only what we need for
plugins for now.

With that change we'd get the same functionality w/o introducing more
dependencies on nspr (of which I don't actually see any right now). And one day
we should even remove that dependency, ideally.
0
bugzilla
5/24/2007 12:29:55 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
433 Views

Similar Articles

[PageSpeed] 20

Reply: