superreview denied: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch

neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz
<ajschult@verizon.net>'s request for superreview:
Bug 219662: "OK" button doesn't activate in "Link Properties" dialog
https://bugzilla.mozilla.org/show_bug.cgi?id=219662

Attachment 236543: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>   <textbox id="hrefInput" type="autocomplete"
>	     searchSessions="history" timeout="50" maxrows="6"
>	     disablehistory="false" class="uri-element"
>	     oninput="ChangeLinkLocation();">
>     <menupopup class="autocomplete-history-popup"
>		 popupalign="topleft" popupanchor="bottomleft"
>-		 oncommand="this.parentNode.value =
event.target.getAttribute('label');"/>
>+		 oncommand="this.parentNode.value =
event.target.getAttribute('label'); doEnabling()"/>
Why do you think we don't use oninput="doEnabling()"? Hint: there are two
reasons, one logical, one of style.
0
bugzilla
9/2/2006 9:37:51 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
508 Views

Similar Articles

[PageSpeed] 34

Reply: