superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 230560] don't close wi
Simon B�nzli <zeniko@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 230560: don't close windows with session history https://bugzilla.mozilla.org/attachment.cgi?id=230560&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> (In reply to comment #10) Of course, the current tests remain - this is just an ...

superreview cancelled: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 230887] don't flag win
Simon B�nzli <zeniko@gmail.com> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 230887: don't flag windows with session history as new https://bugzilla.mozilla.org/attachment.cgi?id=230887&action=edit ...

superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 230887] don't flag win
Simon B�nzli <zeniko@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 230887: don't flag windows with session history as new https://bugzilla.mozilla.org/attachment.cgi?id=230887&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> This patch introduces the same check as the other patch but already at docS...

superreview cancelled: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231343] use owner-chec
Simon B�nzli <zeniko@gmail.com> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 231343: use owner-check instead https://bugzilla.mozilla.org/attachment.cgi?id=231343&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> (In reply to comment #24) > this doesn't ensure that the window was opened in this ...

superreview granted: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231671] protect against
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 231671: protect against opened window being the same as the original window https://bugzilla.mozilla.org/attachment.cgi?id=231671&action=edit ...

superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231671] protect agains
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 231671: protect against opened window being the same as the original window https://bugzilla.mozilla.org/attachment.cgi?id=231671&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Darin and I discussed this approach and agree that it is ...

superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231343] use owner-chec
Simon B�nzli <zeniko@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 344808: Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 https://bugzilla.mozilla.org/show_bug.cgi?id=344808 Attachment 231343: use owner-check instead https://bugzilla.mozilla.org/attachment.cgi?id=231343&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> This patch makes sure that the opening window is in fact the opener of the new window before marking ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This se...

superreview canceled: [Bug 397935] Download Manager ("Downloads") window doesn' t stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has canceled Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com>'s request for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312089: v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312089&action=edit ------- Additional Comments from Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns...

superreview cancelled: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...