superreview requested: [Bug 343307] getElementsByTagNameNS("*", "foo") misses nodes : [Attachment 229404] FixBoris Zbarsky (gone June 26 -- Jul 13) <bzbarsky@mit.edu> has asked Jonas
Sicking <bugmail@sicking.cc> for superreview:
Bug 343307: getElementsByTagNameNS("*", "foo") misses nodes
https://bugzilla.mozilla.org/show_bug.cgi?id=343307
Attachment 229404: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=229404&action=edit
...
superreview granted: [Bug 343307] [FIX]getElementsByTagNameNS("*", "foo") misses nodes : [Attachment 229876] Updated to commentsJonas Sicking <bugmail@sicking.cc> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 343307: [FIX]getElementsByTagNameNS("*", "foo") misses nodes
https://bugzilla.mozilla.org/show_bug.cgi?id=343307
Attachment 229876: Updated to comments
https://bugzilla.mozilla.org/attachment.cgi?id=229876&action=edit
------- Additional Comments from Jonas Sicking <bugmail@sicking.cc>
Looks great! Thanks!
...
superreview requested: [Bug 343307] [FIX]getElementsByTagNameNS("*", "foo") misses nodes : [Attachment 229876] Updated to commentsBoris Zbarsky <bzbarsky@mit.edu> has asked Jonas Sicking <bugmail@sicking.cc>
for superreview:
Bug 343307: [FIX]getElementsByTagNameNS("*", "foo") misses nodes
https://bugzilla.mozilla.org/show_bug.cgi?id=343307
Attachment 229876: Updated to comments
https://bugzilla.mozilla.org/attachment.cgi?id=229876&action=edit
...
superreview cancelled: [Bug 361285] nocachedbodybody property in messenger.properties is missing a space between "Offline." and "In the future". : [Attachment 246067] fix for the branchScott MacGregor (On vacation until Nov. 19th) <mscott@mozilla.org> has
cancelled Scott MacGregor (On vacation until Nov. 19th) <mscott@mozilla.org>'s
request for superreview:
Bug 361285: nocachedbodybody property in messenger.properties is missing a
space between "Offline." and "In the future".
https://bugzilla.mozilla.org/show_bug.cgi?id=361285
Attachment 246067: fix for the branch
https://bugzilla.mozilla.org/attachment.cgi?id=246067&action=edit
------- Additional Comments from Scott MacGregor (On vacation until Nov. 19th)
<mscott@mozil...
superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] FixStefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the
"Advanced Account Settings" dialog
http://bugzilla.mozilla.org/show_bug.cgi?id=257801
Attachment 157725: Fix
http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit
...
superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] FixDavid Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe
<Stefan.Borggraefe@gmx.de>'s request for superreview:
Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the
"Advanced Account Settings" dialog
http://bugzilla.mozilla.org/show_bug.cgi?id=257801
Attachment 157725: Fix
http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
thx. I'm in the middle of making changes to this code, but I don't think this
wil...
superreview cancelled: [Bug 166369] download "foo.binary" fails at 100% "because an unexpected error occurred" [@ nsIFile.leafName] : [Attachment 133662] Fixed so it compilesChristian Biesinger <cbiesinger@web.de> has cancelled Boris Zbarsky (real world
intrudes) <bz-vacation@mit.edu>'s request for superreview:
Bug 166369: download "foo.binary" fails at 100% "because an unexpected error
occurred" [@ nsIFile.leafName]
http://bugzilla.mozilla.org/show_bug.cgi?id=166369
Attachment 133662: Fixed so it compiles
http://bugzilla.mozilla.org/attachment.cgi?id=133662&action=edit
------- Additional Comments from Christian Biesinger <cbiesinger@web.de>
clearing sr request on obsolete patch
...
superreview requested: [Bug 291198] "overflow" and "underflow" events are missing detail attribute : [Attachment 181327] Fix for bugNate Nielsen <nielsen@memberwebs.com> has asked David Baron
<dbaron@mozillafoundation.org> for superreview:
Bug 291198: "overflow" and "underflow" events are missing detail attribute
https://bugzilla.mozilla.org/show_bug.cgi?id=291198
Attachment 181327: Fix for bug
https://bugzilla.mozilla.org/attachment.cgi?id=181327&action=edit
...
superreview granted: [Bug 291198] "overflow" and "underflow" events are missing detail attribute : [Attachment 181327] Fix for bugDavid Baron <dbaron@mozillafoundation.org> has granted Nate Nielsen
<nielsen@memberwebs.com>'s request for superreview:
Bug 291198: "overflow" and "underflow" events are missing detail attribute
https://bugzilla.mozilla.org/show_bug.cgi?id=291198
Attachment 181327: Fix for bug
https://bugzilla.mozilla.org/attachment.cgi?id=181327&action=edit
...
superreview cancelled: [Bug 323109] deleted attachment: "Deleted: " vs "Deleted:", not localizable : [Attachment 210044] proposed fixMagnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 323109: deleted attachment: "Deleted: " vs "Deleted:", not localizable
https://bugzilla.mozilla.org/show_bug.cgi?id=323109
Attachment 210044: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=210044&action=edit
...
superreview cancelled: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with
function call")
http://bugzilla.mozilla.org/show_bug.cgi?id=228780
Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only)
http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit
...
superreview canceled: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 301314] proposed fix, v2Magnus Melin <mkmelin+mozilla@iki.fi> has canceled Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 301314: proposed fix, v2
https://bugzilla.mozilla.org/attachment.cgi?id=301314&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Moving forward Phil's r+
Unbitrotted the patch, and fixed disabling for news folders, which accidentally
got dropped between v1 and v2 of the patch.
...
superreview canceled: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 312264] proposed fix, v3Magnus Melin <mkmelin+mozilla@iki.fi> has canceled Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 312264: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=312264&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
One hunk didn't make it into the earlier patch...
...
superreview requested: [Bug 361285] nocachedbodybody property in messenger.properties is missing a space between "Offline." and "In the future". : [Attachment 246079] the fixScott MacGregor (On vacation until Nov. 19th) <mscott@mozilla.org> has asked
David Bienvenu <bienvenu@nventure.com> for superreview:
Bug 361285: nocachedbodybody property in messenger.properties is missing a
space between "Offline." and "In the future".
https://bugzilla.mozilla.org/show_bug.cgi?id=361285
Attachment 246079: the fix
https://bugzilla.mozilla.org/attachment.cgi?id=246079&action=edit
------- Additional Comments from Scott MacGregor (On vacation until Nov. 19th)
<mscott@mozilla.org>
Add a space without changing the entity id.
...