superreview cancelled: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242197] adGavin Sharp <gavin.sharp@gmail.com> has cancelled Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242197: additional cleanup patch
https://bugzilla.mozilla.org/attachment.cgi?id=242197&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
Further suggestion from Neil (this is still untested).
...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242204] adGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242204: additional cleanup patch, v2
https://bugzilla.mozilla.org/attachment.cgi?id=242204&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
Further suggestion from Neil (this is still untested).
...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242221] adGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242221: additional cleanup patch, v3
https://bugzilla.mozilla.org/attachment.cgi?id=242221&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
As Neil pointed out, I prefer JavaScript's || operator :)
...
superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 239997] propScott MacGregor <mscott@mozilla.org> has granted Mike Cowperthwaite
<mcow@well.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 239997: proposed patch - file mailnews/mime/src/mimeenc.cpp
https://bugzilla.mozilla.org/attachment.cgi?id=239997&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
cool. Thanks for the patch, and a libmim...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242197] paGavin Sharp <gavin.sharp@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242197: patch
https://bugzilla.mozilla.org/attachment.cgi?id=242197&action=edit
------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com>
This is an untested patch to fix Neil's style nit, and to make the code a bit
easier to read.
...
superreview granted: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 242221] addineil@parkwaycc.co.uk <neil@httl.net> has granted Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 242221: additional cleanup patch, v3
https://bugzilla.mozilla.org/attachment.cgi?id=242221&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
>+ /* Treat null bytes as spaces when format_out is
>+ ...
superreview requested: [Bug 343102] Thunderbird cannot forward messages correctly in the inline format when the message contains attachments encoded in quoted-printable format : [Attachment 239997] prMike Cowperthwaite <mcow@well.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 343102: Thunderbird cannot forward messages correctly in the inline format
when the message contains attachments encoded in quoted-printable format
https://bugzilla.mozilla.org/show_bug.cgi?id=343102
Attachment 239997: proposed patch - file mailnews/mime/src/mimeenc.cpp
https://bugzilla.mozilla.org/attachment.cgi?id=239997&action=edit
...
superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inline)Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 204350: (message/rfc822) Attached email message window glitches (forward,
reply, view source disabled)
https://bugzilla.mozilla.org/show_bug.cgi?id=204350
Attachment 200351: support reply/forward (as attachment and inline) for
message/rfc822 attachments
https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
+ rv = NS_NewURI(getter_AddRefs(uri), messageURI...
superreview requested: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inlinDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 204350: (message/rfc822) Attached email message window glitches (forward,
reply, view source disabled)
https://bugzilla.mozilla.org/show_bug.cgi?id=204350
Attachment 200351: support reply/forward (as attachment and inline) for
message/rfc822 attachments
https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
with this patch, thunderbird supports reply + forward as attachme...
superreview cancelled: [Bug 176443] Send Format preferences: "correct format" is confusing : [Attachment 109208] patch: HTML -> formatted text (HTML)Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has cancelled
timeless@myrealbox.com (working) <timeless@bemail.org>'s request for
superreview:
Bug 176443: Send Format preferences: "correct format" is confusing
https://bugzilla.mozilla.org/show_bug.cgi?id=176443
Attachment 109208: patch: HTML -> formatted text (HTML)
https://bugzilla.mozilla.org/attachment.cgi?id=109208&action=edit
...
superreview granted: [Bug 250291] html messages: forward as inline not quoting headers or inserting "original message" header : [Attachment 152960] Proposed patchDavid Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 250291: html messages: forward as inline not quoting headers or inserting
"original message" header
http://bugzilla.mozilla.org/show_bug.cgi?id=250291
Attachment 152960: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152960&action=edit
...
superreview requested: [Bug 250291] html messages: forward as inline not quoting headers or inserting "original message" header : [Attachment 152960] Proposed patchneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David
Bienvenu <bienvenu@nventure.com> for superreview:
Bug 250291: html messages: forward as inline not quoting headers or inserting
"original message" header
http://bugzilla.mozilla.org/show_bug.cgi?id=250291
Attachment 152960: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152960&action=edit
...
superreview cancelled: [Bug 317556] filter option "forward message to" does not allow one letter user part for email address : [Attachment 204068] correct fixDavid Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 317556: filter option "forward message to" does not allow one letter user
part for email address
https://bugzilla.mozilla.org/show_bug.cgi?id=317556
Attachment 204068: correct fix
https://bugzilla.mozilla.org/attachment.cgi?id=204068&action=edit
...
superreview cancelled: [Bug 317556] filter option "forward message to" does not allow one letter user part for email address : [Attachment 204068] correct fix #2David Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 317556: filter option "forward message to" does not allow one letter user
part for email address
https://bugzilla.mozilla.org/show_bug.cgi?id=317556
Attachment 204068: correct fix
https://bugzilla.mozilla.org/attachment.cgi?id=204068&action=edit
...