superreview cancelled: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text

Uri Bernstein <uriber@gmail.com> has cancelled Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not
move the caret to the visual end of the line, if the next line starts with
reverse-direction text
https://bugzilla.mozilla.org/show_bug.cgi?id=330461

Attachment 218353: patch
https://bugzilla.mozilla.org/attachment.cgi?id=218353&action=edit

------- Additional Comments from Uri Bernstein <uriber@gmail.com>
Actually, upon further consideration, I don't think this patch is correct. It
just happened to fix the problem by chance.

Simon, apologies for wasting your time on it.
0
bugzilla
4/16/2006 9:52:26 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
971 Views

Similar Articles

[PageSpeed] 5
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text :
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=330461 Attachment 232681: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=232681&action=edit ...

superreview requested: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text #2
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=330461 Attachment 232681: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=232681&action=edit ...

superreview requested: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text #3
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=330461 Attachment 218353: patch https://bugzilla.mozilla.org/attachment.cgi?id=218353&action=edit ...

superreview granted: [Bug 302051] Bidi: "Home" on line containing only text in reverse direction causes caret to be displayed on different line : [Attachment 229877] patch?!
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 302051: Bidi: "Home" on line containing only text in reverse direction causes caret to be displayed on different line https://bugzilla.mozilla.org/show_bug.cgi?id=302051 Attachment 229877: patch?! https://bugzilla.mozilla.org/attachment.cgi?id=229877&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> + if ((embeddingLevel & 1) && !lineIsRTL || !(embeddingLevel &...

superreview requested: [Bug 302051] Bidi: "Home" on line containing only text in reverse direction causes caret to be displayed on different line : [Attachment 229877] patch?!
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 302051: Bidi: "Home" on line containing only text in reverse direction causes caret to be displayed on different line https://bugzilla.mozilla.org/show_bug.cgi?id=302051 Attachment 229877: patch?! https://bugzilla.mozilla.org/attachment.cgi?id=229877&action=edit ...

superreview granted: [Bug 336617] Caret is placed in the middle of the line when pressing "Home" in line beginning with reverse-direction text : [Attachment 220795] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 336617: Caret is placed in the middle of the line when pressing "Home" in line beginning with reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=336617 Attachment 220795: patch https://bugzilla.mozilla.org/attachment.cgi?id=220795&action=edit ...

superreview granted: [Bug 299622] BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line : [Attachment 193559] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 299622: BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line https://bugzilla.mozilla.org/show_bug.cgi?id=299622 Attachment 193559: patch https://bugzilla.mozilla.org/attachment.cgi?id=193559&action=edit ...

superreview requested: [Bug 299622] BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line : [Attachment 193559] patch
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 299622: BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line https://bugzilla.mozilla.org/show_bug.cgi?id=299622 Attachment 193559: patch https://bugzilla.mozilla.org/attachment.cgi?id=193559&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> ROC - this is a bit of code removal which makes things look neater and work better. Don't worry - I won't ask for this to go into the br...

superreview granted: [Bug 312620] Bidi: Caret doesn't move correctly when arrowing where line wraps, if the wrapped line starts with a single reverse-direction character : [Attachment 199762] patch v
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 312620: Bidi: Caret doesn't move correctly when arrowing where line wraps, if the wrapped line starts with a single reverse-direction character https://bugzilla.mozilla.org/show_bug.cgi?id=312620 Attachment 199762: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=199762&action=edit ...

superreview granted: [Bug 313602] Bidi: Caret appears incorrectly when using up/down arrows to move into a blank line surrounded by reverse-direction text : [Attachment 200759] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 313602: Bidi: Caret appears incorrectly when using up/down arrows to move into a blank line surrounded by reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=313602 Attachment 200759: patch https://bugzilla.mozilla.org/attachment.cgi?id=200759&action=edit ...

superreview requested: [Bug 313602] Bidi: Caret appears incorrectly when using up/down arrows to move into a blank line surrounded by reverse-direction text : [Attachment 200759] patch
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 313602: Bidi: Caret appears incorrectly when using up/down arrows to move into a blank line surrounded by reverse-direction text https://bugzilla.mozilla.org/show_bug.cgi?id=313602 Attachment 200759: patch https://bugzilla.mozilla.org/attachment.cgi?id=200759&action=edit ...

superreview requested: [Bug 305083] [regression] When using ctrl+right-arrow on last word in a wrapping line, caret moves to end of line instead of to beginning of next line : [Attachment 193151] pat
Eyal Rozenberg <eyalroz@technion.ac.il> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 305083: [regression] When using ctrl+right-arrow on last word in a wrapping line, caret moves to end of line instead of to beginning of next line https://bugzilla.mozilla.org/show_bug.cgi?id=305083 Attachment 193151: patch https://bugzilla.mozilla.org/attachment.cgi?id=193151&action=edit ------- Additional Comments from Eyal Rozenberg <eyalroz@technion.ac.il> Damn, this mPreferLeft business is a horrible mess. The patch seems to fix the re...

superreview granted: [Bug 305083] [regression] When using ctrl+right-arrow on last word in a wrapping line, caret moves to end of line instead of to beginning of next line : [Attachment 193151] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Eyal Rozenberg <eyalroz@technion.ac.il>'s request for superreview: Bug 305083: [regression] When using ctrl+right-arrow on last word in a wrapping line, caret moves to end of line instead of to beginning of next line https://bugzilla.mozilla.org/show_bug.cgi?id=305083 Attachment 193151: patch https://bugzilla.mozilla.org/attachment.cgi?id=193151&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> alright. Let's do it. But if the going gets tough, ...

superreview requested: [Bug 299838] BiDi: Caret disappears outside the end of lines that end with spaces (when such lines are part of an overflowing paragraph) : [Attachment 188448] patch
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 299838: BiDi: Caret disappears outside the end of lines that end with spaces (when such lines are part of an overflowing paragraph) https://bugzilla.mozilla.org/show_bug.cgi?id=299838 Attachment 188448: patch https://bugzilla.mozilla.org/attachment.cgi?id=188448&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> Handle the RTL case similarly to the way the LTR case is handled. This should have been included in the fix f...

Web resources about - superreview cancelled: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text - mozilla.dev.super-review

Resources last updated: 11/27/2015 10:27:49 AM