superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2

Frank Wein <bugzilla@mcsmurf.de> has cancelled Frank Wein
<bugzilla@mcsmurf.de>'s request for superreview:
Bug 330053: Make SeaMonkey capable of generating a reasonable build with
MOZ_XUL_APP set.
https://bugzilla.mozilla.org/show_bug.cgi?id=330053

Attachment 219055: Patch for the Windows build v2
https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit

------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de>
Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/
code and so also removed the ifdef change in nsNativeAppSupportWin.h.
0
bugzilla
4/20/2006 4:54:39 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
639 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNativeAppSupport...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the pathc to get suiterunner to build on Mac. Some of this is just correcting the Makefile to things we already do in xpfe/bootstrap (the Info.pli...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> This has been bitrotted by another checkin. I&...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ifndef MOZ_SUITE >+# XXX Suite doesn't want these j...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Updated patch to account for bitrot from a checkin earlier today. Also m...

superreview cancelled: [Bug 290518] make cairo build on windows/msvc : [Attachment 180917] revised patch
T Rowley (IBM) <tor@acm.org> has cancelled Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 290518: make cairo build on windows/msvc https://bugzilla.mozilla.org/show_bug.cgi?id=290518 Attachment 180917: revised patch https://bugzilla.mozilla.org/attachment.cgi?id=180917&action=edit ...

superreview cancelled: [Bug 245653] components/build/nsModule tries to build with dogbert migration under BeOS, causing build to fail. AVIARY_1_0_20040515_BRANCH : [Attachment 150078] patch to remove
Mike Connor <mconnor@myrealbox.com> has cancelled Fredrik Holmqvist <thesuckiestemail@yahoo.se>'s request for superreview: Bug 245653: components/build/nsModule tries to build with dogbert migration under BeOS, causing build to fail. AVIARY_1_0_20040515_BRANCH http://bugzilla.mozilla.org/show_bug.cgi?id=245653 Attachment 150078: patch to remove Dogbert from BeOS builds http://bugzilla.mozilla.org/attachment.cgi?id=150078&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> r/a=me for landing on aviary/trunk ...

superreview cancelled: [Bug 290490] integrate suite/ into build process : [Attachment 180815] patch: add suite/ to build
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 290490: integrate suite/ into build process https://bugzilla.mozilla.org/show_bug.cgi?id=290490 Attachment 180815: patch: add suite/ to build https://bugzilla.mozilla.org/attachment.cgi?id=180815&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >+DIRS = >+ Shouldn't this be DIRS = \ $(NULL) so as to avoid having to modify that line in future? ...

superreview denied: [Bug 360109] make suiterunner help use SeaMonkey theme icons : [Attachment 246927] patch v2.1: classic+modern patch, updated to match new bug 361096 patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 360109: make suiterunner help use SeaMonkey theme icons https://bugzilla.mozilla.org/show_bug.cgi?id=360109 Attachment 246927: patch v2.1: classic+modern patch, updated to match new bug 361096 patch https://bugzilla.mozilla.org/attachment.cgi?id=246927&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Classic looks fine; you mentioned you wanted to get grippies to work but I don't see them in the browser either ...

superreview requested: [Bug 360109] make suiterunner help use SeaMonkey theme icons : [Attachment 246927] patch v2.1: classic+modern patch, updated to match new bug 361096 patch
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 360109: make suiterunner help use SeaMonkey theme icons https://bugzilla.mozilla.org/show_bug.cgi?id=360109 Attachment 246927: patch v2.1: classic+modern patch, updated to match new bug 361096 patch https://bugzilla.mozilla.org/attachment.cgi?id=246927&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This patch is updated to match recent changes in my patch for bug 361096 - we're using the :not() stuff as well for the overrides, an...

Web resources about - superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2 - mozilla.dev.super-review

Resources last updated: 12/18/2015 6:55:58 PM