superreview cancelled: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2

Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has cancelled
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for
superreview:
Bug 327873: Return-to-parent tab doesn't work for tabs opened by
target="_blank" links
https://bugzilla.mozilla.org/show_bug.cgi?id=327873

Attachment 223184: patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=223184&action=edit
0
bugzilla
5/24/2006 5:08:48 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
640 Views

Similar Articles

[PageSpeed] 48
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 327873: Return-to-parent tab doesn't work for tabs opened by target="_blank" links https://bugzilla.mozilla.org/show_bug.cgi?id=327873 Attachment 223184: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=223184&action=edit ...

superreview granted: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223190] v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 327873: Return-to-parent tab doesn't work for tabs opened by target="_blank" links https://bugzilla.mozilla.org/show_bug.cgi?id=327873 Attachment 223190: v3 - address comment 4 and some issues from IRC https://bugzilla.mozilla.org/attachment.cgi?id=223190&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ else if (aDragSession.sourceDocument && >+ a...

superreview requested: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223190] v3
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 327873: Return-to-parent tab doesn't work for tabs opened by target="_blank" links https://bugzilla.mozilla.org/show_bug.cgi?id=327873 Attachment 223190: v3 - address comment 4 and some issues from IRC https://bugzilla.mozilla.org/attachment.cgi?id=223190&action=edit ...

superreview granted: [Bug 347211] Jumpback doesn't work with "Open link in new tab" from link contextual menu : [Attachment 232279] Patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian <stridey@gmail.com>'s request for superreview: Bug 347211: Jumpback doesn't work with "Open link in new tab" from link contextual menu https://bugzilla.mozilla.org/show_bug.cgi?id=347211 Attachment 232279: Patch https://bugzilla.mozilla.org/attachment.cgi?id=232279&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink. landing trunk and branch. ...

superreview requested: [Bug 347211] Jumpback doesn't work with "Open link in new tab" from link contextual menu : [Attachment 232279] Patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 347211: Jumpback doesn't work with "Open link in new tab" from link contextual menu https://bugzilla.mozilla.org/show_bug.cgi?id=347211 Attachment 232279: Patch https://bugzilla.mozilla.org/attachment.cgi?id=232279&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Best. Patch. Ever. ...

superreview cancelled: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has cancelled Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ...

superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.com> re-requesting review from mconnor ...

superreview cancelled: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Mike Connor <mconnor@steelgryphon.com> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> New ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> r=me. Style stuff: >+ NSMenuItem* menuItem = [[NSMenuItem alloc] initWithTitle:NSL...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

Web resources about - superreview cancelled: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2 - mozilla.dev.super-review

Resources last updated: 12/12/2015 9:34:58 AM