superreview cancelled: [Bug 310395] Open Link in New Window - new background windows open with Address bar focused : [Attachment 223629] Last Patch before sr?

froodiantherapy <stridey@gmail.com> has cancelled froodiantherapy
<stridey@gmail.com>'s request for superreview:
Bug 310395: Open Link in New Window - new background windows open with Address
bar focused
https://bugzilla.mozilla.org/show_bug.cgi?id=310395

Attachment 223629: Last Patch before sr?
https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit

------- Additional Comments from froodiantherapy <stridey@gmail.com>
This patch unbitrots the previous one.	It touches all the high-traffic files,
and took a long time to get back up to date, so lets try to get this reviewed
and landed as quickly as possible. :)
0
bugzilla
7/3/2006 8:57:10 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
862 Views

Similar Articles

[PageSpeed] 28
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview canceled: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correct
Philip Chee <philip.chee@gmail.com> has canceled Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Neil on #IRC agrees that the .focus() isn't necessary. ...

superreview requested: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open : [Attachment 233097] low risk patch u
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Brian Ryner <bryner@gmail.com> for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: low risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> I'm still nervous about changing nsGlobalWindow.cp...

superreview cancelled: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has cancelled Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview cancelled: [Bug 155132] [patch] md+click or middle+click mailto: link opens extra window (or tab) : [Attachment 171913] Updated patch against latest CVS (also cleaned up my whitespace)
Smokey Ardisson (offline Apr 10-20) <alqahira@mindspring.com> has cancelled Bruce Davidson <mozilla@transoceanic.org.uk>'s request for superreview: Bug 155132: [patch] md+click or middle+click mailto: link opens extra window (or tab) https://bugzilla.mozilla.org/show_bug.cgi?id=155132 Attachment 171913: Updated patch against latest CVS (also cleaned up my whitespace) https://bugzilla.mozilla.org/attachment.cgi?id=171913&action=edit ------- Additional Comments from Smokey Ardisson (offline Apr 10-20) <alqahira@mindspring.com> Cancelling sr request on this...

superreview cancelled: [Bug 344257] [FIX]Hidden pref to open ALL windows open in tabs no longer works in this case : [Attachment 229429] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 344257: [FIX]Hidden pref to open ALL windows open in tabs no longer works in this case https://bugzilla.mozilla.org/show_bug.cgi?id=344257 Attachment 229429: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=229429&action=edit ...

superreview cancelled: [Bug 316372] mailto: links do not open Compose window anymore : [Attachment 204499] v1 patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has cancelled Darin Fisher <darin@meer.net>'s request for superreview: Bug 316372: mailto: links do not open Compose window anymore https://bugzilla.mozilla.org/show_bug.cgi?id=316372 Attachment 204499: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=204499&action=edit ...

superreview cancelled: [Bug 255372] FF10PR1 Crash with any javascript popup window (window.open) [@ 0x00000000
David Baron <dbaron@dbaron.org> has cancelled David Baron <dbaron@dbaron.org>'s request for superreview: Bug 255372: FF10PR1 Crash with any javascript popup window (window.open) [@ 0x00000000 - nsCOMPtr_base::assign_with_AddRef ] https://bugzilla.mozilla.org/show_bug.cgi?id=255372 Attachment 162906: plevent patch for branch https://bugzilla.mozilla.org/attachment.cgi?id=162906&action=edit ...

superreview cancelled: [Bug 255372] FF10PR1 Crash with any javascript popup window (window.open) [@ 0x00000000
David Baron <dbaron@dbaron.org> has cancelled David Baron <dbaron@dbaron.org>'s request for superreview: Bug 255372: FF10PR1 Crash with any javascript popup window (window.open) [@ 0x00000000 - nsCOMPtr_base::assign_with_AddRef ] https://bugzilla.mozilla.org/show_bug.cgi?id=255372 Attachment 162946: plevent patch for branch https://bugzilla.mozilla.org/attachment.cgi?id=162946&action=edit ...

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correc
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Steps to reproduce: 1. Navigate to any page. 2. Click on the security button in the statu...

superreview granted: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correct
neil@parkwaycc.co.uk <neil@httl.net> has granted superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ...

superreview granted: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open : [Attachment 233097] alternative, low
Brian Ryner <bryner@gmail.com> has granted Seth Spitzer [:ss] <sspitzer@mozilla.com>'s request for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: alternative, low-risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ...

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295012] V1. 1 Open the PageInfo window with the c
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295012: V1.1 Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295012&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Neil on #IRC agrees that the .focus() isn't necessary. ...

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295015] V1. 2 Open the PageInfo window with the c
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295015: V1.2 Open the PageInfo window with the correct tab selected (fix nits) https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Fix Neil's nits. ...

superreview denied: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295012] V1. 1 Open the PageInfo window with the cor
neil@parkwaycc.co.uk <neil@httl.net> has denied Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295012: V1.1 Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295012&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Sorry, but it turns out that I prefer the focus behaviour of attachmen...

superreview denied: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295015] V1. 2 Open the PageInfo window with the cor
neil@parkwaycc.co.uk <neil@httl.net> has denied Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295015: V1.2 Open the PageInfo window with the correct tab selected (fix nits) https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Bah, he gives me a good reason, then ignores it... ...

Web resources about - superreview cancelled: [Bug 310395] Open Link in New Window - new background windows open with Address bar focused : [Attachment 223629] Last Patch before sr? - mozilla.dev.super-review

Resources last updated: 1/2/2016 6:58:24 PM