superreview canceled: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 312264] proposed fix, v3Magnus Melin <mkmelin+mozilla@iki.fi> has canceled Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 312264: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=312264&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
One hunk didn't make it into the earlier patch...
...
superreview requested: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 313184] proposed fix, v4Magnus Melin <mkmelin+mozilla@iki.fi> has asked Dan Mosedale
<dmose@mozilla.org> for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 313184: proposed fix, v4
https://bugzilla.mozilla.org/attachment.cgi?id=313184&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
One hunk didn't make it into the earlier patch...
...
superreview granted: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 313184] proposed fix, v4Dan Mosedale <dmose@mozilla.org> has granted Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=3D75927
Attachment 313184: proposed fix, v4
https://bugzilla.mozilla.org/attachment.cgi?id=3D313184&action=3Dedit
------- Additional Comments from Dan Mosedale <dmose@mozilla.org>
Sorry for the delay; sr=3Ddmose. Out of curiousity, why is it necessary to =
have
separate XUL commands for the button and the menu command?=
...
superreview requested: [Bug 75927] RFE: "Compact" or "Purge" button : [Attachment 312264] proposed fix, v3Magnus Melin <mkmelin+mozilla@iki.fi> has asked Dan Mosedale
<dmose@mozilla.org> for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 312264: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=312264&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Moving forward Phil's r+
Unbitrotted the patch, and fixed disabling for news folders, which accidentally
got dropped between v1 and v2 of the patch.
...
superreview requested: [Bug 75927] RFE: "Compact" or "Purge" buttonMagnus Melin <mkmelin+mozilla@iki.fi> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 75927: RFE: "Compact" or "Purge" button
https://bugzilla.mozilla.org/show_bug.cgi?id=75927
Attachment 291103: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=291103&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
This adds a "Compact" button that can be added to the toolbar. The qute icons
and base for the patch are courtesy of Mark Edgington. I made some pinstripe
icons-- an ico...
superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttonsAdam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello
<bugs@abecevello.imapmail.org>'s request for superreview:
Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons
are next to each other)
https://bugzilla.mozilla.org/show_bug.cgi?id=199262
Attachment 118601: patch that swaps the "Mark" and "Junk" buttons
https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit
------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org>
Remo...
superreview cancelled: [Bug 323109] deleted attachment: "Deleted: " vs "Deleted:", not localizable : [Attachment 210044] proposed fixMagnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 323109: deleted attachment: "Deleted: " vs "Deleted:", not localizable
https://bugzilla.mozilla.org/show_bug.cgi?id=323109
Attachment 210044: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=210044&action=edit
...
superreview cancelled: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 234683] proposed fix, v2Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread
columns
https://bugzilla.mozilla.org/show_bug.cgi?id=338753
Attachment 234683: proposed fix, v2
https://bugzilla.mozilla.org/attachment.cgi?id=234683&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Changes from v2: made search for From match "Sender:" also.
One caveat: For some reason matching...
superreview cancelled: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226965] Add a "Do this automatically from now on" checkbox, v2Jens Bannmann <jens.b@web.de> has cancelled Jens Bannmann <jens.b@web.de>'s
request for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226965: Add a "Do this automatically from now on" checkbox, v2
https://bugzilla.mozilla.org/attachment.cgi?id=226965&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Fixed the brace.
...
superreview cancelled: [Bug 343307] [FIX]getElementsByTagNameNS("*", "foo") misses nodes : [Attachment 229404] FixBoris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 343307: [FIX]getElementsByTagNameNS("*", "foo") misses nodes
https://bugzilla.mozilla.org/show_bug.cgi?id=343307
Attachment 229404: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=229404&action=edit
...
superreview requested: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] FixStefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the
"Advanced Account Settings" dialog
http://bugzilla.mozilla.org/show_bug.cgi?id=257801
Attachment 157725: Fix
http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit
...
superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] FixDavid Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe
<Stefan.Borggraefe@gmx.de>'s request for superreview:
Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the
"Advanced Account Settings" dialog
http://bugzilla.mozilla.org/show_bug.cgi?id=257801
Attachment 157725: Fix
http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
thx. I'm in the middle of making changes to this code, but I don't think this
wil...
superreview cancelled: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 240930] proposed fix, v3Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled Magnus Melin
<mkmelin+mozilla@iki.fi>'s request for superreview:
Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread
columns
https://bugzilla.mozilla.org/show_bug.cgi?id=338753
Attachment 240930: proposed fix, v3
https://bugzilla.mozilla.org/attachment.cgi?id=240930&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Updated patch, this doesn't touch the tree col ID.
Quick search doesn't match also "Sender:...
superreview cancelled: [Bug 338753] don't confuse "Sender:"-header with "From:" in quick search, thread columns : [Attachment 242434] proposed fix, v4Scott MacGregor <mscott@mozilla.org> has cancelled superreview:
Bug 338753: don't confuse "Sender:"-header with "From:" in quick search, thread
columns
https://bugzilla.mozilla.org/show_bug.cgi?id=338753
Attachment 242434: proposed fix, v4
https://bugzilla.mozilla.org/attachment.cgi?id=242434&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
pulling back the sr until we look into David's concerns. We might go back to
taking this patch but without the From + Sender behavior for quick search...
...