superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ...

superreview granted: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment 3 #2
Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> has granted Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com>'s request for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312093: xpcom test v.10 https://bugzilla.mozilla.org/attachment.cgi?id=312093&action=edit ...

superreview granted: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment 3 #3
Mike Connor <mconnor@mozilla.com> has granted Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com>'s request for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ------- Additional Comments from Mike Connor <mconnor@mozilla.com> sr=mconnor, I would probably explici...

superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn' t stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachme
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312093: xpcom test v.10 https://bugzilla.mozilla.org/attachment.cgi?id=312093&action=edit ------- Additional Comments from Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns....

superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn' t stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachmen #3
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ------- Additional Comments from Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> Incorporates test update, revi...

superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn' t stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachmen #2
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312089: v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312089&action=edit ------- Additional Comments from Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> This passes Edward's test ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> Actually, I'm going to go ahead and check this in on the trunk, since thes...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225294] close blank window
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225294: close blank window https://bugzilla.mozilla.org/attachment.cgi?id=225294&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> This is a first try at closing the window after the external app handler has done its work. This se...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 226289] pass state in the channel
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 226289: pass state in the channel https://bugzilla.mozilla.org/attachment.cgi?id=226289&action=edit ...

superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 225903] docshell tracks whether it lo
Marria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 225903: docshell tracks whether it loaded any content before https://bugzilla.mozilla.org/attachment.cgi?id=225903&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's re
Darin Fisher (Google) <darin@meer.net> has granted Marria Nazif <marria@gmail.com>'s request for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: docshell/base/nsDocShell.cpp > if (!r...