superreview requested: [Bug 361545] Last line not selected when dragging downwards to following whitespace, in certain cases of Bidi with letter-spacing, word-spacing, etc. : [Attachment 246320] patcUri Bernstein (mostly gone) <uriber@gmail.com> has asked Robert O'Callahan
(Novell) <roc@ocallahan.org> for superreview:
Bug 361545: Last line not selected when dragging downwards to following
whitespace, in certain cases of Bidi with letter-spacing, word-spacing, etc.
https://bugzilla.mozilla.org/show_bug.cgi?id=361545
Attachment 246320: patch (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=246320&action=edit
------- Additional Comments from Uri Bernstein (mostly gone) <uriber@gmail.com>
I guess we can fix it by not failing on empty frames in Get...
Line spacing, word spacing, char spacing
I already found out line , word and char spacing are not foreseen in GDI+.According to some websites, the MeasureString method does not work the way it should. (which I could use to manually change the X/Y positions etc.)Does anyone know of a component that will do the trick?And preferrably not one that will cost me hundreds of euros :)All I want to do is put some text on an image ...The only problem being is that line, word and char spacing are strict requirement.Seems easy, but I'm quite desperate so thank you for your early reply....
superreview cancelled: [Bug 306895] Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" and textareas : [Attachment 195031] patch v1.1Uri Bernstein <uriber@gmail.com> has cancelled Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 306895: Triple click should select lines, not paragraphs, in "white-space:
-moz-pre-wrap;" and textareas
https://bugzilla.mozilla.org/show_bug.cgi?id=306895
Attachment 195031: patch v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=195031&action=edit
...
superreview cancelled: [Bug 306895] Triple click should select lines, not paragraphs, in "white-space: -moz-pre-wrap;" and textareas : [Attachment 195007] patch v1.0Uri Bernstein <uriber@gmail.com> has cancelled Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 306895: Triple click should select lines, not paragraphs, in "white-space:
-moz-pre-wrap;" and textareas
https://bugzilla.mozilla.org/show_bug.cgi?id=306895
Attachment 195007: patch v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=195007&action=edit
...
superreview canceled: [Bug 391584] double-clicking a word followed by link selects the first word of the link textRobert O'Callahan (:roc) <roc@ocallahan.org> has canceled Robert O'Callahan
(:roc) <roc@ocallahan.org>'s request for superreview:
Bug 391584: double-clicking a word followed by link selects the first word of
the link text
https://bugzilla.mozilla.org/show_bug.cgi?id=391584
Attachment 281407: fix
https://bugzilla.mozilla.org/attachment.cgi?id=281407&action=edit
...
superreview requested: [Bug 274268] sourceNode is not null for external drags : [Attachment 172018] fix described bug, reset fields, use 2 space instead of 1 space indentation...timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 274268: sourceNode is not null for external drags
https://bugzilla.mozilla.org/show_bug.cgi?id=274268
Attachment 172018: fix described bug, reset fields, use 2 space instead of 1
space indentation...
https://bugzilla.mozilla.org/attachment.cgi?id=172018&action=edit
...
superreview cancelled: [Bug 300779] Support multiple selection for xul:tree : [Attachment 189992] Assume that space does nothing in single selectAaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 300779: Support multiple selection for xul:tree
https://bugzilla.mozilla.org/show_bug.cgi?id=300779
Attachment 189992: Assume that space does nothing in single select
https://bugzilla.mozilla.org/attachment.cgi?id=189992&action=edit
...
superreview granted: [Bug 274268] sourceNode is not null for external drags : [Attachment 172018] fix described bug, reset fields, use 2 space instead of 1 space indentation...Boris Zbarsky <bzbarsky@mit.edu> has granted timeless@myrealbox.com (working)
<timeless@bemail.org>'s request for superreview:
Bug 274268: sourceNode is not null for external drags
https://bugzilla.mozilla.org/show_bug.cgi?id=274268
Attachment 172018: fix described bug, reset fields, use 2 space instead of 1
space indentation...
https://bugzilla.mozilla.org/attachment.cgi?id=172018&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky assuming this has been tested
...
superreview granted: [Bug 299838] BiDi: Caret disappears outside the end of lines that end with spaces (when such lines are part of an overflowing paragraph) : [Attachment 188448] patchRobert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 299838: BiDi: Caret disappears outside the end of lines that end with
spaces (when such lines are part of an overflowing paragraph)
https://bugzilla.mozilla.org/show_bug.cgi?id=299838
Attachment 188448: patch
https://bugzilla.mozilla.org/attachment.cgi?id=188448&action=edit
...
superreview requested: [Bug 299838] BiDi: Caret disappears outside the end of lines that end with spaces (when such lines are part of an overflowing paragraph) : [Attachment 188448] patchUri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 299838: BiDi: Caret disappears outside the end of lines that end with
spaces (when such lines are part of an overflowing paragraph)
https://bugzilla.mozilla.org/show_bug.cgi?id=299838
Attachment 188448: patch
https://bugzilla.mozilla.org/attachment.cgi?id=188448&action=edit
------- Additional Comments from Uri Bernstein <uriber@gmail.com>
Handle the RTL case similarly to the way the LTR case is handled. This should
have been included in the fix f...
superreview requested: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetricsrbs@maths.uq.edu.au has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview:
Bug 21616: Space after ::first-letter pseudo-element line is larger than
between other lines
https://bugzilla.mozilla.org/show_bug.cgi?id=21616
Attachment 166184: fix based on MathML's GetBoundingMetrics
https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit
------- Additional Comments from rbs@maths.uq.edu.au
Asking r/sr to beautify ::first-letter by default at little cost (since MathML
is on by default these days).
...
superreview granted: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetricsBoris Zbarsky <bzbarsky@mit.edu> has granted rbs@maths.uq.edu.au's request for
superreview:
Bug 21616: Space after ::first-letter pseudo-element line is larger than
between other lines
https://bugzilla.mozilla.org/show_bug.cgi?id=21616
Attachment 166184: fix based on MathML's GetBoundingMetrics
https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky, and could you file a bug on making GetBoundingMetrics either
have its own ifdef (implied by MOZ_MATHML) or just be alway...
superreview granted: [Bug 132561] whitespace before <BR> should be ignored (trailing whitespace at end of line should be collapsed in white-space:normal) : [Attachment 141353] This is the right thingDavid Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 132561: whitespace before <BR> should be ignored (trailing whitespace at
end of line should be collapsed in white-space:normal)
http://bugzilla.mozilla.org/show_bug.cgi?id=132561
Attachment 141353: This is the right thing
http://bugzilla.mozilla.org/attachment.cgi?id=141353&action=edit
------- Additional Comments from David Baron <dbaron@dbaron.org>
r+sr=dbaron, but fix the comment in the last chunk of the patch
...
superreview requested: [Bug 132561] whitespace before <BR> should be ignored (trailing whitespace at end of line should be collapsed in white-space:normal) : [Attachment 141353] This is the right thiBoris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for
superreview:
Bug 132561: whitespace before <BR> should be ignored (trailing whitespace at
end of line should be collapsed in white-space:normal)
http://bugzilla.mozilla.org/show_bug.cgi?id=132561
Attachment 141353: This is the right thing
http://bugzilla.mozilla.org/attachment.cgi?id=141353&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
David, what do you think?
...