Re: test skipping based on $Config{extensions} (was: Re: [PATCH] Re: [PATCH] Re: Win32 modules & cygwin)

Craig Berry wrote:
> On 3/13/07, Yitzchak Scott-Thoennes <sthoenna@efn.org> wrote:
>> On Tue, Feb 27, 2007 at 02:43:29AM -0800, Yitzchak Scott-Thoennes wrote:
>> > Steve Hay wrote:
>> > > Yitzchak Scott-Thoennes wrote:
>> > >> On Mon, Feb 26, 2007 at 01:28:51PM +0000, Steve Hay wrote:
>> > >>> Thanks, applied as #30409.
>> > >>
>> > >> Um, given Craig's comment in
>> > >> http://nntp.perl.org/group/perl.perl5.porters/121449, I think I'd
>> > >> rather this were reverted.
>> > >>
>> > >> Since TEST and harness automatically handle skipping known but not
>> > >> built extensions' tests, $Config{extensions}-checking code
>> shouldn't
>> > >> clutter up the tests.
>> > >
>> > > I haven't investigated this at all yet, but I recall no so long ago
>> > > Nicholas going through lots of test files and having tests skipped
>> if
>> > > modules weren't built.
>> > >
>> > > A quick look in Changes reveals quite a few such changes, e.g.:
>> > >
>> > > Skip Devel::PPPort tests if Devel::PPPort was not built:
>> > > http://public.activestate.com/cgi-bin/perlbrowse/p/22953
>> > >
>> > > Skip re tests if re was not built:
>> > > http://public.activestate.com/cgi-bin/perlbrowse/p/22952
>> > >
>> > > Skip B tests if B was not built:
>> > > http://public.activestate.com/cgi-bin/perlbrowse/p/22951
>> > >
>> > > and others...
>> > >
>> > > I'm sure all those changes weren't unnecessary, but I've forgotten
>> what
>> > > the motivation for them was.  Whatever it was might also apply to
>> > > Win32CORE and Win32API.
>> >
>> > FWIW, Nicholas added the automatic skipping to TEST and harness in
>> > http://public.activestate.com/cgi-bin/perlbrowse/p/23448
>> > so the behavior wasn't there at the time of the earlier patches
>> > you mention.
>> >
>> > Nicholas?  Was that intended to be in addition to or instead of
>> > per-test skipping?
>>
>>
>> It still makes sense to me to revert #30409, unless other people
>> object.
>
> I don't strongly object, but I don't see any harm in leaving it in.
> More generally, I don't see any easy, maintenance-free way to do this
> right.

I'd like to be consistent, and it seems the easiest way to get and
stay consistent is to rely on TEST and harness doing the right thing
and {known_,}extensions being kept correct for all platforms.

I also don't like the idea of cruft being added to a module just because
it's been added to the core.

> If the "Am I built?" check is close to the thing that has to be
> tested, then the person maintaining that thing doesn't have to have
> knowledge of external bits and pieces that must  be modified so the
> test will be excluded when necessary.  But then a very similar check
> is expected to be maintained in a bazillion places, and experience
> shows that isn't a very realistic expectation.
>
> If the difference between known extensions and built extensions is
> used to determine which tests to run and which to exclude, then
> whoever adds something new under ext/ should make sure the
> known_extensions list gets updated on all platforms,.  But experience
> shows that isn't a realistic expectation either (though perhaps it is
> something that eventually needs to be done anyway).
>
> On a related note, I find I am no longer confident I understand what
> "known extension" means.   Porting/Glossary says, "all XS extensions
> included in the package."  It never occurred to me to add the Win32
> extensions to $Config{known_extensions} on VMS until this thread
> started because there is no meaningful sense in which those extensions
> will ever be included in a non-Win32 build.  Is merely occupying space
> in the source tarball what we mean by "included"?

I'd think it would mean occupying space under ext/.  I wouldn't
expect the modules under vms/ext or os2/OS2 to show up for other
platforms.  The Win32 modules are something of a special case
because they are shared by the cygwin and win32 platforms.

0
sthoenna
3/14/2007 1:49:25 AM
perl.perl5.porters 48276 articles. 1 followers. Follow

1 Replies
748 Views

Similar Articles

[PageSpeed] 35

WWl0emNoYWsgU2NvdHQtVGhvZW5uZXMgd3JvdGU6Cj4gQ3JhaWcgQmVycnkgd3JvdGU6Cj4+IE9u
IDMvMTMvMDcsIFlpdHpjaGFrIFNjb3R0LVRob2VubmVzIDxzdGhvZW5uYUBlZm4ub3JnPiB3cm90
ZToKPj4+IE9uIFR1ZSwgRmViIDI3LCAyMDA3IGF0IDAyOjQzOjI5QU0gLTA4MDAsIFlpdHpjaGFr
IFNjb3R0LVRob2VubmVzIHdyb3RlOgo+Pj4+IFN0ZXZlIEhheSB3cm90ZToKPj4+Pj4gWWl0emNo
YWsgU2NvdHQtVGhvZW5uZXMgd3JvdGU6Cj4+Pj4+PiBPbiBNb24sIEZlYiAyNiwgMjAwNyBhdCAw
MToyODo1MVBNICswMDAwLCBTdGV2ZSBIYXkgd3JvdGU6Cj4+Pj4+Pj4gVGhhbmtzLCBhcHBsaWVk
IGFzICMzMDQwOS4KPj4+Pj4+IFVtLCBnaXZlbiBDcmFpZydzIGNvbW1lbnQgaW4KPj4+Pj4+IGh0
dHA6Ly9ubnRwLnBlcmwub3JnL2dyb3VwL3BlcmwucGVybDUucG9ydGVycy8xMjE0NDksIEkgdGhp
bmsgSSdkCj4+Pj4+PiByYXRoZXIgdGhpcyB3ZXJlIHJldmVydGVkLgo+Pj4+Pj4KPj4+Pj4+IFNp
bmNlIFRFU1QgYW5kIGhhcm5lc3MgYXV0b21hdGljYWxseSBoYW5kbGUgc2tpcHBpbmcga25vd24g
YnV0IG5vdAo+Pj4+Pj4gYnVpbHQgZXh0ZW5zaW9ucycgdGVzdHMsICRDb25maWd7ZXh0ZW5zaW9u
c30tY2hlY2tpbmcgY29kZQo+Pj4gc2hvdWxkbid0Cj4+Pj4+PiBjbHV0dGVyIHVwIHRoZSB0ZXN0
cy4KPj4+Pj4gSSBoYXZlbid0IGludmVzdGlnYXRlZCB0aGlzIGF0IGFsbCB5ZXQsIGJ1dCBJIHJl
Y2FsbCBubyBzbyBsb25nIGFnbwo+Pj4+PiBOaWNob2xhcyBnb2luZyB0aHJvdWdoIGxvdHMgb2Yg
dGVzdCBmaWxlcyBhbmQgaGF2aW5nIHRlc3RzIHNraXBwZWQKPj4+IGlmCj4+Pj4+IG1vZHVsZXMg
d2VyZW4ndCBidWlsdC4KPj4+Pj4KPj4+Pj4gQSBxdWljayBsb29rIGluIENoYW5nZXMgcmV2ZWFs
cyBxdWl0ZSBhIGZldyBzdWNoIGNoYW5nZXMsIGUuZy46Cj4+Pj4+Cj4+Pj4+IFNraXAgRGV2ZWw6
OlBQUG9ydCB0ZXN0cyBpZiBEZXZlbDo6UFBQb3J0IHdhcyBub3QgYnVpbHQ6Cj4+Pj4+IGh0dHA6
Ly9wdWJsaWMuYWN0aXZlc3RhdGUuY29tL2NnaS1iaW4vcGVybGJyb3dzZS9wLzIyOTUzCj4+Pj4+
Cj4+Pj4+IFNraXAgcmUgdGVzdHMgaWYgcmUgd2FzIG5vdCBidWlsdDoKPj4+Pj4gaHR0cDovL3B1
YmxpYy5hY3RpdmVzdGF0ZS5jb20vY2dpLWJpbi9wZXJsYnJvd3NlL3AvMjI5NTIKPj4+Pj4KPj4+
Pj4gU2tpcCBCIHRlc3RzIGlmIEIgd2FzIG5vdCBidWlsdDoKPj4+Pj4gaHR0cDovL3B1YmxpYy5h
Y3RpdmVzdGF0ZS5jb20vY2dpLWJpbi9wZXJsYnJvd3NlL3AvMjI5NTEKPj4+Pj4KPj4+Pj4gYW5k
IG90aGVycy4uLgo+Pj4+Pgo+Pj4+PiBJJ20gc3VyZSBhbGwgdGhvc2UgY2hhbmdlcyB3ZXJlbid0
IHVubmVjZXNzYXJ5LCBidXQgSSd2ZSBmb3Jnb3R0ZW4KPj4+IHdoYXQKPj4+Pj4gdGhlIG1vdGl2
YXRpb24gZm9yIHRoZW0gd2FzLiAgV2hhdGV2ZXIgaXQgd2FzIG1pZ2h0IGFsc28gYXBwbHkgdG8K
Pj4+Pj4gV2luMzJDT1JFIGFuZCBXaW4zMkFQSS4KPj4+PiBGV0lXLCBOaWNob2xhcyBhZGRlZCB0
aGUgYXV0b21hdGljIHNraXBwaW5nIHRvIFRFU1QgYW5kIGhhcm5lc3MgaW4KPj4+PiBodHRwOi8v
cHVibGljLmFjdGl2ZXN0YXRlLmNvbS9jZ2ktYmluL3Blcmxicm93c2UvcC8yMzQ0OAo+Pj4+IHNv
IHRoZSBiZWhhdmlvciB3YXNuJ3QgdGhlcmUgYXQgdGhlIHRpbWUgb2YgdGhlIGVhcmxpZXIgcGF0
Y2hlcwo+Pj4+IHlvdSBtZW50aW9uLgo+Pj4+Cj4+Pj4gTmljaG9sYXM/ICBXYXMgdGhhdCBpbnRl
bmRlZCB0byBiZSBpbiBhZGRpdGlvbiB0byBvciBpbnN0ZWFkIG9mCj4+Pj4gcGVyLXRlc3Qgc2tp
cHBpbmc/Cj4+Pgo+Pj4gSXQgc3RpbGwgbWFrZXMgc2Vuc2UgdG8gbWUgdG8gcmV2ZXJ0ICMzMDQw
OSwgdW5sZXNzIG90aGVyIHBlb3BsZQo+Pj4gb2JqZWN0Lgo+PiBJIGRvbid0IHN0cm9uZ2x5IG9i
amVjdCwgYnV0IEkgZG9uJ3Qgc2VlIGFueSBoYXJtIGluIGxlYXZpbmcgaXQgaW4uCj4+IE1vcmUg
Z2VuZXJhbGx5LCBJIGRvbid0IHNlZSBhbnkgZWFzeSwgbWFpbnRlbmFuY2UtZnJlZSB3YXkgdG8g
ZG8gdGhpcwo+PiByaWdodC4KPiAKPiBJJ2QgbGlrZSB0byBiZSBjb25zaXN0ZW50LCBhbmQgaXQg
c2VlbXMgdGhlIGVhc2llc3Qgd2F5IHRvIGdldCBhbmQKPiBzdGF5IGNvbnNpc3RlbnQgaXMgdG8g
cmVseSBvbiBURVNUIGFuZCBoYXJuZXNzIGRvaW5nIHRoZSByaWdodCB0aGluZwo+IGFuZCB7a25v
d25fLH1leHRlbnNpb25zIGJlaW5nIGtlcHQgY29ycmVjdCBmb3IgYWxsIHBsYXRmb3Jtcy4KCkkg
bGlrZSBjb25zaXN0ZW5jeSB0b28sIGJ1dCB3ZSBkb24ndCBnZXQgY29uc2lzdGVuY3kgYnkgcmV2
ZXJ0aW5nICMzMDQwOSAKdW5sZXNzIHdlIGFsc28gcmV2ZXJ0IG90aGVyIHNpbWlsYXIgY2hhbmdl
cyBzdWNoIGFzIHRoZSB0aHJlZSB0aGF0IEkgCmNpdGVkIGVhcmxpZXIgKGFib3ZlKSBhbmQgZG91
YnRsZXNzIGxvdHMgb2Ygb3RoZXJzIHRvby4KCkkgZG9uJ3QgaGF2ZSB0aW1lIHRvIGdvIHRocm91
Z2ggYWxsIHRoZSB0ZXN0cyBsb29raW5nIGZvciBzdWNoIHBpZWNlcyBvZiAKY29kZSByaWdodCBu
b3csIGJ1dCBpZiBhbnlvbmUgZWxzZSB3YW50cyB0byByZW1vdmUgYWxsIHN1Y2ggbmVlZGxlc3Mg
CmNydWZ0IHRoZW4gSSBjZXJ0YWlubHkgd291bGRuJ3Qgb2JqZWN0LgoKLS0gCgoKLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpSYWRhbiBDb21wdXRhdGlv
bmFsIEx0ZC4NCg0KVGhlIGluZm9ybWF0aW9uIGNvbnRhaW5lZCBpbiB0aGlzIG1lc3NhZ2UgYW5k
IGFueSBmaWxlcyB0cmFuc21pdHRlZCB3aXRoIGl0IGFyZSBjb25maWRlbnRpYWwgYW5kIGludGVu
ZGVkIGZvciB0aGUgYWRkcmVzc2VlKHMpIG9ubHkuIElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMg
bWVzc2FnZSBpbiBlcnJvciBvciB0aGVyZSBhcmUgYW55IHByb2JsZW1zLCBwbGVhc2Ugbm90aWZ5
IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkuIFRoZSB1bmF1dGhvcml6ZWQgdXNlLCBkaXNjbG9zdXJl
LCBjb3B5aW5nIG9yIGFsdGVyYXRpb24gb2YgdGhpcyBtZXNzYWdlIGlzIHN0cmljdGx5IGZvcmJp
ZGRlbi4gTm90ZSB0aGF0IGFueSB2aWV3cyBvciBvcGluaW9ucyBwcmVzZW50ZWQgaW4gdGhpcyBl
bWFpbCBhcmUgc29sZWx5IHRob3NlIG9mIHRoZSBhdXRob3IgYW5kIGRvIG5vdCBuZWNlc3Nhcmls
eSByZXByZXNlbnQgdGhvc2Ugb2YgUmFkYW4gQ29tcHV0YXRpb25hbCBMdGQuIFRoZSByZWNpcGll
bnQocykgb2YgdGhpcyBtZXNzYWdlIHNob3VsZCBjaGVjayBpdCBhbmQgYW55IGF0dGFjaGVkIGZp
bGVzIGZvciB2aXJ1c2VzOiBSYWRhbiBDb21wdXRhdGlvbmFsIHdpbGwgYWNjZXB0IG5vIGxpYWJp
bGl0eSBmb3IgYW55IGRhbWFnZSBjYXVzZWQgYnkgYW55IHZpcnVzIHRyYW5zbWl0dGVkIGJ5IHRo
aXMgZW1haWwuCg==
0
steve
3/14/2007 1:05:09 PM
Reply:

Similar Artilces:

test skipping based on $Config{extensions} (was: Re: [PATCH] Re: [PATCH] Re: Win32 modules & cygwin)
On Tue, Feb 27, 2007 at 02:43:29AM -0800, Yitzchak Scott-Thoennes wrote: > Steve Hay wrote: > > Yitzchak Scott-Thoennes wrote: > >> On Mon, Feb 26, 2007 at 01:28:51PM +0000, Steve Hay wrote: > >>> Thanks, applied as #30409. > >> > >> Um, given Craig's comment in > >> http://nntp.perl.org/group/perl.perl5.porters/121449, I think I'd > >> rather this were reverted. > >> > >> Since TEST and harness automatically handle skipping known but not > >> built extensions' tests, $Config{ext...

Re: [PATCH] Re: [PATCH] Re: Win32 modules & cygwin
From: Yitzchak Scott-Thoennes <sthoenna@efn.org> To: Cc: On Mon, Feb 26, 2007 at 01:28:51PM +0000, Steve Hay wrote: > Yitzchak Scott-Thoennes wrote: > >>On 2/23/07, Steve Hay <steve.hay@uk.radan.com> wrote: > >>>Craig Berry wrote: > >>>>Hmm. I get the following on VMS with blead@30382: > >>>> > >>>>ext/Win32API/File/t/file....................................FAILED at > >>>>test 1 > >>>>ext/Win32API/File/t/tie.....................................FAILED at > >>>...

RE: [PATCH Configure] was RE: [PATCH] was RE: Perl_die() /Perl_croak()
------_=_NextPart_001_01C708ED.431BF6FB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: H.Merijn Brand [mailto:h.m.brand@xs4all.nl] Sent: 14 November 2006 19:07 To: perl5-porters@perl.org Subject: Re: [PATCH Configure] was RE: [PATCH] was RE: Perl_die() /Perl_croak() >=0D > Patch to Configure and config_h.SH to calculate PRINTF_FORMAT_NULL_OK I'll have a look > I would edit the metaconfig units but I don't know how to get them. They're on my CPAN, but I do n...

RE: [patch] Configure problem on Cygwin (was: Re: dubious configu re error on cygwin)
We've been updating Configure to use the executable suffix on operating systems that use such suffixes (DOS DJGPP, Windows, VOS, to my knowledge so far). That's why the "ln*" is suddenly important. Sorry we missed this case (around line 2409). Thanks for fixing it. I actually think that the proper expression would be *"ln${exe_ext} -s:"*"test -"?) if variables can be substituted in this context. If not, then the way you have it is optimal. Thanks. PG -----Original Message----- From: Gerrit P. Haase [mailto:gp@familiehaase.de] Sent: T...

Re: [PATCH perldiag.pod] Re: [PATCH] Re: Useless use of constants
Benjamin Sugars <bsugars@canoe.ca> wrote > Hey, wait a minute. Didn't someone decide yesterday that perldiag.pod by > itself wasn't sufficient? Yeah, that was me. But I guess Sarathy outranks me. :-( I suspect the dichotomy is between those who "use diagnostics" and don't like their STDERR cluttered as against those who do not and are more concerned with the clutter in the rest of the pods. Mike Guy ...

RE : RE : RE : RE : Regular expressions
Here is a sample of what your piece of code returns on my Aix box. 44520 -> /prog/gena/8.1.1/bin/dispatch 44650 -> reproject 45176 -> aioserver 45432 -> aioserver 45724 -> -ksh 46002 -> /bin/bsh 46232 -> /usr/dt/bin/dtterm 46584 -> /usr/bin/ksh 46820 -> /usr/dt/bin/ttsession 47060 -> /bin/bsh 47304 -> /usr/dt/bin/dtlogin 47396 -> /usr/dt/bin/dtterm 47722 -> dtfile 47942 -> /usr/dt/bin/dtsession 48272 -> dtfile 48568 -> ora_cjq0_gist 48758 -> gxtrackd 49032 -> dtwm 49330 -> /usr/lib/lpd/pio/etc/piohpnpf 49592 -> b...

RE: [PATCH perlio.h] (was RE: [PATCH] %_ (was Re: [PATCH] operati on o n `PL_na' may be undefined))
The "audit" should reveal no cases in the 5.8.0 sources, because (a) I wrote a little script to check, (b) GCC would have spotted it. As Nick says, there are two possible solutions 1. Ban %_ in these functions, undo my patch, and gcc -Wall will find any transgressions. Any post-5.8.0 use of %_ in these functions would have to be reworked. 2. Allow %_ in these functions, and trawl through the #define spaghetti to ensure that these functions will always be defined (non-circularly) in terms of functions that implement %_. Robin -----Original Message...

Re: [PATCH] Re: File::Spec::Win32 problems [was: Re: Repost, different
Hi, First, thanks for the patch. Nice to see someone else interested in File::Spec::Win32. Here are some comments, though: > * catpath adds a \ between volume and directory if this was omitted First, this would better go to canonpath() so that "all methods get the benefit" (c) Schwern. Second, this is wrong. Here is why: in Win32, d:dir1\dir2 means dir1\dir2 relative to current working directory on drive D:, i.e. d:dir1\dir2 -> d:\<full-path-to-current-directory-of-drive-d:>\dir1\dir2 Judging from Cwd.pm, I'm afraid you cannot get cw...

Re: Re:
Sorry about that, my mistake, the patched method goes like this: procedure DeallocateHWnd(Wnd: HWND); var Instance: Pointer; begin Instance := Pointer(GetWindowLong(Wnd, GWL_WNDPROC)); if Instance <> @DefWindowProc then begin { make sure we restore the default windows procedure before freeing memory } SetWindowLong(Wnd, GWL_WNDPROC, Longint(@DefWindowProc)); FreeObjectInstance(Instance); end; DestroyWindow(Wnd); end; "Andreas Hausladen" <AndreasDOTHausladen@gObviousToBeRemovedmx.de> wrote in message news:99620@f...

RE: Re: [wxperl-users] Re: Re: EVT_QUERY_END_SESSION
you putted the EVT_CLOSE to the wrong place... or do you have a reason why you need it to be there? $app ist not the window, but you could use EVT_CLOSE on $frame too. i changed your minimal sample that it works. hope it helps greeting Marco ---- use Wx; ########################### package MyApp; use strict; use vars qw(@ISA); @ISA=qw(Wx::App); sub OnInit { my( $this ) = @_; my( $frame ) = MyFrame->new( "Minimal wxPerl app", Wx::Point->new( 50, 50 ), Wx::Size->new( 450, 350 ) ); ...

RE : RE : RE : RE : Regular expressions #2
No worries :-) It works now, thanks a lot :-) Best regards, Steve Hemond Programmeur Analyste / Analyst Programmer Smurfit-Stone, Ressources Foresti=E8res La Tuque, P.Q. Tel.: (819) 676-8100 X2833 shemond@smurfit.com=20 > -----Original Message----- > From: drieux [mailto:drieux@wetware.com]=20 > Sent: Wednesday, December 17, 2003 1:38 PM > To: Perl Perl > Subject: Re: RE : RE : RE : Regular expressions >=20 >=20 >=20 > On Dec 17, 2003, at 10:24 AM, drieux wrote: >=20 > > > > open(PS, "ps -efA|") or...

[PATCH] Re: Win32 modules & cygwin
------=_20070220015018_85400 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit On Mon, Feb 19, 2007 at 09:46:30PM -0800, Yitzchak Scott-Thoennes wrote: > Just a heads up: I've had some time to work on this. I've got a > patch I'm testing for parts 2 and 3 below (Jan already did part 1) > plus moving Win32API::File. > > As soon as everything passes on cygwin and mingw-under-cygwin, I'll > post it for others to test on VC with both dmake and nmake. Patch attached assumes win32/ext/Win32API has been moved to e...

RE: [PATCH] Re: [PATCH] support POSIX SA_SIGINFO
------_=_NextPart_001_01C59137.6F325985 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My weekly build of bleedperl failed last night: mg.c: In function `Perl_sighandler': mg.c:2715: structure has no member named `si_errno' I tracked it down to the sa_siginfo changes. Stratus VOS implements the 1996 revision of the POSIX standard. That version defines the minimum siginfo_t type to have the members si_code, si_signo, and si_value. The 2001 revision of the POSIX standard adds the si_errno, si_pid, si_uid, si_addr, ...

[PATCH Configure] was RE: [PATCH] was RE: Perl_die() / Perl_croak()
------_=_NextPart_001_01C70812.AFE43257 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: Rafael Garcia-Suarez [mailto:rgarciasuarez@mandriva.com] Sent: 13 November 2006 11:38 To: perl5-porters@perl.org Subject: Re: [PATCH] was RE: Perl_die() / Perl_croak() Robin Barker wrote: >=0D > Attached patch restores the printf checking of croak/die, in the presence= of -DPRINTF_FORMAT_NULL_OK > PRINTF_FORMAT_NULL_OK indicates that the compiler allows for format to be= null, e.g. not...

Web resources about - Re: test skipping based on $Config{extensions} (was: Re: [PATCH] Re: [PATCH] Re: Win32 modules & cygwin) - perl.perl5.porters

Resources last updated: 12/4/2015 7:56:46 AM