[PATCH] Don't export PL_underlying_numeric_obj if it doesn't exist.

--Apple-Mail=_15FFCD15-3925-4552-A256-B1180AC1B0DB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

My commit bit is having technical difficulties at the moment that are =
being worked on, but in the meantime I'd appreciate it if someone could =
apply the following; without it blead currently fails to build on VMS.  =
Patch both inline and attached.  Thanks.

=46rom efc4d5425aa6e2ec52753bc6f9505891b7e8db1f Mon Sep 17 00:00:00 2001
From: "Craig A. Berry" <craigberry@mac.com>
Date: Sat, 10 Feb 2018 17:05:07 -0600
Subject: [PATCH] Don't export PL_underlying_numeric_obj if it doesn't =
exist.

This broke the build on VMS and probably would on anything else
with strict linking where HAS_NEW_LOCALE is not defined.
---
 makedef.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/makedef.pl b/makedef.pl
index 5dc7bdf35c..93e47b03c5 100644
--- a/makedef.pl
+++ b/makedef.pl
@@ -403,6 +403,7 @@ unless ($define{'HAS_NEWLOCALE'} && ! =
$define{'NO_POSIX_2008_LOCALE'})
 {
     ++$skip{$_} foreach qw(
         PL_C_locale_obj
+        PL_underlying_numeric_obj
     );
 }

--
2.14.3 (Apple Git-98)


________________________________________
Craig A. Berry

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser



--Apple-Mail=_15FFCD15-3925-4552-A256-B1180AC1B0DB
Content-Disposition: attachment;
	filename=0001-Don-t-export-PL_underlying_numeric_obj-if-it-doesn-t.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0001-Don-t-export-PL_underlying_numeric_obj-if-it-doesn-t.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20efc4d5425aa6e2ec52753bc6f9505891b7e8db1f=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Craig=20A.=20Berry"=20<craigberry@mac.com>=0A=
Date:=20Sat,=2010=20Feb=202018=2017:05:07=20-0600=0ASubject:=20[PATCH]=20=
Don't=20export=20PL_underlying_numeric_obj=20if=20it=20doesn't=20exist.=0A=
=0AThis=20broke=20the=20build=20on=20VMS=20and=20probably=20would=20on=20=
anything=20else=0Awith=20strict=20linking=20where=20HAS_NEW_LOCALE=20is=20=
not=20defined.=0A---=0A=20makedef.pl=20|=201=20+=0A=201=20file=20=
changed,=201=20insertion(+)=0A=0Adiff=20--git=20a/makedef.pl=20=
b/makedef.pl=0Aindex=205dc7bdf35c..93e47b03c5=20100644=0A---=20=
a/makedef.pl=0A+++=20b/makedef.pl=0A@@=20-403,6=20+403,7=20@@=20unless=20=
($define{'HAS_NEWLOCALE'}=20&&=20!=20$define{'NO_POSIX_2008_LOCALE'})=0A=20=
{=0A=20=20=20=20=20++$skip{$_}=20foreach=20qw(=0A=20=20=20=20=20=20=20=20=
=20PL_C_locale_obj=0A+=20=20=20=20=20=20=20=20PL_underlying_numeric_obj=0A=
=20=20=20=20=20);=0A=20}=0A=20=0A--=20=0A2.14.3=20(Apple=20Git-98)=0A=0A=

--Apple-Mail=_15FFCD15-3925-4552-A256-B1180AC1B0DB--
0
craigberry
2/10/2018 11:43:10 PM
perl.perl5.porters 47002 articles. 0 followers. Follow

1 Replies
2 Views

Similar Articles

[PageSpeed] 21

On 02/10/2018 04:43 PM, Craig A. Berry wrote:
> My commit bit is having technical difficulties at the moment that are being worked on, but in the meantime I'd appreciate it if someone could apply the following; without it blead currently fails to build on VMS.  Patch both inline and attached.  Thanks.
> 
>  From efc4d5425aa6e2ec52753bc6f9505891b7e8db1f Mon Sep 17 00:00:00 2001
> From: "Craig A. Berry" <craigberry@mac.com>
> Date: Sat, 10 Feb 2018 17:05:07 -0600
> Subject: [PATCH] Don't export PL_underlying_numeric_obj if it doesn't exist.
> 
> This broke the build on VMS and probably would on anything else
> with strict linking where HAS_NEW_LOCALE is not defined.

Applied as 5b95d1b1b5e7cb1ddfe987a377507d21b7d91587

I already had this fixed locally, but forgot that blead had this 
variable already.
> ---
>   makedef.pl | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/makedef.pl b/makedef.pl
> index 5dc7bdf35c..93e47b03c5 100644
> --- a/makedef.pl
> +++ b/makedef.pl
> @@ -403,6 +403,7 @@ unless ($define{'HAS_NEWLOCALE'} && ! $define{'NO_POSIX_2008_LOCALE'})
>   {
>       ++$skip{$_} foreach qw(
>           PL_C_locale_obj
> +        PL_underlying_numeric_obj
>       );
>   }
> 
> --
> 2.14.3 (Apple Git-98)
> 
> 
> ________________________________________
> Craig A. Berry
> 
> "... getting out of a sonnet is much more
>   difficult than getting in."
>                   Brad Leithauser
> 
> 
0
public
2/11/2018 1:09:59 AM
Reply: