superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 169662] shortest version yet

Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder]
https://bugzilla.mozilla.org/show_bug.cgi?id=99048

Attachment 169662: shortest version yet
https://bugzilla.mozilla.org/attachment.cgi?id=169662&action=edit

------- Additional Comments from Karsten "Mnyromyr" D�sterloh
<mnyromyr@tprac.de>
> Beauty? :-P

Beauty lies within the eye of the beholder. ;-)
This patch is getting smaller and simpler with each incarnation - that's nearly
a kind of /mathematical/ beauty! :)

> For a start you shouldn't need .toLowerCase, then you should
> probably use .URI rather than .Value in case bsmedberg ever gets around to
> fixing the resource factory. Except you might find either aFolder.server.type

> or aFolder.server.localStoreType will suffice. I think the latter is
equivalent
> to your regexp although it treats rss and pop3 as local folders; .type will
of
> course be "none" for local folders.

Since aFolder.server.type differs between rss and pop3, I'll take that.

> No point having this outside the try block.

Ah, even more simplicity ahead. ;-)
0
bugzilla
12/27/2004 11:11:31 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
342 Views

Similar Articles

[PageSpeed] 46

Reply:

Similar Artilces:

superreview granted: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 169662] shortest version yet
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 169662: shortest version yet https://bugzilla.mozilla.org/attachment.cgi?id=169662&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I think that's as simplified as it's going to get ;-) ...

superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 159968] Mark all messages read on leaving folder
David Bienvenu <bienvenu@nventure.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 159968: Mark all messages read on leaving folder https://bugzilla.mozilla.org/attachment.cgi?id=159968&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> looks good to me - to make this really useful, we'd probably want to add yet some more prefs ui for it. ...

superreview denied: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 159968] Mark all messages read on leaving folder
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has denied David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 159968: Mark all messages read on leaving folder https://bugzilla.mozilla.org/attachment.cgi?id=159968&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> This will go wrong when you have multiple windows open, because all the observers wil...

superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 160316] cleaner version
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk {holiday 20040928 - 20041007} <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 160316: cleaner version https://bugzilla.mozilla.org/attachment.cgi?id=160316&action=edit ...

superreview cancelled: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 160316] cleaner version
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has cancelled Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 160316: cleaner version https://bugzilla.mozilla.org/attachment.cgi?id=160316&action=edit ...

superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 169647] even more simplistic beauty
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 169647: even more simplistic beauty https://bugzilla.mozilla.org/attachment.cgi?id=169647&action=edit ------- Additional Comments from Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> Addressed Neil's comment #18. ...

superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 170966] Supplementary patch (Seamonkey)
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 170966: Supplementary patch (Seamonkey) https://bugzilla.mozilla.org/attachment.cgi?id=170966&action=edit ...

superreview granted: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 171051] Supplementary patch (Seamonkey) [checkin version]
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has granted Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 171051: Supplementary patch (Seamonkey) [checkin version] https://bugzilla.mozilla.org/attachment.cgi?id=171051&action=edit ------- Additional Comments from Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> Carrying over David's r+ and Neil's sr+. ...

superreview granted: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 170966] Supplementary patch (Seamonkey)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 170966: Supplementary patch (Seamonkey) https://bugzilla.mozilla.org/attachment.cgi?id=170966&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> gDBView will never exist for a server, so you can get rid of the isServer ...

superreview cancelled: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 169647] even more simplistic beauty
Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de> has cancelled Karsten "Mnyromyr" D�sterloh <mnyromyr@tprac.de>'s request for superreview: Bug 99048: [RFE] Automatically mark newsgroup read [when leaving folder] https://bugzilla.mozilla.org/show_bug.cgi?id=99048 Attachment 169647: even more simplistic beauty https://bugzilla.mozilla.org/attachment.cgi?id=169647&action=edit ...

superreview requested: [Bug 130070] [RFE] "Mark All Read" should be added to mail folder contextual menu : [Attachment 135552] No "Mark Folder Read" for accounts fix
Aidas Kasparas <kaspar-bugmoz@inbox.lt> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 130070: [RFE] "Mark All Read" should be added to mail folder contextual menu http://bugzilla.mozilla.org/show_bug.cgi?id=130070 Attachment 135552: No "Mark Folder Read" for accounts fix http://bugzilla.mozilla.org/attachment.cgi?id=135552&action=edit ...

superreview granted: [Bug 130070] [RFE] "Mark All Read" should be added to mail folder contextual menu : [Attachment 135552] No "Mark Folder Read" for accounts fix
Scott MacGregor <mscott@mozilla.org> has granted Aidas Kasparas <kaspar-bugmoz@inbox.lt>'s request for superreview: Bug 130070: [RFE] "Mark All Read" should be added to mail folder contextual menu http://bugzilla.mozilla.org/show_bug.cgi?id=130070 Attachment 135552: No "Mark Folder Read" for accounts fix http://bugzilla.mozilla.org/attachment.cgi?id=135552&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> assuming neil's spacing comment :) ...

superreview requested: [Bug 220933] Manually marking message as Junk should mark it Read as well : [Attachment 192093] Always mark messages as read when flagged as junk, pref-independent
Jens Bannmann <jens.b@web.de> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 220933: Manually marking message as Junk should mark it Read as well https://bugzilla.mozilla.org/show_bug.cgi?id=220933 Attachment 192093: Always mark messages as read when flagged as junk, pref-independent https://bugzilla.mozilla.org/attachment.cgi?id=192093&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> dmose, could you sr this? In the meantime, bienvenu and I agreed to not make this pref-dependent, as the markAsReadOnSpam pref is abou...

superreview requested: [Bug 264382] Filter on RSS: Mark as Read, and Flag/Star, do not function for arriving items : [Attachment 234492] fix mark as read case (and perhaps star, for incoming msgs)
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer [:ss] <sspitzer@mozilla.com> for superreview: Bug 264382: Filter on RSS: Mark as Read, and Flag/Star, do not function for arriving items https://bugzilla.mozilla.org/show_bug.cgi?id=264382 Attachment 234492: fix mark as read case (and perhaps star, for incoming msgs) https://bugzilla.mozilla.org/attachment.cgi?id=234492&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> we need to set the db folder stream on the parser so the mail filters can manipulate the status f...

Web resources about - superreview requested: [Bug 99048] [RFE] Automatically mark newsgroup read [when leaving folder] : [Attachment 169662] shortest version yet - netscape.mozilla.reviewers

Facebook Users Automatically Checked In To Events They RSVPed Yes To
A reader tipped us off that Facebook is automatically checking in users at events that they RSVPed they would attend. continued… New Career ...

Now Users Can Remove Contacts Automatically Saved by Facebook’s Friend Finder
Two weeks ago, many Facebook users began asking questions about curiously good recommendations suddenly appearing in Facebook’s “People You May ...

App Store - Attachments.me- Gmail inbox software to efficiently manage emails, automatically send/upload ...
Get Attachments.me- Gmail inbox software to efficiently manage emails, automatically send/upload files to cloud storage(Dropbox, Box, and G Drive), ...

Automatically organize your desktop icons into shaded areas called Fences! - YouTube
Fences® is the most popular desktop organization tool used by millions of users worldwide. Create shaded areas called "fences" to automatically ...

CSAIL fixes software bugs automatically, in any language, by copying from safer applications
A new system can repair bugs in software using smart processing that imports functionality from other programs, all without access to source ...


Emailing porn at work not automatically sackable, court finds
Australia's federal court has upheld a ruling that emailing pornography in the workplace is not automatically a sackable offence.

Shazam iPhone app now listens for music, TV shows automatically
Shazam has updated its iPhone app to tag songs, TV shows and more on its own, no longer requiring users to open the app and tap a button.

App of the day: Human for iPhone automatically tracks your movements
Human for the iPhone is an activity tracker that automatically distinguishes between different types of movement.

iPhone 5 automatically rotates using Cycloramic App. - YouTube
[NEW VIDEO] Cycloramic 2.0 update teaser vid with panoramic photo preview: http://www.youtube.com/watch?v=cjHUID07xs4 Cycloramic has been Awarded ...

resources last updated: 11/20/2015 6:08:29 PM