superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this one

Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203

Attachment 204552: how 'bout this one
https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit
0
bugzilla
11/30/2005 3:10:10 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
572 Views

Similar Articles

[PageSpeed] 50

Reply:

Similar Artilces:

superreview denied: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this one
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204552: how 'bout this one https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This patch appears to be for bug 66049, and you haven't answered comment #71 correctly anyway. ...

superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from history
Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204513: try to purge invalid typed URLs from history https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> This fixes it and actually avoids purging redirected URLs (so BenB should be happy :)). I thought it wou...

superreview cancelled: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from history
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has cancelled Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204513: try to purge invalid typed URLs from history https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> I just reviewed this patch for bug 317819 ;-) ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

''''''''''''''''''''
Name: haznen Email: haznenatyahoodotcom Product: Gran Paradiso Alpha 8 Summary: '''''''''''''''''''' Comments: '''''''''''''''''''''''''''''''''''' Browser Details: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061204 UGES/1.7.2.0 GranParadiso/3.0a1 From URL: http://www.mozilla.org/projects/granparadiso/ Note to readers: Hendrix gives...

'''''
Name: mario Email: ramar17atfastwebnetdotit Product: Gran Paradiso Alpha 2 Summary: ''''' Comments: K: Browser Details: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2) Gecko/20070206 GranParadiso/3.0a2 ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 2) Can you (super-)review, compile, test, check it in ? ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137796] (Av2) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137796: (Av2) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137796&action=edit ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview requested: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 232722: change 'character coding' to 'character encoding' http://bugzilla.mozilla.org/show_bug.cgi?id=232722 Attachment 140854: Addressed jshin's comments http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit ...

superreview requested: [Bug 238733] Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js : [Attachment 144811] don't call the function if it's going to
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 238733: Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js https://bugzilla.mozilla.org/show_bug.cgi?id=238733 Attachment 144811: don't call the function if it's going to fail https://bugzilla.mozilla.org/attachment.cgi?id=144811&action=edit ...

superreview requested: [Bug 325680] 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div : [Attachment 225632] alternative fix
David Baron <dbaron@mozilla.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 325680: 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div https://bugzilla.mozilla.org/show_bug.cgi?id=325680 Attachment 225632: alternative fix https://bugzilla.mozilla.org/attachment.cgi?id=225632&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> What do you think about this alternative? This works, and seems a bit less scary to me. Altho...

superreview requested: [Bug 242591] r:/mozilla\xpcom\io\nsFastLoadService.cpp(...) : warning C4244: '=' : conversion from 'PRInt64' to 'PRUint32', possible loss of data : [Attachment 147654] proposed
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 242591: r:/mozilla\xpcom\io\nsFastLoadService.cpp(...) : warning C4244: '=' : conversion from 'PRInt64' to 'PRUint32', possible loss of data http://bugzilla.mozilla.org/show_bug.cgi?id=242591 Attachment 147654: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=147654&action=edit ...

superreview requested: [Bug 242588] r:\mozilla\extensions\cookie\nsCookiePermission.h(65) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRUint8', possible loss of data : [Attachment
Dan Witte <dwitte@stanford.edu> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 242588: r:\mozilla\extensions\cookie\nsCookiePermission.h(65) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRUint8', possible loss of data http://bugzilla.mozilla.org/show_bug.cgi?id=242588 Attachment 147650: tsk tsk http://bugzilla.mozilla.org/attachment.cgi?id=147650&action=edit ------- Additional Comments from Dan Witte <dwitte@stanford.edu> i could just ask darin for r+sr here, but i want the fun of making mconnor ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> { (Bv1) </mailnews/addrbook/src/ns*.*> patch 2003-12-29 15:10:42 neil.parkwaycc.co.uk: review+ } ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ...

superreview requested: [Bug 325680] 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div : [Attachment 226219] alternative fix #2
David Baron <dbaron@mozilla.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 325680: 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div https://bugzilla.mozilla.org/show_bug.cgi?id=325680 Attachment 226219: alternative fix #2 https://bugzilla.mozilla.org/attachment.cgi?id=226219&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> This does roughly what you suggested. (What scares me a bit about attachment 211958 is the p...

superreview requested: [Bug 325680] 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div : [Attachment 226224] alternative fix #2
David Baron <dbaron@mozilla.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 325680: 'width: auto' incorrectly shrink wraps on blocks inside a shrink-wrapped 'overflow'-non-'visible' div https://bugzilla.mozilla.org/show_bug.cgi?id=325680 Attachment 226224: alternative fix #2 https://bugzilla.mozilla.org/attachment.cgi?id=226224&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 299422] r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' : [Attach
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 299422: r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' https://bugzilla.mozilla.org/show_bug.cgi?id=299422 Attachment 187998: fix forward declaration https://bugzilla.mozilla.org/attachment.cgi?id=187998&action=edit ...

superreview requested: [Bug 279246] Implement '-moz-ime-mode' property (compatible property of WinIE's 'ime-mode') : [Attachment 219012] Patch rv3.0
Masayuki Nakano (Mozilla Japan)(Offline: 4/29 to 5/1 JST) <masayuki@d-toybox.com> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 279246: Implement '-moz-ime-mode' property (compatible property of WinIE's 'ime-mode') https://bugzilla.mozilla.org/show_bug.cgi?id=279246 Attachment 219012: Patch rv3.0 https://bugzilla.mozilla.org/attachment.cgi?id=219012&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(Offline: 4/29 to 5/1 JST) <masayuki@d-toybox.com> O.K. I change my mind. The '-moz-ime-mode&#...

superreview requested: [Bug 279246] Implement '-moz-ime-mode' property (compatible property of WinIE's 'ime-mode') : [Attachment 219023] Patch rv3.1
Masayuki Nakano (Mozilla Japan)(Offline: 4/29 to 5/1 JST) <masayuki@d-toybox.com> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 279246: Implement '-moz-ime-mode' property (compatible property of WinIE's 'ime-mode') https://bugzilla.mozilla.org/show_bug.cgi?id=279246 Attachment 219023: Patch rv3.1 https://bugzilla.mozilla.org/attachment.cgi?id=219023&action=edit ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 189307] typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play : [Attachment 135251] right
timeless@myrealbox.com <timeless@bemail.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 189307: typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play http://bugzilla.mozilla.org/show_bug.cgi?id=189307 Attachment 135251: right http://bugzilla.mozilla.org/attachment.cgi?id=135251&action=edit ...

Web resources about - superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this one - netscape.mozilla.reviewers

Resources last updated: 3/16/2016 10:10:45 PM