superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from history

Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203

Attachment 204513: try to purge invalid typed URLs from history
https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit

------- Additional Comments from Andrew Schultz <ajschult@verizon.net>
This fixes it and actually avoids purging redirected URLs (so BenB should be
happy :)).  I thought it would be sufficient to only try to purge if
userTypedValue wasn't null but userTypedValue was null in a few cases where I
typed the URL (userTypedValue gets mucked with all over the place).
0
bugzilla
11/30/2005 5:19:02 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
812 Views

Similar Articles

[PageSpeed] 52

Reply:

Similar Artilces:

superreview cancelled: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from history
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has cancelled Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204513: try to purge invalid typed URLs from history https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> I just reviewed this patch for bug 317819 ;-) ...

superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this one
Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204552: how 'bout this one https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit ...

superreview denied: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this one
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 9203: do not save 'dead' or incorrect url's in the location drop down https://bugzilla.mozilla.org/show_bug.cgi?id=9203 Attachment 204552: how 'bout this one https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This patch appears to be for bug 66049, and you haven't answered comment #71 correctly anyway. ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview requested: [Bug 261717] Can't copy Website header (URL) in RSS message's header : [Attachment 165556] patch that enables a context menu to copy the URL (now localizable)
David Fraser <davidf@sjsoft.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 261717: Can't copy Website header (URL) in RSS message's header https://bugzilla.mozilla.org/show_bug.cgi?id=261717 Attachment 165556: patch that enables a context menu to copy the URL (now localizable) https://bugzilla.mozilla.org/attachment.cgi?id=165556&action=edit ------- Additional Comments from David Fraser <davidf@sjsoft.com> Requesting review for this. It's a fairly straight forward patch, the main thing is whether it's correct to add ...

superreview requested: [Bug 299422] r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' : [Attach
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 299422: r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' https://bugzilla.mozilla.org/show_bug.cgi?id=299422 Attachment 187998: fix forward declaration https://bugzilla.mozilla.org/attachment.cgi?id=187998&action=edit ...

superreview requested: [Bug 212852] Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field : [Attachment 246602] proposed fix, v2
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Darin Fisher (Google) <darin.moz@gmail.com> for superreview: Bug 212852: Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field https://bugzilla.mozilla.org/show_bug.cgi?id=212852 Attachment 246602: proposed fix, v2 https://bugzilla.mozilla.org/attachment.cgi?id=246602&action=edit ...

superreview requested: [Bug 212852] Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field : [Attachment 247202] proposed fix, v3
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Darin Fisher (Google) <darin.moz@gmail.com> for superreview: Bug 212852: Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field https://bugzilla.mozilla.org/show_bug.cgi?id=212852 Attachment 247202: proposed fix, v3 https://bugzilla.mozilla.org/attachment.cgi?id=247202&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> I don't see how I'd get it done with FindChar... Broke it out to a method of it's own tho...

superreview requested: [Bug 212852] Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field : [Attachment 247268] proposed fix, v4
Magnus Melin <mkmelin+mozilla@iki.fi> has asked Darin Fisher (Google) <darin.moz@gmail.com> for superreview: Bug 212852: Browser assumes ftp protocol for URL's beginning with 'ftp' and written without protocol in address field https://bugzilla.mozilla.org/show_bug.cgi?id=212852 Attachment 247268: proposed fix, v4 https://bugzilla.mozilla.org/attachment.cgi?id=247268&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Addressing review comment. (BTW, the r is still valid, no?) ...

superreview requested: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Simon Woodside <sbwoodside@yahoo.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Simon Woodside <sbwoodside@yahoo.com> r+ ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline view
Chris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 330946: Can drag bookmarks into address book collection of Show All Bookmarks https://bugzilla.mozilla.org/show_bug.cgi?id=330946 Attachment 224328: invalidates drop if it's going to occur on a smart folder's outline view https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit ...

superreview requested: [Bug 238733] Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js : [Attachment 144811] don't call the function if it's going to
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 238733: Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js https://bugzilla.mozilla.org/show_bug.cgi?id=238733 Attachment 144811: don't call the function if it's going to fail https://bugzilla.mozilla.org/attachment.cgi?id=144811&action=edit ...

Web resources about - superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from history - netscape.mozilla.reviewers

Resources last updated: 1/1/2016 4:07:48 AM