superreview requested: [Bug 319854] Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] : [Attachment 205701] not all nsIDocShellTreeItem's are nsIDocShell's

timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback
<jst@mozilla.org> for superreview:
Bug 319854: Firefox crashes on redirect after Firefox-warning [@
DocumentViewerImpl::PermitUnload]
https://bugzilla.mozilla.org/show_bug.cgi?id=319854

Attachment 205701: not all nsIDocShellTreeItem's are nsIDocShell's
https://bugzilla.mozilla.org/attachment.cgi?id=205701&action=edit

------- Additional Comments from timeless@myrealbox.com <timeless@bemail.org>
this is for non gecko core creatures, it shouldn't fix firefox, but it is
broken:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/base/nsDocumentViewe
r.cpp&rev=MOZILLA_1_8_BRANCH&cvsroot=/cvsroot&mark=1163#1160
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/embedding/browser/webBrowse
r/nsWebBrowser.h&rev=1.49&mark=107,110,128#107
0
bugzilla
12/13/2005 7:33:14 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
552 Views

Similar Articles

[PageSpeed] 37

Reply:

Similar Artilces:

superreview granted: [Bug 319854] Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] : [Attachment 205701] not all nsIDocShellTreeItem's are nsIDocShell's
Johnny Stenback <jst@mozilla.org> has granted timeless (will be away 1/15-1/27) <timeless@bemail.org>'s request for superreview: Bug 319854: Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] https://bugzilla.mozilla.org/show_bug.cgi?id=319854 Attachment 205701: not all nsIDocShellTreeItem's are nsIDocShell's https://bugzilla.mozilla.org/attachment.cgi?id=205701&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 189307] typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play : [Attachment 135251] right
timeless@myrealbox.com <timeless@bemail.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 189307: typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play http://bugzilla.mozilla.org/show_bug.cgi?id=189307 Attachment 135251: right http://bugzilla.mozilla.org/attachment.cgi?id=135251&action=edit ...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock wh...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Fixes the assertion independen...

superreview requested: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This patch fixes biesi's nits. I also added a comment to note that the DDE application name is set via splash.rc (at ...

superreview requested: [Bug 424333] crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] : [Attachment 331580] Updated for mozilla-central
Mats Palmgren <mats.palmgren@bredband.net> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 424333: crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] https://bugzilla.mozilla.org/show_bug.cgi?id=424333 Attachment 331580: Updated for mozilla-central https://bugzilla.mozilla.org/attachment.cgi?id=331580&action=edit ...

superreview requested: [Bug 424333] crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] : [Attachment 326232] Updated for mozilla-central
Mats Palmgren <mats.palmgren@bredband.net> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 424333: crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] https://bugzilla.mozilla.org/show_bug.cgi?id=424333 Attachment 326232: Updated for mozilla-central https://bugzilla.mozilla.org/attachment.cgi?id=326232&action=edit ...

superreview requested: [Bug 320914] Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] : [Attachment 206468] patch addressing Aaron's comment
Ginn Chen <ginn.chen@sun.com> has asked for superreview: Bug 320914: Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] https://bugzilla.mozilla.org/show_bug.cgi?id=320914 Attachment 206468: patch addressing Aaron's comment https://bugzilla.mozilla.org/attachment.cgi?id=206468&action=edit ...

superreview requested: [Bug 272882] Firefox doesn't exit properly with ChatZilla : [Attachment 181349] Fixes Chatzilla's handling of -chat parameter values. (cvs diff version)
Justin Turner Arthur <justinarthur@ieee.org> has asked for superreview: Bug 272882: Firefox doesn't exit properly with ChatZilla https://bugzilla.mozilla.org/show_bug.cgi?id=272882 Attachment 181349: Fixes Chatzilla's handling of -chat parameter values. (cvs diff version) https://bugzilla.mozilla.org/attachment.cgi?id=181349&action=edit ------- Additional Comments from Justin Turner Arthur <justinarthur@ieee.org> Hannibal provided me with this version of my patch using CVS instead of a local diff. ...

superreview requested: [Bug 246892] Firefox crash when this page is opened [@ nsXPCWrappedJSClass::GetInterfaceName ] shockwave plugin? : [Attachment 161226] Prevent nsXPCWrappedJSClass's from going
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 246892: Firefox crash when this page is opened [@ nsXPCWrappedJSClass::GetInterfaceName ] shockwave plugin? https://bugzilla.mozilla.org/show_bug.cgi?id=246892 Attachment 161226: Prevent nsXPCWrappedJSClass's from going away while its code is on the stack. https://bugzilla.mozilla.org/attachment.cgi?id=161226&action=edit ...

superreview requested: [Bug 320914] Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] : [Attachment 206468] patch addressing Aaron's comment #2
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 320914: Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] https://bugzilla.mozilla.org/show_bug.cgi?id=320914 Attachment 206468: patch addressing Aaron's comment https://bugzilla.mozilla.org/attachment.cgi?id=206468&action=edit ...

superreview requested: [Bug 238733] Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js : [Attachment 144811] don't call the function if it's going to
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 238733: Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js https://bugzilla.mozilla.org/show_bug.cgi?id=238733 Attachment 144811: don't call the function if it's going to fail https://bugzilla.mozilla.org/attachment.cgi?id=144811&action=edit ...

superreview requested: [Bug 408792] Eliminate more QI' s from performance hotspots. : [Attachment 293639] Eliminate QI's that aren 't needed.
Johnny Stenback (:jst) <jst@mozilla.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408792: Eliminate more QI's from performance hotspots. https://bugzilla.mozilla.org/show_bug.cgi?id=408792 Attachment 293639: Eliminate QI's that aren't needed. https://bugzilla.mozilla.org/attachment.cgi?id=293639&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> When running JS that ends up doing a lot of flushes on the document w/o anything changed in the document (which hap...

Web resources about - superreview requested: [Bug 319854] Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] : [Attachment 205701] not all nsIDocShellTreeItem's are nsIDocShell's - netscape.mozilla.reviewers

Resources last updated: 12/22/2015 7:23:44 PM