superreview requested: [Bug 319391] "eval('...') = ..." gives "invalid assignment lefthand side" as a compile-time error instead of as a runtime error : [Attachment 205374] revert regressing change

Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org>
for superreview:
Bug 319391: "eval('...') = ..." gives "invalid assignment lefthand side" as a
compile-time error instead of as a runtime error
https://bugzilla.mozilla.org/show_bug.cgi?id=319391

Attachment 205374: revert regressing change
https://bugzilla.mozilla.org/attachment.cgi?id=205374&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
The effect is to turn a JSOP_EVAL in a left-hand side of assignment into a
JSOP_SETCALL.  The obj_eval native would still be called if the assignment was
reached at runtime, and JSOP_SETCALL would throw JSMSG_BAD_LEFTSIDE_OF_ASS
after obj_eval failed to set cx->rval2set.  So we'd be ECMA-compliant and
backward compatible with this fix.

/be
0
bugzilla
12/9/2005 6:41:28 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
730 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview granted: [Bug 319391] "eval('...') = ..." gives "invalid assignment lefthand side" as a compile-time error instead of as a runtime error : [Attachment 205374] revert regressing change
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 319391: "eval('...') = ..." gives "invalid assignment lefthand side" as a compile-time error instead of as a runtime error https://bugzilla.mozilla.org/show_bug.cgi?id=319391 Attachment 205374: revert regressing change https://bugzilla.mozilla.org/attachment.cgi?id=205374&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver ...

superreview requested: [Bug 162432] In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const MOZILLA_CONTENT_PACK" (when opening 'Compose' for the first time in the "session") : [At #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 162432: In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const MOZILLA_CONTENT_PACK" (when opening 'Compose' for the first time in the "session") http://bugzilla.mozilla.org/show_bug.cgi?id=162432 Attachment 139340: (Bv1) <msgCompSMIMEOverlay.xul> http://bugzilla.mozilla.org/attachment.cgi?id=139340&action=edit ...

superreview requested: [Bug 162432] In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const MOZILLA_CONTENT_PACK" (when opening 'Compose' for the first time in the "session") : [At #3
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@sspitzer.org> for superreview: Bug 162432: In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const MOZILLA_CONTENT_PACK" (when opening 'Compose' for the first time in the "session") http://bugzilla.mozilla.org/show_bug.cgi?id=162432 Attachment 139619: (Cv1) <SearchDialog.xul> http://bugzilla.mozilla.org/attachment.cgi?id=139619&action=edit ...

superreview requested: [Bug 444994] In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel : [Attachment 333894] Fix regression per Neil's suggestion
Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444994: In <folderWidgets.xml>, "Error: aFolder is null", loading "Junk Settings" panel https://bugzilla.mozilla.org/show_bug.cgi?id=444994 Attachment 333894: Fix regression per Neil's suggestion https://bugzilla.mozilla.org/attachment.cgi?id=333894&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> So this is what you had in mind, right? ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialog
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 147374: fix error dialog http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

"Compilation Error Compiler Error Message: BC30002: Type "'ws.Email' is not defined." after webservice request.
Hi,  I created a Webservice, which sends emails of a filled form. Offline I have no problems to get it to work, but when I put my website online I get "Compilation Error Compiler Error Message: BC30002: Type "'ws.Email'  is not defined." It seems it can't find the webservice anymore, although I added the webreference (which worked fine) before I put the website online (with dir App_WebReferences -> ws -> Email.wsdl,...)  This is the code which requests the webrequest:Dim SendEmail As New ws.Email() SendEmail.Send_Mail(code, 2, TextB...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 174788] (Tv1) transformiix/xpath
Serge GAUTHERIE <gautheri@noos.fr> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") https://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 174788: (Tv1) transformiix/xpath https://bugzilla.mozilla.org/attachment.cgi?id=174788&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Thanks ! I wonder if fixing {{ 10. extensions/transformiix/source/xpath/XFormsFunctionCall...

superreview requested: [Bug 403173] Change "it's" to "it is" in Empty Cache dialog : [Attachment 294624] No more " =?UTF-8?Q?it=E2=80=99s?=" in the cache
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 403173: Change "it's" to "it is" in Empty Cache dialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D403173 Attachment 294624: No more "it=E2=80=99s" in the cache https://bugzilla.mozilla.org/attachment.cgi?id=3D294624&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> (In reply to comment #3)=0D > This should probably be ano...

superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ...

Web resources about - superreview requested: [Bug 319391] "eval('...') = ..." gives "invalid assignment lefthand side" as a compile-time error instead of as a runtime error : [Attachment 205374] revert regressing change - netscape.mozilla.reviewers

Resources last updated: 1/16/2016 5:54:52 PM