superreview granted: [Bug 318866] Selecting "Sort Folder..." from context menu in Bookmark Manager results in XML Parsing Error: undefined entity (sortFolder.xul) : [Attachment 205626] Patch for DTD jag (Peter Annema) <jag@tty.nl> has granted Peter Weilbacher
<mozilla@Weilbacher.org>'s request for superreview:
Bug 318866: Selecting "Sort Folder..." from context menu in Bookmark Manager
results in XML Parsing Error: undefined entity (sortFolder.xul)
https://bugzilla.mozilla.org/show_bug.cgi?id=318866
Attachment 205626: Patch for DTD only
https://bugzilla.mozilla.org/attachment.cgi?id=205626&action=edit
...
superreview requested: [Bug 219355] XML Parsing Error: undefined entity on files with Mime-Type: application/xhtml+xml, including about:, or "text/xml" : [Attachment 131594] use NS_GRE_DIRBenjamin Smedberg <bsmedberg@covad.net> has asked Darin Fisher <darin@meer.net>
for superreview:
Bug 219355: XML Parsing Error: undefined entity on files with Mime-Type:
application/xhtml+xml, including about:, or "text/xml"
http://bugzilla.mozilla.org/show_bug.cgi?id=219355
Attachment 131594: use NS_GRE_DIR
http://bugzilla.mozilla.org/attachment.cgi?id=131594&action=edit
...
superreview requested: [Bug 288980] Add "View (reveal) in Bookmark Manager" contextual menu item for folders in the Bookmark Bar. : [Attachment 247915] review comments addressedfroodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com>
for superreview:
Bug 288980: Add "View (reveal) in Bookmark Manager" contextual menu item for
folders in the Bookmark Bar.
https://bugzilla.mozilla.org/show_bug.cgi?id=288980
Attachment 247915: review comments addressed
https://bugzilla.mozilla.org/attachment.cgi?id=247915&action=edit
------- Additional Comments from froodian <stridey@gmail.com>
r=me. shiny.
...
superreview requested: [Bug 230349] History context menu reads "Bookmark this Page(L)" when multiple entries selected : [Attachment 138658] proposed patchAndreas Kunz <durbacher@gmx.de> has asked Alec Flett <alecf@flett.org> for
superreview:
Bug 230349: History context menu reads "Bookmark this Page(L)" when multiple
entries selected
http://bugzilla.mozilla.org/show_bug.cgi?id=230349
Attachment 138658: proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=138658&action=edit
------- Additional Comments from Andreas Kunz <durbacher@gmx.de>
Requesting r= from Neil and sr= from alecf.
If you test this and encounter problems in the context menu it's probably
covered by my patch in bug 1335...
superreview requested: [Bug 358149] "Expand" item on context menu for bookmark groups has no function : [Attachment 246330] Patch to remove "Expand" item v5.3ParadigmK <paradigmk@technodrome.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 358149: "Expand" item on context menu for bookmark groups has no function
https://bugzilla.mozilla.org/show_bug.cgi?id=358149
Attachment 246330: Patch to remove "Expand" item v5.3
https://bugzilla.mozilla.org/attachment.cgi?id=246330&action=edit
------- Additional Comments from ParadigmK <paradigmk@technodrome.com>
Thanks, I should have seen that earlier. Carrying over r+ from v5.1.
...
superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On CrackStuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with
alternate menu items
https://bugzilla.mozilla.org/show_bug.cgi?id=290212
Attachment 237073: A Patch Not On Crack
https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit
------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
r=me. Style stuff:
>+ NSMenuItem* menuItem = [[NSMenuItem alloc]
initWithTitle:NSL...
superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patchfroodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with
alternate menu items
https://bugzilla.mozilla.org/show_bug.cgi?id=290212
Attachment 241797: r=smorgan patch
https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit
...
superreview requested: [Bug 424767] SeaMonkey/Thunderbird <about:> start page gives "XML Parsing Error: undefined entity" : [Attachment 316973] Fix v.1Phil Ringnalda (:philor) <philringnalda@gmail.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 424767: SeaMonkey/Thunderbird <about:> start page gives "XML Parsing Error:
undefined entity"
https://bugzilla.mozilla.org/show_bug.cgi?id=424767
Attachment 316973: Fix v.1
https://bugzilla.mozilla.org/attachment.cgi?id=316973&action=edit
------- Additional Comments from Phil Ringnalda (:philor)
<philringnalda@gmail.com>
Lots of ways we could go here, right down to precisely saying that for DTD
loads with aRequestingLocation ...
superreview granted: [Bug 219355] XML Parsing Error: undefined entity on files with Mime-Type: application/xhtml+xml, including about:, or "text/xml" : [Attachment 131594] use NS_GRE_DIRDarin Fisher <darin@meer.net> has granted Benjamin Smedberg
<bsmedberg@covad.net>'s request for superreview:
Bug 219355: XML Parsing Error: undefined entity on files with Mime-Type:
application/xhtml+xml, including about:, or "text/xml"
http://bugzilla.mozilla.org/show_bug.cgi?id=219355
Attachment 131594: use NS_GRE_DIR
http://bugzilla.mozilla.org/attachment.cgi?id=131594&action=edit
...
superreview requested: [Bug 332144] "Subscriptions" context menu should allow "Reload All Live Bookmarks" : [Attachment 218218] Enables menu itemPam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at
mozilla dot org for email) <bugs@bengoodger.com> for superreview:
Bug 332144: "Subscriptions" context menu should allow "Reload All Live
Bookmarks"
https://bugzilla.mozilla.org/show_bug.cgi?id=332144
Attachment 218218: Enables menu item
https://bugzilla.mozilla.org/attachment.cgi?id=218218&action=edit
------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com>
Also updates comments and fixes indentation in a related section of code.
...
superreview requested: [Bug 205138] "New Folder" button in "File Bookmark" dialog does nothing : [Attachment 131254] modified addBookmark.js to always select a folder in the treeMichael Kaply <mkaply@us.ibm.com> has asked Brian Ryner <bryner@brianryner.com>
for superreview:
Bug 205138: "New Folder" button in "File Bookmark" dialog does nothing
http://bugzilla.mozilla.org/show_bug.cgi?id=205138
Attachment 131254: modified addBookmark.js to always select a folder in the tree
http://bugzilla.mozilla.org/attachment.cgi?id=131254&action=edit
------- Additional Comments from Michael Kaply <mkaply@us.ibm.com>
r=mkaply
Should there be a firebird version of this patch?
Or are things totally different there?
...
superreview granted: [Bug 288980] Add "View (reveal) in Bookmark Manager" contextual menu item for folders in the Bookmark Bar. : [Attachment 247915] review comments addressedMike Pinkerton <mikepinkerton@mac.com> has granted froodian
<stridey@gmail.com>'s request for superreview:
Bug 288980: Add "View (reveal) in Bookmark Manager" contextual menu item for
folders in the Bookmark Bar.
https://bugzilla.mozilla.org/show_bug.cgi?id=288980
Attachment 247915: review comments addressed
https://bugzilla.mozilla.org/attachment.cgi?id=247915&action=edit
------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
...
superreview requested: [Bug 195315] [junk]neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David
Bienvenu <bienvenu@nventure.com> for superreview:
Bug 195315: [junk] - should add "Run Junk Mail Control on selected messages" to
Context menu since it was removed from Menu list
http://bugzilla.mozilla.org/show_bug.cgi?id=195315
Attachment 141615: Proposed Patch
http://bugzilla.mozilla.org/attachment.cgi?id=141615&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
Assuming you still want this, I chose "Recalulate Junk S...
superreview requested: [Bug 321973] context menu "Bookmark this link..." is broken : [Attachment 235485] patch v1Peter Kasting <pkasting@google.com> has asked Ben Goodger (use ben at mozilla
dot org for email) <bugs@bengoodger.com> for superreview:
Bug 321973: context menu "Bookmark this link..." is broken
https://bugzilla.mozilla.org/show_bug.cgi?id=321973
Attachment 235485: patch v1
https://bugzilla.mozilla.org/attachment.cgi?id=235485&action=edit
------- Additional Comments from Peter Kasting <pkasting@google.com>
This patch does several things:
* Allows callers that pop up the add bookmarks dialog to provide a desired
title. If no title is provided, fall b...