superreview requested: [Bug 31685] changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) : [Attachme
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 31685: changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) https://bugzilla.mozilla.org/show_bug.cgi?id=31685 Attachment 194837: Fixed patch https://bugzilla.mozilla.org/attachment.cgi?id=194837&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Turned out I had isSecu...

superreview granted: [Bug 31685] changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) : [Attachment
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 31685: changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) https://bugzilla.mozilla.org/show_bug.cgi?id=31685 Attachment 194837: Fixed patch https://bugzilla.mozilla.org/attachment.cgi?id=194837&action=edit ...

superreview cancelled: [Bug 31685] changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) : [Attachme
Frank Wein <bugzilla@mcsmurf.de> has cancelled neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 31685: changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock) https://bugzilla.mozilla.org/show_bug.cgi?id=31685 Attachment 171454: Non-working patch :-( https://bugzilla.mozilla.org/attachment.cgi?id=171454&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> clearing obsolete review re...

superreview requested: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 236541: "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used https://bugzilla.mozilla.org/show_bug.cgi?id=236541 Attachment 208411: Patch for the core code per comment 38. https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit ...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview requested: [Bug 450897] "Delete Mail marked as Junk in Folder" doesn't work with views / quicksearch : [Attachment 334642] Use gMsgFolderSelected
Kent James (:rkent) <kent@caspia.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 450897: "Delete Mail marked as Junk in Folder" doesn't work with views / quicksearch https://bugzilla.mozilla.org/show_bug.cgi?id=450897 Attachment 334642: Use gMsgFolderSelected https://bugzilla.mozilla.org/attachment.cgi?id=334642&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> With this patch, behavior should be: 1) When a virtual search folder is selected in the folder tree, Delete Junk in Folder (us...

superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...

superreview requested: [Bug 450897] "Delete Mail marked as Junk in Folder" doesn't work with views / quicksearch : [Attachment 334642] Use gMsgFolderSelected #2
neil@parkwaycc.co.uk <neil@httl.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 450897: "Delete Mail marked as Junk in Folder" doesn't work with views / quicksearch https://bugzilla.mozilla.org/show_bug.cgi?id=450897 Attachment 334642: Use gMsgFolderSelected https://bugzilla.mozilla.org/attachment.cgi?id=334642&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Why do quick search views sometimes not have a view folder but regular and cross-folder views do? ...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...

superreview requested: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 228282] patch that doesn't work
Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> https://bugzilla.mozilla.org/show_bug.cgi?id=343599 Attachment 228282: patch that doesn't work https://bugzilla.mozilla.org/attachment.cgi?id=228282&action=edit ------- Additional Comments from Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> while this doesn't fix the bug, it's probably still a good thing to ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #3
Daniel Veditz <dveditz@cruzio.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> blame says bsmed...

superreview granted: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 236541: "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used https://bugzilla.mozilla.org/show_bug.cgi?id=236541 Attachment 208411: Patch for the core code per comment 38. https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit ...