superreview requested: [Bug 313656] Generated content images don't work the first time : [Attachment 200660] Patch

Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.com> for
superreview:
Bug 313656: Generated content images don't work the first time
https://bugzilla.mozilla.org/show_bug.cgi?id=313656

Attachment 200660: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=200660&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
We need both parts, since nsImageLoadingContent just notifies on the
ImageState() difference, not the IntrinsicState() difference.  Perhaps we
should change that...
0
bugzilla
10/24/2005 9:53:56 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
270 Views

Similar Articles

[PageSpeed] 12

Reply:

Similar Artilces:

superreview granted: [Bug 313656] Generated content images don't work the first time : [Attachment 200660] Patch
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 313656: Generated content images don't work the first time https://bugzilla.mozilla.org/show_bug.cgi?id=313656 Attachment 200660: Patch https://bugzilla.mozilla.org/attachment.cgi?id=200660&action=edit ...

superreview requested: [Bug 294718] :hover with alternative list-style-image: image doesn't display correctly first time : [Attachment 190804] Patch
Boris Zbarsky (gone till Aug 14) <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 294718: :hover with alternative list-style-image: image doesn't display correctly first time https://bugzilla.mozilla.org/show_bug.cgi?id=294718 Attachment 190804: Patch https://bugzilla.mozilla.org/attachment.cgi?id=190804&action=edit ------- Additional Comments from Boris Zbarsky (gone till Aug 14) <bzbarsky@mit.edu> The comment describes what's going on here.... With this fix, preloading the image should work great,...

superreview requested: [Bug 167115] tree/listbox does't work with background styles (-image, -attachment) correctly : [Attachment 142455] Patch to mozilla\layout\xul\base
Alfred Kayser <alfredkayser@nl.ibm.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 167115: tree/listbox does't work with background styles (-image, -attachment) correctly https://bugzilla.mozilla.org/show_bug.cgi?id=167115 Attachment 142455: Patch to mozilla\layout\xul\base https://bugzilla.mozilla.org/attachment.cgi?id=142455&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Katakai-san, please hurry up to review this, if you can.=0D =0D Roc: Would you r+sr for this? Even if we...

superreview requested: [Bug 288098] Mozilla can't start when creat a new profile at the first time. : [Attachment 178918] patch
Boying Lu <brian.lu@sun.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 288098: Mozilla can't start when creat a new profile at the first time. https://bugzilla.mozilla.org/show_bug.cgi?id=288098 Attachment 178918: patch https://bugzilla.mozilla.org/attachment.cgi?id=178918&action=edit ...

superreview requested: [Bug 279308] Folders don't draw correctly on bookmarks toolbar when opened for the first time : [Attachment 172326] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 279308: Folders don't draw correctly on bookmarks toolbar when opened for the first time https://bugzilla.mozilla.org/show_bug.cgi?id=279308 Attachment 172326: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172326&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> So what's going on here is that XUL menus rely on sync frame construction when they make an attr change. I just filed bug 279703 on that. Th...

superreview requested: [Bug 96595] The method nsHTMLInputElement->Click() don't work for Image-Buttons : [Attachment 52110] untested patch
Boris Zbarsky (not able to do reviews) <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 96595: The method nsHTMLInputElement->Click() don't work for Image-Buttons http://bugzilla.mozilla.org/show_bug.cgi?id=96595 Attachment 52110: untested patch http://bugzilla.mozilla.org/attachment.cgi?id=52110&action=edit ------- Additional Comments from Boris Zbarsky (not able to do reviews) <bzbarsky@mit.edu> This patch makes sense. The file input discussion does not, to me. So I think we should just go with this... ...

superreview requested: [Bug 290878] Address Autocomplete don't work, always first entry was taken (regression) : [Attachment 181245] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 290878: Address Autocomplete don't work, always first entry was taken (regression) https://bugzilla.mozilla.org/show_bug.cgi?id=290878 Attachment 181245: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=181245&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is the "simple" fix. The other approach is to just use event.client* here and to make the tree code try to figure out whether it&...

superreview requested: [Bug 235691] Mozilla/Firefox don't start : [Attachment 170402] Patch to always get process dir from app image instead of env. variable
tqh <thesuckiestemail@yahoo.se> has asked Doug T <dougt@meer.net> for superreview: Bug 235691: Mozilla/Firefox don't start https://bugzilla.mozilla.org/show_bug.cgi?id=235691 Attachment 170402: Patch to always get process dir from app image instead of env. variable https://bugzilla.mozilla.org/attachment.cgi?id=170402&action=edit ------- Additional Comments from tqh <thesuckiestemail@yahoo.se> sr? (and if possible checkin) ...

superreview requested: [Bug 342780] Cmd and Shift modifiers for "View Image" don't work when pushing command after opening context menu : [Attachment 236888] r=hwaara patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 342780: Cmd and Shift modifiers for "View Image" don't work when pushing command after opening context menu https://bugzilla.mozilla.org/show_bug.cgi?id=342780 Attachment 236888: r=hwaara patch https://bugzilla.mozilla.org/attachment.cgi?id=236888&action=edit ------- Additional Comments from froodian <stridey@gmail.com> This patch - Implements the NSMenu class method |alternateMenuItemWithTitle| to allow for better code-sharing - Slims down a l...

superreview requested: [Bug 186789] Ctrl+Shift Shortcuts in Mozilla conflict with ISO 14755 Input methods (shift+ctrl keys don't work) [mark all read] : [Attachment 149870] Mailnews Patch v1
Philip K. Warren <pkw@us.ibm.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 186789: Ctrl+Shift Shortcuts in Mozilla conflict with ISO 14755 Input methods (shift+ctrl keys don't work) [mark all read] http://bugzilla.mozilla.org/show_bug.cgi?id=186789 Attachment 149870: Mailnews Patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=149870&action=edit ...

superreview requested: [Bug 186789] Ctrl+Shift Shortcuts in Mozilla conflict with ISO 14755 Input methods (shift+ctrl keys don't work) [mark all read] : [Attachment 149857] XPFE Patch v1
Philip K. Warren <pkw@us.ibm.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 186789: Ctrl+Shift Shortcuts in Mozilla conflict with ISO 14755 Input methods (shift+ctrl keys don't work) [mark all read] http://bugzilla.mozilla.org/show_bug.cgi?id=186789 Attachment 149857: XPFE Patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=149857&action=edit ...