superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)

Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 305705: Whitespace in <option> of <select> isn't selectable when width is
specified.
https://bugzilla.mozilla.org/show_bug.cgi?id=305705

Attachment 200452: Patch rev. 1 (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)"
is false so we never do the second pass reflow when the SELECT has a specified
width <= desired width of the widest option.

With this patch all the OPTIONs in Testcase #2 fills the SELECT, except for
6, 7 and 8 for the OPTION that has a specified 'width'. There is a gap at the
right the size of the combo button for those OPTIONs.
I don't see any way around that.
(Compare those with, 9, 10 and 11 where 'min-width' is used instead)
0
bugzilla
10/22/2005 5:35:11 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
644 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Whoops, I accidentally mixed up part of this with another patch. Someone please ...

superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> roc, what do you think? ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issue
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard Suitor <rsuitor@acm.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149525: Work around focus issue http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit ...

superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select> : [Attachment 281681] Alternative patch, rev. 2
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=382369 Attachment 281681: Alternative patch, rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=281681&action=edit ...

superreview requested: [Bug 283345] Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode : [Attachment 175337] Patch
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 283345: Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode https://bugzilla.mozilla.org/show_bug.cgi?id=283345 Attachment 175337: Patch https://bugzilla.mozilla.org/attachment.cgi?id=175337&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> The code used the wrong attribute to update this UI string. ...

superreview requested: [Bug 333243] Options inside <optgroup>s in RTL <selects>s are not indented : [Attachment 217684] patch
Uri Bernstein <uriber@gmail.com> has asked for superreview: Bug 333243: Options inside <optgroup>s in RTL <selects>s are not indented https://bugzilla.mozilla.org/show_bug.cgi?id=333243 Attachment 217684: patch https://bugzilla.mozilla.org/attachment.cgi?id=217684&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> I should have noticed this when I fixed bug 323040, but I didn't. I verified that this is the last place when left/right margin/padding are used when -moz-start/-moz-end should be used instead. ...

superreview requested: [Bug 277724] <select> and <textarea> don't restore disabled state : [Attachment 245370] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 277724: <select> and <textarea> don't restore disabled state https://bugzilla.mozilla.org/show_bug.cgi?id=277724 Attachment 245370: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I found that <button> doesn't restore disabled state either while doing this... ...

superreview requested: [Bug 333243] Options inside <optgroup>s in RTL <selects>s are not indented : [Attachment 217684] patch #2
Uri Bernstein <uriber@gmail.com> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 333243: Options inside <optgroup>s in RTL <selects>s are not indented https://bugzilla.mozilla.org/show_bug.cgi?id=333243 Attachment 217684: patch https://bugzilla.mozilla.org/attachment.cgi?id=217684&action=edit ...

superreview requested: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187358: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that <area> content does not have a primary frame, so we call |StopTrackingDragGesture()| and make an early re...

Web resources about - superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w) - netscape.mozilla.reviewers

Resources last updated: 12/20/2015 11:47:43 PM