superreview requested: [Bug 305528] Cannot setTimeout window.focus or window.alert : [Attachment 193751] Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj

Johnny Stenback <jst@mozilla.org> has asked Brendan Eich <brendan@mozilla.org>
for superreview:
Bug 305528: Cannot setTimeout window.focus or window.alert
https://bugzilla.mozilla.org/show_bug.cgi?id=305528

Attachment 193751: Make xpconnect attempt to use obj's outer if it can't find a
wrapper using the given obj
https://bugzilla.mozilla.org/attachment.cgi?id=193751&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.org>
This makes XPCWrappedNative::GetWrappedNativeOfJSObject() use obj's outer if it
can't find a wrapper with the given obj, which in this case is an inner window,
but the function we're calling comes from the outer window.
0
bugzilla
8/24/2005 10:17:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
643 Views

Similar Articles

[PageSpeed] 22

Reply:

Similar Artilces:

superreview granted: [Bug 305528] Cannot setTimeout window.focus or window.alert : [Attachment 193751] Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 305528: Cannot setTimeout window.focus or window.alert https://bugzilla.mozilla.org/show_bug.cgi?id=305528 Attachment 193751: Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj https://bugzilla.mozilla.org/attachment.cgi?id=193751&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Pre-emptive a=me as well as sr=me. This is it. /be ...

superreview requested: [Bug 307632] Can't extend Selection Class anymore with Firefox 1.5b1 : [Attachment 195818] Use the current inner scope when wrapping natives in an outer window's scope.
Johnny Stenback <jst@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 307632: Can't extend Selection Class anymore with Firefox 1.5b1 https://bugzilla.mozilla.org/show_bug.cgi?id=307632 Attachment 195818: Use the current inner scope when wrapping natives in an outer window's scope. https://bugzilla.mozilla.org/attachment.cgi?id=195818&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> This fixes this bug by making us always wrap all DOM things in an inner scope. We use the current inner here si...

superreview granted: [Bug 307632] Can't extend Selection Class anymore with Firefox 1.5b1 : [Attachment 195818] Use the current inner scope when wrapping natives in an outer window's scope.
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 307632: Can't extend Selection Class anymore with Firefox 1.5b1 https://bugzilla.mozilla.org/show_bug.cgi?id=307632 Attachment 195818: Use the current inner scope when wrapping natives in an outer window's scope. https://bugzilla.mozilla.org/attachment.cgi?id=195818&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> sr=me ahead of mrbkap, he better not embarrass me ;-). /be ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview requested: [Bug 300642] Fastback regression: screen readers can't load pages : [Attachment 189358] 1) Use active window for root accessible that we return, 2) don't cache accessible root
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 300642: Fastback regression: screen readers can't load pages https://bugzilla.mozilla.org/show_bug.cgi?id=300642 Attachment 189358: 1) Use active window for root accessible that we return, 2) don't cache accessible root since we already cache it elsewhere https://bugzilla.mozilla.org/attachment.cgi?id=189358&action=edit ...

superreview requested: [Bug 318106] ###!!! ASSERTION: Setting mutation listener bits on outer window?: 'window->IsInnerWindow()' : [Attachment 204464] Add nsIDocument::GetInnerWindow() and use it whe
Johnny Stenback <jst@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 318106: ###!!! ASSERTION: Setting mutation listener bits on outer window?: 'window->IsInnerWindow()' https://bugzilla.mozilla.org/show_bug.cgi?id=318106 Attachment 204464: Add nsIDocument::GetInnerWindow() and use it where needed. https://bugzilla.mozilla.org/attachment.cgi?id=204464&action=edit ...

superreview requested: [Bug 231384] global objects don't go away when closing window : [Attachment 139426] patch to (again) use prototype's nsIScriptContext for event handler compilation
David Baron <dbaron@dbaron.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 231384: global objects don't go away when closing window http://bugzilla.mozilla.org/show_bug.cgi?id=231384 Attachment 139426: patch to (again) use prototype's nsIScriptContext for event handler compilation http://bugzilla.mozilla.org/attachment.cgi?id=139426&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview requested: [Bug 191871] Find as you type stops working after a while : [Attachment 159748] If focused window is in window hierarchy of window that's closing, clear menu flags
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 191871: Find as you type stops working after a while https://bugzilla.mozilla.org/show_bug.cgi?id=191871 Attachment 159748: If focused window is in window hierarchy of window that's closing, clear menu flags https://bugzilla.mozilla.org/attachment.cgi?id=159748&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> Seeking r+sr = jst ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviews
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227973: tweaks in response to reviews https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> (In reply to comment #60) > (From update of attachment 227564 [edit]) > So this w...

superreview requested: [Bug 408143] JSObjects created by XPConnect don' t share scopes. : [Attachment 293041] Make XPConnect' s protos share their wrappers JSObjectOps.
Johnny Stenback (:jst) <jst@mozilla.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 408143: JSObjects created by XPConnect don't share scopes. https://bugzilla.mozilla.org/show_bug.cgi?id=408143 Attachment 293041: Make XPConnect's protos share their wrappers JSObjectOps. https://bugzilla.mozilla.org/attachment.cgi?id=293041&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> This patch does what I talked about above. It fixes all 4 combinations (there's actually 5, it turns out, the last one ...

superreview requested: [Bug 220215] use the xpcnativewrapper for the current callers of components.lookupmethod : [Attachment 135169] Actually it's document.location that's safe, window is totally u
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> for superreview: Bug 220215: use the xpcnativewrapper for the current callers of components.lookupmethod http://bugzilla.mozilla.org/show_bug.cgi?id=220215 Attachment 135169: Actually it's document.location that's safe, window is totally unsafe http://bugzilla.mozilla.org/attachment.cgi?id=135169&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Re-requesting reviews as the...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview granted: [Bug 300642] Fastback regression: screen readers can't load pages : [Attachment 189358] 1) Use active window for root accessible that we return, 2) don't cache accessible root si
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 300642: Fastback regression: screen readers can't load pages https://bugzilla.mozilla.org/show_bug.cgi?id=300642 Attachment 189358: 1) Use active window for root accessible that we return, 2) don't cache accessible root since we already cache it elsewhere https://bugzilla.mozilla.org/attachment.cgi?id=189358&action=edit ...

Web resources about - superreview requested: [Bug 305528] Cannot setTimeout window.focus or window.alert : [Attachment 193751] Make xpconnect attempt to use obj's outer if it can't find a wrapper using the given obj - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/31/2015 2:01:34 AM