superreview granted: [Bug 305312] Export Bookmarks save dialog doesn't expose "Hide Extension" UI : [Attachment 195631] expose "hide extension"Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano (use mozilla.mano@
for email) <bugs.mano@sent.com>'s request for superreview:
Bug 305312: Export Bookmarks save dialog doesn't expose "Hide Extension" UI
https://bugzilla.mozilla.org/show_bug.cgi?id=305312
Attachment 195631: expose "hide extension"
https://bugzilla.mozilla.org/attachment.cgi?id=195631&action=edit
------- Additional Comments from Simon Fraser <sfraser_bugs@smfr.org>
Pleaes check in on trunk and branch.
...
superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fixStuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not
reading bugmail) <mikepinkerton@mac.com> for superreview:
Bug 416063: "Save this password?" dialog has "Never Save" focused instead of
"Don't Save" with FKA on (again!)
https://bugzilla.mozilla.org/show_bug.cgi?id=416063
Attachment 304041: fix
https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit
...
superreview requested: [Bug 356411] Can't hide "Bonjour" in "Bookmarks" : [Attachment 242109] PatchStuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 356411: Can't hide "Bonjour" in "Bookmarks"
https://bugzilla.mozilla.org/show_bug.cgi?id=356411
Attachment 242109: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=242109&action=edit
------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
Duh, we already have a ref to the bookmarks menu.
r=me, assuming my cursory check for docs on that pref didn't miss something
official.
...
superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz
<dveditz@cruzio.com> for superreview:
Bug 315633: "Create Profile" dialog text doesn't match button text: "Click
Finish"->"Done", "click Next"->"Continue"
https://bugzilla.mozilla.org/show_bug.cgi?id=315633
Attachment 206616: Use Mac-appropriate text in profile creation
https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit
...
superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #3Daniel Veditz <dveditz@cruzio.com> has asked Benjamin Smedberg [:bs]
(bsmedberg@) <benjamin@smedbergs.us> for superreview:
Bug 315633: "Create Profile" dialog text doesn't match button text: "Click
Finish"->"Done", "click Next"->"Continue"
https://bugzilla.mozilla.org/show_bug.cgi?id=315633
Attachment 206616: Use Mac-appropriate text in profile creation
https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit
------- Additional Comments from Daniel Veditz <dveditz@cruzio.com>
blame says bsmed...
superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fixMike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart
Morgan <stuart.morgan@alumni.case.edu>'s request for superreview:
Bug 416063: "Save this password?" dialog has "Never Save" focused instead of
"Don't Save" with FKA on (again!)
https://bugzilla.mozilla.org/show_bug.cgi?id=416063
Attachment 304041: fix
https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit
------- Additional Comments from Mike Pinkerton (not reading bugmail)
<mikepinkerton@mac.com>
sr=pink
...
superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialogAndrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM)
<bryner@brianryner.com> for superreview:
Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install
wizard won't advance past "Next"
http://bugzilla.mozilla.org/show_bug.cgi?id=49487
Attachment 147374: fix error dialog
http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit
...
superreview granted: [Bug 356411] Can't hide "Bonjour" in "Bookmarks" : [Attachment 242109] PatchMike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan
<stuart.morgan@alumni.case.edu>'s request for superreview:
Bug 356411: Can't hide "Bonjour" in "Bookmarks"
https://bugzilla.mozilla.org/show_bug.cgi?id=356411
Attachment 242109: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=242109&action=edit
------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
...
superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
Similar to what we needed to do for exthandler.. set the NETWORK bit. All
places in webbrowserpersist that have a STATE_START ...
superreview requested: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patchAndrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 219662: "OK" button doesn't activate in "Link Properties" dialog
https://bugzilla.mozilla.org/show_bug.cgi?id=219662
Attachment 236543: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit
------- Additional Comments from Andrew Schultz <ajschult@verizon.net>
The autocomplete part has worked because typing in the textbox to active
autocomplete enables the button
...
superreview requested: [Bug 216479] when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info : [ Attachment 295016] proposed fixMagnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 216479: when saving drafts and templates, we don't save the "return
receipts" and "attach vcard" info
https://bugzilla.mozilla.org/show_bug.cgi?id=216479
Attachment 295016: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Everything else is in place, it's just that the parsed values were always
overridden by the identity prefs...
superreview requested: [Bug 198936] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226713] Add a "Do this automatically from now on" checkboxJens Bannmann <jens.b@web.de> has asked Scott MacGregor (Away June 2nd - June
18th) <mscott@mozilla.org> for superreview:
Bug 198936: "Do you wish to compact..." dialog has no "don't ask me again"
checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226713: Add a "Do this automatically from now on" checkbox
https://bugzilla.mozilla.org/attachment.cgi?id=226713&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Scott, could you r/sr this small change? It would be a huge usability win.....
superreview requested: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better capsChris Lawson (cl-bugs) <cl-bugs@chrislawson.net> has asked Mark Mentovai
<mark@moxienet.com> for superreview:
Bug 383545: "Are you sure you want to quit?" dialog dismissal button should
read "Don't Quit"
https://bugzilla.mozilla.org/show_bug.cgi?id=383545
Attachment 294627: Don't Quit, now with better caps
https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit
------- Additional Comments from Chris Lawson (cl-bugs)
<cl-bugs@chrislawson.net>
r=me. Thanks for fixing the code as well.
...
superreview requested: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226965] Add a "Do this automatically from now on" checkbox, v2Jens Bannmann <jens.b@web.de> has asked Scott MacGregor <mscott@mozilla.org>
for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226965: Add a "Do this automatically from now on" checkbox, v2
https://bugzilla.mozilla.org/attachment.cgi?id=226965&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Changed the dialog title to "Compact Folders" per bug 116215 comment 8 by
beltzn...