superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195821] Additional patch for lib/freebl from Wan-Teh

Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 303508: Add freebl shared libs that do only 64-bit integer math
https://bugzilla.mozilla.org/show_bug.cgi?id=303508

Attachment 195821: Additional patch for lib/freebl from Wan-Teh
https://bugzilla.mozilla.org/attachment.cgi?id=195821&action=edit

------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
This patch implements some of my suggested changes for
Sun's lib/freebl patch.

I eliminated the need to set the FREEBL_PARENT variable
for the recursive child builds.  This fixed the BUILD_TREE
build problem as a byproduct.

The most important change in this patch is to do the recursive
child builds in the lib/freebl directory and just change the
build output directory (OBJDIR).  This change enabled me to
not have to create symlinks or copies of any file.  Because
I don't need to change directory to do the recursive child
builds, I don't need to set their FREEBL_PARENT or CORE_DEPTH
variables.

I removed an unnecessary -L$(DIST)/lib from lib/freebl/config.mk.

I also removed the _ from the name of the "freebl_3" shared library.
My straightforward approach requires me to move the _ to the end
of the multiple freebl shared libraries, which produces ugly mapfile
names like freebl_32fpu_.def as Nelson pointed out in private email.
If that's a problem, I can fix it.
0
bugzilla
9/12/2005 11:46:54 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
396 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview denied: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195821] Additional patch for lib/freebl from Wan-Teh
Nelson Bolyard <nelson@bolyard.com> has denied Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195821: Additional patch for lib/freebl from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=195821&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I really like this patch's simplification of the Makefiles. The only reason for sr- here is the trailing underscores in file name...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195950] Additional patch for lib/freebl from Wan-Teh, v2
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195950: Additional patch for lib/freebl from Wan-Teh, v2 https://bugzilla.mozilla.org/attachment.cgi?id=195950&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> I fixed the file names of the generated mapfiles. I don't have time to separate the makefiles into parent and child makefiles in NSS 3.11. ...

superreview cancelled: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195950] Additional patch for lib/freebl from Wan-Teh, v2
Nelson Bolyard <nelson@bolyard.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195950: Additional patch for lib/freebl from Wan-Teh, v2 https://bugzilla.mozilla.org/attachment.cgi?id=195950&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> r=nelson. Saul has some additional review comments coming soon, I think. Suggestion: In manifest.mn, instead of adding 5 ne...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195953] Wan-Teh's code cleanup patch for lib/freebl/loader.c
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195953: Wan-Teh's code cleanup patch for lib/freebl/loader.c https://bugzilla.mozilla.org/attachment.cgi?id=195953&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> 1. Structure the ifdefs around the definitions of getLibName like this: #if defined(SOLARIS) && defined(__sparc) ... #e...

superreview granted: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195953] Wan-Teh's code cleanup patch for lib/freebl/loader.c
Nelson Bolyard <nelson@bolyard.com> has granted Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195953: Wan-Teh's code cleanup patch for lib/freebl/loader.c https://bugzilla.mozilla.org/attachment.cgi?id=195953&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> This patch seems fine to me, but please wait until we've built our alpha to check it in. ...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 194403] Add changes from freebl, coreconf, and shlibsign; address numerous review comments
Saul Edwards <saul.edwards.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 194403: Add changes from freebl, coreconf, and shlibsign; address numerous review comments https://bugzilla.mozilla.org/attachment.cgi?id=194403&action=edit ------- Additional Comments from Saul Edwards <saul.edwards.bugs@sun.com> This patch applies cleanly to the trunk. It builds and passes QA on Solaris and Linux AMD64 and Sol...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 194404] new freebl.def accompanies above patch
Saul Edwards <saul.edwards.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 194404: new freebl.def accompanies above patch https://bugzilla.mozilla.org/attachment.cgi?id=194404&action=edit ...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 193768] Add integer library builds for 64-bit sparc; split DEFINES and arch flags into separa
Nelson Bolyard <nelson@bolyard.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 193768: Add integer library builds for 64-bit sparc; split DEFINES and arch flags into separate sections https://bugzilla.mozilla.org/attachment.cgi?id=193768&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> r=nelson@bolyard provided you make the following changes. I don't need to see another patch ...

superreview denied: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 194403] Add changes from freebl, coreconf, and shlibsign; address numerous review comments
Wan-Teh Chang <wtchang@redhat.com> has denied Saul Edwards <saul.edwards.bugs@sun.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 194403: Add changes from freebl, coreconf, and shlibsign; address numerous review comments https://bugzilla.mozilla.org/attachment.cgi?id=194403&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> I'm sorry that my review comments are very long, but I did a careful review of this pat...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 197136] Replace IS_64 with new symbol that says "use 64 bit registers in 32-bit build"
Saul Edwards <saul.edwards.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 197136: Replace IS_64 with new symbol that says "use 64 bit registers in 32-bit build" https://bugzilla.mozilla.org/attachment.cgi?id=197136&action=edit ------- Additional Comments from Saul Edwards <saul.edwards.bugs@sun.com> I tested the performance of this patch on ultrasparc 3 (v440) and a target architecture for th...

superreview denied: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 194404] new freebl.def accompanies above patch
Wan-Teh Chang <wtchang@redhat.com> has denied Saul Edwards <saul.edwards.bugs@sun.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 194404: new freebl.def accompanies above patch https://bugzilla.mozilla.org/attachment.cgi?id=194404&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> We should use a version like NSSprivate_3.11 to suggest that this interface should only be used internally by NSS itself. See the namin...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195778] Patch to fix BUILD_TREE builds
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195778: Patch to fix BUILD_TREE builds https://bugzilla.mozilla.org/attachment.cgi?id=195778&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> It turns out that the child builds must use absolute pathnames as the values of their FREEBL_PARENT and COREDEPTH variables. This is because $(OBJDIR) is not alway...

superreview denied: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 193768] Add integer library builds for 64-bit sparc; split DEFINES and arch flags into separate
Wan-Teh Chang <wtchang@redhat.com> has denied Nelson Bolyard <nelson@bolyard.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 193768: Add integer library builds for 64-bit sparc; split DEFINES and arch flags into separate sections https://bugzilla.mozilla.org/attachment.cgi?id=193768&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Sorry, Saul. Although I didn't test this patch, I saw strong evidences in my ...

superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195778] Patch to fix BUILD_TREE builds #2
Nelson Bolyard <nelson@bolyard.com> has asked Julien Pierre <julien.pierre.bugs@sun.com> for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195778: Patch to fix BUILD_TREE builds https://bugzilla.mozilla.org/attachment.cgi?id=195778&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> Julien originally changed the FREEBL_PARENT and CORE_DEPTH to relative paths because the absolute paths were not working with cygwin. Something about /cy...

Web resources about - superreview requested: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195821] Additional patch for lib/freebl from Wan-Teh - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/22/2015 8:24:14 AM