superreview cancelled: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191278] remove the incorrect spacing change to the 'if' in ReadSubjectEntry()Nelson Bolyard <nelson@bolyard.com> has cancelled Robert Relyea
<rrelyea@redhat.com>'s request for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191278: remove the incorrect spacing change to the 'if' in
ReadSubjectEntry()
https://bugzilla.mozilla.org/attachment.cgi?id=191278&action=edit
------- Additional Comments from Nelson Bolyard <nelson@bolyard.com>
It appears to me that another patch (not this one) was checked in.
So I am cancelling the review requ...
superreview requested: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191277] Delay loading the S/MIME records on upgrade until the cert is loaded.Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191277: Delay loading the S/MIME records on upgrade until the cert
is loaded.
https://bugzilla.mozilla.org/attachment.cgi?id=191277&action=edit
...
superreview cancelled: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191277] Delay loading the S/MIME records on upgrade until the cert is loaded.Robert Relyea <rrelyea@redhat.com> has cancelled Robert Relyea
<rrelyea@redhat.com>'s request for superreview:
Bug 303010: Certificate upgrade can drop S/MIME certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=303010
Attachment 191277: Delay loading the S/MIME records on upgrade until the cert
is loaded.
https://bugzilla.mozilla.org/attachment.cgi?id=191277&action=edit
...
superreview requested: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chatimeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny
Stenback <jst@mozilla.jstenback.com> for superreview:
Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary
comptr, a comment change
http://bugzilla.mozilla.org/show_bug.cgi?id=242760
Attachment 147787: store rc's so ifs can check, drop temporary comptr, change
comment, check alloc
http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit
...
superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, changJohnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com
(working) <timeless@bemail.org>'s request for superreview:
Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary
comptr, a comment change
http://bugzilla.mozilla.org/show_bug.cgi?id=242760
Attachment 147787: store rc's so ifs can check, drop temporary comptr, change
comment, check alloc
http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
- element->Append...
superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this oneAndrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204552: how 'bout this one
https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit
...
superreview requested: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204513] try to purge invalid typed URLs from historyAndrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204513: try to purge invalid typed URLs from history
https://bugzilla.mozilla.org/attachment.cgi?id=204513&action=edit
------- Additional Comments from Andrew Schultz <ajschult@verizon.net>
This fixes it and actually avoids purging redirected URLs (so BenB should be
happy :)). I thought it wou...
superreview requested: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's commentsneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Scott
MacGregor <mscott@mozilla.org> for superreview:
Bug 232722: change 'character coding' to 'character encoding'
http://bugzilla.mozilla.org/show_bug.cgi?id=232722
Attachment 140854: Addressed jshin's comments
http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit
...
superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is showDoron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan
<roc@ocallahan.org> for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761
Attachment 149378: Change the check for if the dropdown is shown to the correct
way
http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit
...
superreview requested: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline viewChris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 330946: Can drag bookmarks into address book collection of Show All
Bookmarks
https://bugzilla.mozilla.org/show_bug.cgi?id=330946
Attachment 224328: invalidates drop if it's going to occur on a smart folder's
outline view
https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit
...
superreview denied: [Bug 9203] do not save 'dead' or incorrect url's in the location drop down : [Attachment 204552] how 'bout this oneneil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz
<ajschult@verizon.net>'s request for superreview:
Bug 9203: do not save 'dead' or incorrect url's in the location drop down
https://bugzilla.mozilla.org/show_bug.cgi?id=9203
Attachment 204552: how 'bout this one
https://bugzilla.mozilla.org/attachment.cgi?id=204552&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
This patch appears to be for bug 66049, and you haven't answered comment #71
correctly anyway.
...
superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review commentsBlake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for
superreview:
Bug 280713: ContinueInterruptedParsing doesn't set the current context's
scanner's mIncremental member correctly
https://bugzilla.mozilla.org/show_bug.cgi?id=280713
Attachment 173997: updated to review comments
https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit
...
superreview requested: [Bug 447567] Handle changes to 'filter', 'mask' and 'clip-path' CSS properties with a new style change hint : [Attachment 330886] fixRobert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has asked
David Baron [:dbaron] <dbaron@mozilla.com> for superreview:
Bug 447567: Handle changes to 'filter', 'mask' and 'clip-path' CSS properties
with a new style change hint
https://bugzilla.mozilla.org/show_bug.cgi?id=447567
Attachment 330886: fix
https://bugzilla.mozilla.org/attachment.cgi?id=330886&action=edit
------- Additional Comments from Robert O'Callahan (:roc) (Mozilla Corporation)
<roc@ocallahan.org>
Right now changes to these properties are handle...
superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for
superreview:
Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE'
http://bugzilla.mozilla.org/show_bug.cgi?id=228448
Attachment 137404: (Av1) <nsInternetSearchService.cpp>
http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
'r=?': (see comment 2)
Can you (super-)review, compile, test, check it in ?
...