superreview requested: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190339] Part 1 - Fix the crash

Mark Banner <bugzilla@standard8.demon.co.uk> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 301935: Crash when trying to send mail and collected address book doesn't
exist
https://bugzilla.mozilla.org/show_bug.cgi?id=301935

Attachment 190339: Part 1 - Fix the crash
https://bugzilla.mozilla.org/attachment.cgi?id=190339&action=edit

------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk>
I realise the branch isn't too far away - so I'm doing this patch in two parts.


The first (this one) fixes the crash by checking the address book database is
valid and then adding the appropriate null checks. This is just c++ fixes - and
I will try and get this in for 1.5, although I don't think its a very frequent
scenario (its still a crasher though).
0
bugzilla
7/24/2005 9:48:34 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
391 Views

Similar Articles

[PageSpeed] 44

Reply:

Similar Artilces:

superreview requested: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190426] Part 2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 301935: Crash when trying to send mail and collected address book doesn't exist https://bugzilla.mozilla.org/show_bug.cgi?id=301935 Attachment 190426: Part 2 - Warn the user before they delete the addr book that is set for collecting https://bugzilla.mozilla.org/attachment.cgi?id=190426&action=edit ...

superreview granted: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190426] Part 2
Scott MacGregor <mscott@mozilla.org> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 301935: Crash when trying to send mail and collected address book doesn't exist https://bugzilla.mozilla.org/show_bug.cgi?id=301935 Attachment 190426: Part 2 - Warn the user before they delete the addr book that is set for collecting https://bugzilla.mozilla.org/attachment.cgi?id=190426&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> yup, I misunderstood. How about changing the dialog wording...

superreview requested: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs.
Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 327403: Provide read-only detection for mailing list dialogs. https://bugzilla.mozilla.org/attachment.cgi?id=327403&action=edit ------- Additional Comments from Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> I wanted to come up with something for this before TB...

superreview granted: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs.
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com>'s request for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 327403: Provide read-only detection for mailing list dialogs. https://bugzilla.mozilla.org/attachment.cgi?id=327403&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Looks good - one comment nit: read-only? if so, sho...

superreview requested: [Bug 271700] Crash when I try to pass '@mozilla.org/messenger/progress;1' object to resgisterListener() method of the same object. : [Attachment 184865] Proposed Patch v1.1
Joshua Welderson <pythonesque+bugzilla@gmail.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 271700: Crash when I try to pass '@mozilla.org/messenger/progress;1' object to resgisterListener() method of the same object. https://bugzilla.mozilla.org/show_bug.cgi?id=271700 Attachment 184865: Proposed Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=184865&action=edit ...

superreview requested: [Bug 439354] OS X toolbar background doesn't have a good gradient : [Attachment 332342] part 1 (widget) v0.4: Address review comments
Markus Stange <mstange@themasta.com> has asked Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> for superreview: Bug 439354: OS X toolbar background doesn't have a good gradient https://bugzilla.mozilla.org/show_bug.cgi?id=3D439354 Attachment 332342: part 1 (widget) v0.4: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=3D332342&action=3Dedit ------- Additional Comments from Markus Stange <mstange@themasta.com> (In reply to comment #20)=0D > +// When used to draw the titlebar:=0D > +// *aIn =3D=3D 0 at the...

superreview requested: [Bug 439354] OS X toolbar background doesn't have a good gradient : [Attachment 332386] part 1 (widget) v0.5: Address review comments
Markus Stange <mstange@themasta.com> has asked Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> for superreview: Bug 439354: OS X toolbar background doesn't have a good gradient https://bugzilla.mozilla.org/show_bug.cgi?id=439354 Attachment 332386: part 1 (widget) v0.5: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=332386&action=edit ------- Additional Comments from Markus Stange <mstange@themasta.com> (In reply to comment #24) > Since you seem to have a good overview of it by now, would you like to docume...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
timeless@myrealbox.com (working) <timeless@bemail.org> has asked rbs@maths.uq.edu.au for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview requested: [Bug 275786] crash in [@ nsCharTraits<unsigned short>::length] changing username for existing Mail-Account will crash Mozilla [@ SINGSIGN_RemoveUserAfterLoginFailure] : [Attach
Philip K. Warren (IBM) <pkwarren@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 275786: crash in [@ nsCharTraits<unsigned short>::length] changing username for existing Mail-Account will crash Mozilla [@ SINGSIGN_RemoveUserAfterLoginFailure] https://bugzilla.mozilla.org/show_bug.cgi?id=275786 Attachment 169570: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=169570&action=edit ------- Additional Comments from Philip K. Warren (IBM) <pkwarren@gmail.com> This fixes the calls to use an empty string instead of a null p...

superreview granted: [Bug 271700] Crash when I try to pass '@mozilla.org/messenger/progress;1' object to resgisterListener() method of the same object. : [Attachment 184865] Proposed Patch v1.1
Dan Mosedale <dmose@mozilla.org> has granted Joshua Welderson <pythonesque+bugzilla@gmail.com>'s request for superreview: Bug 271700: Crash when I try to pass '@mozilla.org/messenger/progress;1' object to resgisterListener() method of the same object. https://bugzilla.mozilla.org/show_bug.cgi?id=271700 Attachment 184865: Proposed Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=184865&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview requested: [Bug 307056] Read-only address book cards should have just a ok button that doesn't try to update the card : [Attachment 196814] Follow up patch
Mark Banner <bugzilla@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 307056: Read-only address book cards should have just a ok button that doesn't try to update the card https://bugzilla.mozilla.org/show_bug.cgi?id=307056 Attachment 196814: Follow up patch https://bugzilla.mozilla.org/attachment.cgi?id=196814&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> This follow up patch changes NS_OK to NS_ERROR_NOT_IMPLEMENTED in nsAbLDAPCard::EditCardToDatabase. Now we're...

Web resources about - superreview requested: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190339] Part 1 - Fix the crash - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/27/2015 11:53:19 PM